Your message dated Fri, 09 Jun 2023 04:48:51 +0000
with message-id <[email protected]>
and subject line Bug#1037227: fixed in ctffind 4.1.14-2
has caused the Debian Bug report #1037227,
regarding ctffind: Fix build on non-x86 architectures
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1037227: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037227
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ctffind
Version: 4.1.14-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu mantic ubuntu-patch
Dear Maintainer,
* What led up to the situation?
This software uses x86 inline assembly and fails to build on other archs.
* What exactly did you do (or not do) that was effective (or ineffective)?
With this patch it will call sinf() and cosf() from the libc on non-x86
systems.
* What was the outcome of this action?
Now it builds on non-x86 systems.
*** /tmp/tmp0oj8o0mu/bug_body
In Ubuntu, the attached patch was applied to achieve the following:
to get is building on non-x86 systems.
* d/p/src-core-matrix: fix build on non-x86 architectures.
Stop using x86 inline assembly on non-x86 architecture and call sinf()
and cosf() functions from the libc.
Thanks for considering the patch.
*** /tmp/tmp0oj8o0mu/ctffind_4.1.14-1ubuntu1.debdiff
diff -Nru ctffind-4.1.14/debian/patches/series
ctffind-4.1.14/debian/patches/series
--- ctffind-4.1.14/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ ctffind-4.1.14/debian/patches/series 2023-06-08 12:14:33.000000000 +0100
@@ -0,0 +1 @@
+src-core-matrix
diff -Nru ctffind-4.1.14/debian/patches/src-core-matrix
ctffind-4.1.14/debian/patches/src-core-matrix
--- ctffind-4.1.14/debian/patches/src-core-matrix 1970-01-01
01:00:00.000000000 +0100
+++ ctffind-4.1.14/debian/patches/src-core-matrix 2023-06-08
12:14:33.000000000 +0100
@@ -0,0 +1,18 @@
+Description: Don't use inline assembly on non-x86 architectures
+
+Bug-Ubuntu: https://launchpad.net/bugs/2023288
+
+--- a/src/core/matrix.cpp
++++ b/src/core/matrix.cpp
+@@ -4,7 +4,11 @@
+ // think i got it from a book i had about game programming in c.. it's
probably slower than what the compiler would do these days.
+
+ #define AL_PI 3.14159265358979323846
++#if defined(__i386__) || defined(__x86_64__)
+ #define _AL_SINCOS(x, s, c) __asm__ ("fsincos" : "=t" (c), "=u" (s) :
"0" (x))
++#else
++#define _AL_SINCOS(x, s, c) s = sinf(x); c = cosf(x)
++#endif
+ #define FLOATSINCOS(x, s, c) _AL_SINCOS((x) * AL_PI / 128.0, s ,c)
+
+ #define MAKE_ROTATION_f(x, y, z) \
-- System Information:
Debian Release: bookworm/sid
APT prefers mantic
APT policy: (500, 'mantic'), (100, 'mantic-proposed')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.2.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8),
LANGUAGE=en_IE:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
--- End Message ---
--- Begin Message ---
Source: ctffind
Source-Version: 4.1.14-2
Done: Andreas Tille <[email protected]>
We believe that the bug you reported is fixed in the latest version of
ctffind, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Tille <[email protected]> (supplier of updated ctffind package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 08 Jun 2023 21:53:57 +0200
Source: ctffind
Architecture: source
Version: 4.1.14-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team
<[email protected]>
Changed-By: Andreas Tille <[email protected]>
Closes: 1037227
Changes:
ctffind (4.1.14-2) unstable; urgency=medium
.
* Team upload.
* Don't use inline assembly on non-x86 architectures (thanks for the patch
to Danilo Egea Gondolfo <[email protected]>)
Closes: #1037227 (LP: #2023288)
Checksums-Sha1:
2428a575ab8b4b1cb12f41f5833b1931f9a57d13 1997 ctffind_4.1.14-2.dsc
14555a87eb312dd41537348dac4ea371d79d9b21 4000 ctffind_4.1.14-2.debian.tar.xz
a8f62b53dee0bd1169e18f44ea62d894ff290a5c 11504 ctffind_4.1.14-2_amd64.buildinfo
Checksums-Sha256:
2cbf7eb3349adf1cc0fad984dec59afa4be2c0ac27017fea3a0eab1b32845d37 1997
ctffind_4.1.14-2.dsc
546b8138daa6f509d8d45fab93695cb58329136b8dbc1d96864cc22659e0cf72 4000
ctffind_4.1.14-2.debian.tar.xz
78a981652739653b96c269fc84cedd77f087d5e9554122f7b42b26a63802e561 11504
ctffind_4.1.14-2_amd64.buildinfo
Files:
b2d02b71abf6f88ff44c5206d5670ac9 1997 science optional ctffind_4.1.14-2.dsc
9e6c36f8e3c1ae0e83b5605399cd495b 4000 science optional
ctffind_4.1.14-2.debian.tar.xz
396b9621890fc738ee2e4ea6046af066 11504 science optional
ctffind_4.1.14-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmSCrQERHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtFY+g/+MshgZptMycZ5ksrc+NmjYaYv3r9X8tTo
33NOSHj7nZ72iDhkw+ygHR1+mcq/fYeIjlff6/uN2/VZSV3VhNy4/Lxl8n78qM4s
QP0BaOlLOzP0RFW0kRrCaM8efnHMtCzg3VUoPxck4u93nX86vk3mM07lWuGC15R8
18PkmAbjm44QtFsSPR7yjpjVoPsfgDNjS+x4cy22qPkVaYcIt8gXdOkt+BsQJchp
REgzx9pnU5ewqjKK8SlLbVljst84rFp3BK/oycBbYpVczlcVqX7MlAprohbcJFUM
DfUpdoejhspYG8/sOLo7bByeBZwHsKLttYn3xMwpnpSY8s4AXwfYBHORnIU+rhdX
44Ayba9vsIgBYnTTcVDI4LPis2NxNe3CUxRzBdOcd5et/6v6Qlic6t/qEQ/lByqT
/GYbTp2W976IQaaoxxuCpPr66EvE5MsChig0gPnPONk71VtMGhs7FBJcvCZVkm/y
loMJr9H2hD1uJ1brdG5Zwb2oTaUpJ9NBwojVLRVQdyCX4ZYxaS1UedewOlEqziby
BJz0GvRLKt3Op2L2q8Z5mJaoWCQ34l0XU6q6IO/PbeyepSA3S6aPoF2Sifg2ahdI
atbmKDzEmqBIxTBPdOO3k2tPr97GVSw71d+01tv5dARlFSBzUKEVfM3Hjl/c7s5M
vPgnJ+fhw80=
=P2hq
-----END PGP SIGNATURE-----
--- End Message ---
