Your message dated Wed, 21 Jun 2023 19:51:13 +0000
with message-id <[email protected]>
and subject line Bug#1038644: fixed in nfdump 1.7.1-3
has caused the Debian Bug report #1038644,
regarding nfdump: segfault if started with -R option
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1038644: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038644
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nfdump
Version: 1.7.1-2
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]
Dear Maintainer,
-R option is broken in nfdump-1.7.1-2. It used to work in infdump-1.6.22-2.
How to reproduce:
# /usr/bin/nfcapd -D -P /var/run/nfcapd/default.pid -w /var/cache/nfdump -S1 -b
120.0.1 -p 2055 -R 127.0.0.2 2055
Segmentation fault
The patch (trivial) is attached.
A minor change in /etc/init.d/nfdump conffile (added return 0) fixes false
"failed!" message from "/etc/init.d/nfdump start" which appears on systems
using sysvinit-core rather than systemd.
Thank you!
-- System Information:
Debian Release: 12.0
APT prefers stable-security
APT policy: (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-9-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled
Versions of packages nfdump depends on:
ii init-system-helpers 1.65.2
ii libbz2-1.0 1.0.8-5+b1
ii libc6 2.36-9
ii libpcap0.8 1.10.3-1
ii librrd8 1.7.2-4+b8
ii lsb-base 11.6
ii sysvinit-utils [lsb-base] 3.06-4
nfdump recommends no packages.
nfdump suggests no packages.
-- Configuration Files:
/etc/init.d/nfdump changed:
PATH=/sbin:/usr/sbin:/bin:/usr/bin
NAME=nfcapd
DESC='Netflow capture daemon'
NFCAPD='/usr/bin/nfcapd'
PIDDIR="/var/run/$NAME/"
[ -x "$NFCAPD" ] || exit 0
mkdir -p "$PIDDIR"
. /lib/init/vars.sh
. /lib/lsb/init-functions
do_start () {
local INSTANCE="$1"
local CONFIG="$2"
sh -n "$CONFIG" 2>/dev/null || return 2
cache_dir=
user=
group=
options=
. "$CONFIG"
[ "$options" ] || return 2
if [ "$cache_dir" ] ; then
mkdir -p "$cache_dir"
if [ "$user" ] && [ "$group" ] ; then
chown "$user:$group" "$cache_dir"
elif [ "$user" ] ; then
chown "$user" "$cache_dir"
fi
fi
local PIDFILE="$PIDDIR$INSTANCE.pid"
start-stop-daemon --start --quiet \
--pidfile "$PIDFILE" --exec "$NFCAPD" --test > /dev/null \
|| return 1
start-stop-daemon --start --quiet \
--pidfile "$PIDFILE" \
--exec "$NFCAPD" -- \
-D -P "$PIDFILE" \
$options \
|| return 2
sleep 1
start-stop-daemon --start --quiet \
--pidfile "$PIDFILE" --exec "$NFCAPD" --test > /dev/null \
&& return 2
return 0 # 20230617, sizif: shut up "failed!" complaint
}
do_stop () {
local INSTANCE="$1"
local PIDFILE="$PIDDIR/$INSTANCE.pid"
start-stop-daemon --stop --quiet \
--retry=TERM/30/KILL/5 --pidfile "$PIDFILE" --name "$NAME"
RETVAL="$?"
[ "$RETVAL" = 2 ] && return 2
# Many daemons don't delete their pidfiles when they exit.
rm -f "$PIDFILE"
return "$RETVAL"
}
EXIT=0
do_action () {
local CONFIG="$1"
INSTANCE="$(basename "${CONFIG%%.conf}")"
case "$ACTION" in
start)
[ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC" "$INSTANCE"
do_start "$INSTANCE" "$CONFIG"
case "$?" in
0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;;
2)
[ "$VERBOSE" != no ] && log_end_msg 1
EXIT=1
;;
esac
;;
stop)
[ "$VERBOSE" != no ] && log_daemon_msg "Stopping $DESC" "$INSTANCE"
do_stop "$INSTANCE"
case "$?" in
0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;;
2)
[ "$VERBOSE" != no ] && log_end_msg 1
EXIT=1
;;
esac
;;
status)
status_of_proc -p "$PIDDIR/$INSTANCE.pid" "$NFCAPD" "nfcapd
$INSTANCE instance" || EXIT=$?
;;
restart|force-reload)
log_daemon_msg "Restarting $DESC" "$INSTANCE"
do_stop "$INSTANCE"
case "$?" in
0|1)
do_start "$INSTANCE" "$CONFIG"
case "$?" in
0) log_end_msg 0 ;;
*)
# Old process is still running or
# failed to start
log_end_msg 1 ;;
esac
;;
*)
# Failed to stop
log_end_msg 1
;;
esac
;;
*)
echo "Usage: /etc/init.d/nfdump
{start|stop|status|restart|force-reload} [<instance> ...]" >&2
exit 3
;;
esac
}
ACTION="$1"
shift
if [ "$1" ] ; then
while [ "$1" ] ; do
CONFIG="/etc/nfdump/$1.conf"
if [ -f "$CONFIG" ] ; then
do_action "$CONFIG"
fi
shift
done
else
for CONFIG in /etc/nfdump/*.conf ; do
if [ -f "$CONFIG" ] ; then
do_action "$CONFIG"
fi
done
fi
exit $EXIT
/etc/nfdump/default.conf changed:
options='-w /var/cache/nfdump -S1 -z -D -b 127.0.0.1 -p 2055 -R 127.0.0.2/2055'
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: nfdump
Source-Version: 1.7.1-3
Done: Bernhard Schmidt <[email protected]>
We believe that the bug you reported is fixed in the latest version of
nfdump, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bernhard Schmidt <[email protected]> (supplier of updated nfdump package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 21 Jun 2023 21:29:47 +0200
Source: nfdump
Architecture: source
Version: 1.7.1-3
Distribution: unstable
Urgency: medium
Maintainer: Erik Wenzel <[email protected]>
Changed-By: Bernhard Schmidt <[email protected]>
Closes: 1038644
Changes:
nfdump (1.7.1-3) unstable; urgency=medium
.
* [8554dec3] Fix init script to return success when process has started.
Thanks to Yury Shevchuk
* [c9d7e789] Fix segfault in getopt parsing for -R (Closes: #1038644)
Checksums-Sha1:
d72eef22872079208b551f77c94af2cbea8d5cdd 2013 nfdump_1.7.1-3.dsc
1fb8df64dccc7934578bf698763e583d69bf4c92 11380 nfdump_1.7.1-3.debian.tar.xz
cc576525f6390abf05d97ca0a83906032e31488e 8389 nfdump_1.7.1-3_amd64.buildinfo
Checksums-Sha256:
0dae57bf12f34a26011dc9492ece3a3723eaeb777b31fff6e0376ca3b5874f68 2013
nfdump_1.7.1-3.dsc
300a3dcdd289c3c5992fd06a647339e684d22691abf5c525ca325ba35e77b1a2 11380
nfdump_1.7.1-3.debian.tar.xz
a4127d818ca6ff58e33cb605e858d59ede1a5353e414ba5bc25dd8ccddda2a0e 8389
nfdump_1.7.1-3_amd64.buildinfo
Files:
ee1c5afed9a7e8b98d84a6f0e873003c 2013 net optional nfdump_1.7.1-3.dsc
bfcb848637ea2fa8ab905dcbc68e171c 11380 net optional
nfdump_1.7.1-3.debian.tar.xz
bd150476638626959c5cd645dfbeb379 8389 net optional
nfdump_1.7.1-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEE1uAexRal3873GVbTd1B55bhQvJMFAmSTUD0RHGJlcm5pQGRl
Ymlhbi5vcmcACgkQd1B55bhQvJOhFBAAqTXF+t3NtguLKPbCTDs4BnYmfrC0VZ+V
5YONl0EA5UYMa65v8A1+au+fbvPPc6TlfNUwd4rUKrlVN3yR1T7CW/r9JUMgK/02
TDAZVHSU1VbCsLHVYSZ5Ql0tciB/l5toU28axqThVlLL3G3i63yax7JO/8YAkllc
F5ai3SYsqyaVYvto5MGbdcVPHExSLs3JOCaQDUPvLA/stEb/8POMRclYyKNQXQjb
f9tRglPmTufjoMNP7rWWu1++WrPViSJo6NOilHeD76y4j6wO88i+prGL1XmDkkGi
b3WmT+kuRKYyP/zzteexfTx/n5U5QPMcfj41H7MeeUJkP6iebm4iCJ3dGCRswIWN
outzvIilH775phj8oky9CqWVmEUp14lTCQVCXdQtmBEueyXXMJbt4FT1/Zuwwq5p
c7KzE01w1lNH8GPwUfo79HxSrhA8uEFc0CcBsGOwb46fOrC3SngDuvYUMBPHd/3M
957+LKyw1w2+whqkRdzKwICZzMbgqIH6otyGub85BkdtbMGtZflgl37tWSO6kVsE
bDHTM3plu0mWEmz0hf/KaE2guVo9hZ+jR67ihjvWySRU0q6slalxpnBZEPsCq9FT
YFn7Oebf4DIxQY03Ug93lv317BnIOUlK2OioDBRZC3vveCchIBwfLhP6T7htxJnt
aODfB8bdBDA=
=GJea
-----END PGP SIGNATURE-----
--- End Message ---
