Your message dated Fri, 06 Oct 2023 19:37:02 +0000
with message-id <[email protected]>
and subject line Bug#1053379: fixed in munin 2.0.74-1
has caused the Debian Bug report #1053379,
regarding munin-node: logrotate.d/munin-node should call invoke-rc.d
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1053379: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053379
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: munin-node
Version: 2.0.73-2
Severity: normal
Tags: patch

The recent upgrade to 2.0.73-2 from 2.0.73-1 introduced the following changes.

--- a/logrotate.d/munin-node
+++ b/logrotate.d/munin-node
@@ -3,7 +3,11 @@
        missingok
        rotate 7
        compress
-       copytruncate
+       nocopytruncate
+       delaycompress
        notifempty
        create 640 root root
+       postrotate
+               systemctl restart munin-node
+       endscript
 }

The introduction of systemctl is problematic especially when used in
chroots.  It avoids the policy-rc.d layer.  Please see this reference
for details.

    
https://www.debian.org/doc/debian-policy/ch-opersys.html#running-init-scripts

Please use invoke-rc.d like other logrotate.d files do.  Here is a
patch.  I note that TABs were used and that those will probably not be
preserved and will need to be manually handled as desired.

--- a/logrotate.d/munin-node
+++ b/logrotate.d/munin-node
@@ -8,6 +8,6 @@
        notifempty
        create 640 root root
        postrotate
-               systemctl restart munin-node
+               invoke-rc.d munin-node restart > /dev/null
        endscript
 }

Thank you for maintaining munin-node in Debian.

Bob


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

--- End Message ---
--- Begin Message ---
Source: munin
Source-Version: 2.0.74-1
Done: Holger Levsen <[email protected]>

We believe that the bug you reported is fixed in the latest version of
munin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Levsen <[email protected]> (supplier of updated munin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 06 Oct 2023 21:13:45 +0200
Source: munin
Architecture: source
Version: 2.0.74-1
Distribution: unstable
Urgency: medium
Maintainer: Munin Debian Maintainers <[email protected]>
Changed-By: Holger Levsen <[email protected]>
Closes: 1033734 1053379
Changes:
 munin (2.0.74-1) unstable; urgency=medium
 .
   * New upstream bugfix release. Closes: #1033734.
   * munin-node.logrotate:
     - use invoke-rc.d instead of systemctl, thanks to Bob Proulx.
       Closes: #1053379
     - use invoke-rc.d try-restart instead of restart, thanks to Ansgar.
Checksums-Sha1:
 557f7ce4db9eaede5a598233019df6cf52b2e5da 3139 munin_2.0.74-1.dsc
 e59c0cd02ed56dd2a17c972517209f9312aa4a98 2252899 munin_2.0.74.orig.tar.gz
 a673bf36ea24f73e9df22b2907eafb9a29b3c8fe 833 munin_2.0.74.orig.tar.gz.asc
 144b474f3dfaf36242a25037339d9718b472f9e0 66540 munin_2.0.74-1.debian.tar.xz
 a97fa2e47345f12657c9c8f93cd090d4d081b2b3 5980 munin_2.0.74-1_source.buildinfo
Checksums-Sha256:
 0ff22a29aabf19bce47b305768a6f31d82bf13be78a7ba7b9d65c52f961005fd 3139 
munin_2.0.74-1.dsc
 c517e18720eeb90ec23fd886ccc0954576075ece7beb2d07c9de9461546acfa4 2252899 
munin_2.0.74.orig.tar.gz
 86782cebb6fd154564e7b073ccfd446646795e0c263f9bff205cdc922a8b19a2 833 
munin_2.0.74.orig.tar.gz.asc
 2b3d938d404e351098ca2c2358385f53a6e5c3a8471e8977200150eef9be7c5b 66540 
munin_2.0.74-1.debian.tar.xz
 2b9f27d9a737b595704598743faeff3c4f3e0a03f1d98dbe2c36885d400f29f5 5980 
munin_2.0.74-1_source.buildinfo
Files:
 bb72001ee5bc98ac8ca0d722549f13eb 3139 net optional munin_2.0.74-1.dsc
 f3b52f54766f733c0d8385e4017cf31f 2252899 net optional munin_2.0.74.orig.tar.gz
 d0a4482461d64ce70129a683ca18b57b 833 net optional munin_2.0.74.orig.tar.gz.asc
 8979fae1d8c9f3f6b3fa426487412b1d 66540 net optional 
munin_2.0.74-1.debian.tar.xz
 c343df6e80255ba977311956ccfb8850 5980 net optional 
munin_2.0.74-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEuL9UE3sJ01zwJv6dCRq4VgaaqhwFAmUgX7sACgkQCRq4Vgaa
qhx+pg/8CPPKe1Rizrv+Iu7mbWY0pd1tEVqHOKhrjDYNAnub2muOJHW3TfrPWues
s0Dl4Xbs2z8C0U3JjZ60tvsj1PlYMoWf74ouka9M+hPxotgANZnJPcON/xmP2dls
HOH/Ks/B5TrXMKuAT8rro08H6zrUsfF7SatL4M60Mns3ZhBiRDNaoWI7G6DQnFGl
zHUP6lBjMESgtDPOc60Zpllu7MqfXB7BJKwbb8rL1jmA0whtvLfGMJh6zLMTLUHJ
6y+KymK7bBL2WFZvNaGjB4YtKmP9mxVJNIRke5z/+eo4Rw9yID9fMmjjlR66xg0b
GevCIYCco742WeBqxHryVruHuPdJhVKoQpvdYjcBKqcryf6uwhayWwi9Nuu8mGzC
wGrbq7afOA51Im57+U9f+Yhdw2UL4JLqbKGxOfzL9Kjv2NF41GezObaxDuno30WN
RGHmRS1/KhIgAXJROzSXRwG+gXYCAyriX916Lp7g33WCWGLqbAP4om6qQhYECW2Y
GJ9yj24x0kiHSBjRB6+4K93BN9ALYAAnwDUhuj6OeSolYjzby7zpAhJWeKAE6hE4
OEgQif8mqJ1a4AcUC8gRRhF3NNVqCdlGE1TFF2Rn8O5ZP31P7KktRuxKfjmaS+Mi
VYeU42a2ZYhdVoa3fyYsBKSBAYd0FvJsiTbvCRW1kHCEQTMX2fw=
=IC2o
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to