Your message dated Thu, 29 Jun 2006 14:17:20 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#374329: fixed in xmoto 0.1.16-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: xmoto
Version: 0.1.16-2
Severity: normal
Hi,
Since xmoto 0.1.16, only 1400x1050 is available in the video configuration. It
looks
like my video driver only returns this mode (which is my actual resolution).
But, I am running in windowed mode, so I think xmoto should not rely on the mode
list returned by SDL but propose a hardcoded list instead.
The following patch adds a "windowed" argument to getDisplayModes so that all
"regular" modes are returned when running windowed.
Thanks,
Brice
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1,
'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17=shepherd
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Versions of packages xmoto depends on:
ii libc6 2.3.6-13 GNU C Library: Shared libraries
ii libcurl3 7.15.4-1 Multi-protocol file transfer libra
ii libgcc1 1:4.1.0-4 GCC support library
ii libgl1-mesa-glx [li 6.5.0.cvs.20060524-1 A free implementation of the OpenG
ii libjpeg62 6b-13 The Independent JPEG Group's JPEG
ii liblua50 5.0.2-6 Main interpreter library for the L
ii liblualib50 5.0.2-6 Extension library for the Lua 5.0
ii libode0c2 1:0.5-5 Open Dynamics Engine - runtime lib
ii libpng12-0 1.2.8rel-5.1 PNG library - runtime
ii libsdl-mixer1.2 1.2.6-1.1+b1 mixer library for Simple DirectMed
ii libsdl1.2debian 1.2.10-3 Simple DirectMedia Layer
ii libstdc++6 4.1.0-4 The GNU Standard C++ Library v3
ii xmoto-data 0.1.16-2 2D motocross platform game
ii zlib1g 1:1.2.3-11 compression library - runtime
xmoto recommends no packages.
-- no debconf information
Index: src/GameMenus.cpp
===================================================================
--- src.orig/GameMenus.cpp 2006-06-18 11:55:51.000000000 -0400
+++ src/GameMenus.cpp 2006-06-18 11:57:26.000000000 -0400
@@ -406,7 +406,7 @@
pDispResList->setFont(m_Renderer.getSmallFont());
pDispResList->addColumn(GAMETEXT_SCREENRES,pDispResList->getPosition().nWidth);
- std::vector<std::string>* modes = getDisplayModes();
+ std::vector<std::string>* modes = getDisplayModes(m_Config.getBool("DisplayWindowed"));
for(int i=0; i < modes->size(); i++) {
pDispResList->addEntry((*modes)[i].c_str());
Index: src/VApp.cpp
===================================================================
--- src.orig/VApp.cpp 2006-06-18 11:53:44.000000000 -0400
+++ src/VApp.cpp 2006-06-18 11:55:25.000000000 -0400
@@ -518,17 +518,21 @@
/*===========================================================================
Return available display modes
===========================================================================*/
- std::vector<std::string>* App::getDisplayModes(){
+ std::vector<std::string>* App::getDisplayModes(int windowed){
std::vector<std::string>* modes = new std::vector<std::string>;
SDL_Rect **sdl_modes;
int i, nFlags;
- /* Always use the fullscreen flags to be sure to
- always get a result (no any modes available like in windowed) */
- nFlags = SDL_OPENGL | SDL_FULLSCREEN;
+ if (windowed) {
+ sdl_modes = (SDL_Rect **)-1;
+ } else {
+ /* Always use the fullscreen flags to be sure to
+ always get a result (no any modes available like in windowed) */
+ nFlags = SDL_OPENGL | SDL_FULLSCREEN;
- /* Get available fullscreen/hardware modes */
- sdl_modes = SDL_ListModes(NULL, nFlags);
+ /* Get available fullscreen/hardware modes */
+ sdl_modes = SDL_ListModes(NULL, nFlags);
+ }
/* Check is there are any modes available */
if(sdl_modes == (SDL_Rect **)0){
@@ -538,7 +542,7 @@
/* Check if or resolution is restricted */
if(sdl_modes == (SDL_Rect **)-1){
- /* Should never happen */
+ /* Should never happen, except in windowed mode */
//Log("All resolutions available.");
modes->push_back("800 X 600");
modes->push_back("1024 X 768");
Index: src/VApp.h
===================================================================
--- src.orig/VApp.h 2006-06-18 11:53:29.000000000 -0400
+++ src/VApp.h 2006-06-18 11:53:42.000000000 -0400
@@ -133,7 +133,7 @@
int getDispHeight(void) {return m_nDispHeight;}
//#endif
- std::vector<std::string>* getDisplayModes();
+ std::vector<std::string>* getDisplayModes(int windowed);
void setFrameDelay(int nDelay) {m_nFrameDelay=nDelay;}
--- End Message ---
--- Begin Message ---
Source: xmoto
Source-Version: 0.1.16-2
We believe that the bug you reported is fixed in the latest version of
xmoto, which is due to be installed in the Debian FTP archive:
xmoto-data_0.1.16-2_all.deb
to pool/main/x/xmoto/xmoto-data_0.1.16-2_all.deb
xmoto_0.1.16-2.diff.gz
to pool/main/x/xmoto/xmoto_0.1.16-2.diff.gz
xmoto_0.1.16-2.dsc
to pool/main/x/xmoto/xmoto_0.1.16-2.dsc
xmoto_0.1.16-2_i386.deb
to pool/main/x/xmoto/xmoto_0.1.16-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Samuel Mimram <[EMAIL PROTECTED]> (supplier of updated xmoto package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 15 Jun 2006 23:58:12 +0000
Source: xmoto
Binary: xmoto-data xmoto
Architecture: source i386 all
Version: 0.1.16-2
Distribution: unstable
Urgency: low
Maintainer: Samuel Mimram <[EMAIL PROTECTED]>
Changed-By: Samuel Mimram <[EMAIL PROTECTED]>
Description:
xmoto - 2D motocross platform game
xmoto-data - 2D motocross platform game
Closes: 374329
Changes:
xmoto (0.1.16-2) unstable; urgency=low
.
* Added use_regular_modes_for_non_windowed.dpatch to show all video modes
when running in a window (thanks Brice Goglin), closes: #374329.
Files:
2f04df96c98c7e689a8ba1b74b46f63b 758 games optional xmoto_0.1.16-2.dsc
66bd72e840b3385b4fa118432ff9e38f 10722 games optional xmoto_0.1.16-2.diff.gz
bcc1263e8b2cebdd8ed9600cc79361c7 2854424 games optional
xmoto-data_0.1.16-2_all.deb
570b4f0e5b25fa417ccd3d5a0954eade 584128 games optional xmoto_0.1.16-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
iD8DBQFEpEE1Iae1O4AJae8RAjs8AJ9GCKUPR6nQcV6WJv4e3Cf6BnO7FQCfR1DM
10alSBt7T9vtpKR2LupeXc8=
=HA+S
-----END PGP SIGNATURE-----
--- End Message ---
