Your message dated Thu, 19 Oct 2023 21:05:22 +0000
with message-id <[email protected]>
and subject line Bug#1052398: fixed in gem2deb 2.2
has caused the Debian Bug report #1052398,
regarding Use of deprecated File.exists? and Dir.exists? in gem2deb
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1052398: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052398
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gem2deb
Version: 2.1
The packaged Ruby code uses calls to the deprecated `File.exists?` and
`Dir.exists?` methods which need to be replaced with their `.exist?`
equivalents for compatibility with newer Ruby versions. The calls to
`File.exists?` are also using the rather weird `::` syntax. A patch
against current master building and speccing cleanly against Ruby 3.2 is
attached.
Best regards,
Nicos Gollan
From ee3c77847b4586c56a301bfda0a582b26ae7919d Mon Sep 17 00:00:00 2001
From: Nicos Gollan <[email protected]>
Date: Thu, 21 Sep 2023 13:54:48 +0200
Subject: [PATCH] Fix calls to deprecated `.exists?`methods
---
lib/gem2deb/gem_installer.rb | 2 +-
lib/gem2deb/installer.rb | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/gem2deb/gem_installer.rb b/lib/gem2deb/gem_installer.rb
index ecca3f1..a9924de 100644
--- a/lib/gem2deb/gem_installer.rb
+++ b/lib/gem2deb/gem_installer.rb
@@ -158,7 +158,7 @@ module Gem2Deb
end
# remove empty plugins/ directory
- if Dir.exists?('plugins') && Dir.empty?('plugins')
+ if Dir.exist?('plugins') && Dir.empty?('plugins')
FileUtils::Verbose.rmdir('plugins')
end
diff --git a/lib/gem2deb/installer.rb b/lib/gem2deb/installer.rb
index 3da81d7..48b8931 100644
--- a/lib/gem2deb/installer.rb
+++ b/lib/gem2deb/installer.rb
@@ -60,7 +60,7 @@ module Gem2Deb
# This is a hack to workaround a problem in rubygems
vendor_dir = destdir(:libdir)
vendor_arch_dir = destdir(:archdir, rubyver)
- if File::exists?(vendor_dir) and File::exists?(vendor_arch_dir)
+ if File.exist?(vendor_dir) and File.exist?(vendor_arch_dir)
remove_duplicate_files(vendor_dir, vendor_arch_dir)
end
end
--
2.34.1
--- End Message ---
--- Begin Message ---
Source: gem2deb
Source-Version: 2.2
Done: Antonio Terceiro <[email protected]>
We believe that the bug you reported is fixed in the latest version of
gem2deb, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Antonio Terceiro <[email protected]> (supplier of updated gem2deb package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 19 Oct 2023 17:34:35 -0300
Source: gem2deb
Architecture: source
Version: 2.2
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Team
<[email protected]>
Changed-By: Antonio Terceiro <[email protected]>
Closes: 973516 1052398
Changes:
gem2deb (2.2) unstable; urgency=medium
.
[ Antonio Terceiro ]
* Gem2Deb::YAML: make code backwards compatible with Ruby 2.7
* Gem2Deb::Source: ensure instance variable is initialized
* Gem2Deb::TestRunner: allow calling run() more than once
* Gem2Deb::TestRunner: run all possible checks.
Instead of stopping at the first check that fails, run all of them until
the end, and only then exit with the appropriate exit status.
* gem2deb-test-runner: add shared smoke test for Rails assets packages
* Gem2Deb::PackageNameMapping: add missing requires
* Remove assignments to Encoding.default_external
* Gem2Deb::PackageNameMapping: add missing require statement
* Gem2Deb::PackageNameMapping: look for gemspecs in all relevant directories.
Only looking for gemspecs under /usr/share/rubygems-integration/ would
make it miss architecture-dependent gems which are installed to
/usr/lib/${arch}/rubygems-integration/.
.
[ Lucas Kanashiro ]
* dh_make_ruby: install doc/*, README* and CONTRIBUTORS* (Closes: #973516)
* test_runner: do not load rake tasks from rakelib directory
.
[ Nicos Gollan ]
* Fix calls to deprecated `.exists?`methods (Closes: #1052398)
Checksums-Sha1:
26e3224b14efd8ebc8f3c6304ac0b306d74f2939 2309 gem2deb_2.2.dsc
941866c4a261ce9c4903b092260b9c08b4d851cb 79840 gem2deb_2.2.tar.xz
5ca460163b1a4c3df4caf9b2af7a496e36c16e9e 13095 gem2deb_2.2_source.buildinfo
Checksums-Sha256:
26c6c2c4e3f275290ae311610e291561f48868b13ec7596a4d7f4f3714429e4f 2309
gem2deb_2.2.dsc
df07a97a97d4c1f69722f75616839ab1c49a51b7c91c3a2c515e00a578fc11ce 79840
gem2deb_2.2.tar.xz
4921b380e79d52a29c95f17cdf7d6f5f1f79a03916b42fb0bab00e54b6f2f250 13095
gem2deb_2.2_source.buildinfo
Files:
a5b5cb7bad19ca345892aa465597b017 2309 ruby optional gem2deb_2.2.dsc
06b7366ac4c5cfbd476ac354743a6ea8 79840 ruby optional gem2deb_2.2.tar.xz
f0b6aa8d8a284c3079b7d4a4f78b7ce1 13095 ruby optional
gem2deb_2.2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEst7mYDbECCn80PEM/A2xu81GC94FAmUxl08ACgkQ/A2xu81G
C96daQ/+MddPULb0ByqNWiFgsIhl//743BGM66qoerTkxww3bODbb3+Rk64qyrUa
3P2cM1mPSU7Qhjn1QsGh0k6ByAEskyZV0hHsiEEN6ceqAn+OlLWe6bP3AeJRHZFy
AZR2RFDn3YpNZ8mCmr41Yto9LuJEItDAg6t8VeceqbxdzVfG1/1uKXqnXkPw3bGR
M7z7vPBNm4Tzx0vMDnr+k6UQMUBjGOMayjXWQQKIHJgeHZ5+DMJvmkGLu8D3DLJO
oydYcctsp3Pk4m+jlQFBravD7x60NZtpgHEbigKMLjyWWnVq9tnnz93pHM4eoolo
aTqujSFjlCs/SzTt/8UVTpahMGGsoiUz4+kA+x5xZsLGWbtglISGakDifw9OsAkG
krDQWf5xOsn+pvixRKU+lHER29w+nW95tH/yTvaDs42H17D2txhLA7oPrqWXK3Iq
gyZ1urDe4V908PaxQJmGFKL3Iqs4sMjvJ6IL5j8spyejl1kr1BJavfWF/Oe8ynAm
8+5dSkCQicEn7YlZMNVXwwAuXD16i1+T7WGDU+8Dl3AnwJfkB1mlPzPoVQ3U79iG
m8HHkFLj1+e/Xt4KH0N5HgW6dYBS83jAmeCLloXckkkEChbAJp3LVIGJZzR+7lUL
ol4/cKO5ncMgkzmRY/T7DQAsHaoN9OZ/EmBPLVT24ikttPAU1wg=
=Jcpp
-----END PGP SIGNATURE-----
--- End Message ---
