Your message dated Fri, 20 Oct 2023 09:35:35 +0000 with message-id <[email protected]> and subject line Bug#1051570: fixed in mlt 7.20.0-1 has caused the Debian Bug report #1051570, regarding mlt: FTBFS with RtAudio 6 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 1051570: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051570 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: mlt Version: 7.18.0-2 Severity: serious Tags: ftbfs patch Justification: fails to build from source (but built successfully in the past) Dear Maintainer, mlt ftbfs with RtAudio 6 (currently in experimental). ``` [ 89%] Building CXX object src/modules/rtaudio/CMakeFiles/mltrtaudio.dir/consumer_rtaudio.cpp.o cd /build/mlt-zme0kO/mlt-7.18.0/obj-x86_64-linux-gnu/src/modules/rtaudio && /usr/lib/ccache/c++ -Dmltrtaudio_EXPORTS -I/build/mlt-zme0kO/mlt-7.18.0/src/framework/.. -isystem /usr/include/rtaudio -g -O2 -ffile-prefix-map=/build/mlt-zme0kO/mlt-7.18.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++14 -fPIC -mmmx -msse -msse2 -pthread -D__LINUX_ALSA__ -D__LINUX_PULSE__ -D__UNIX_JACK__ -D_REENTRANT -MD -MT src/modules/rtaudio/CMakeFiles/mltrtaudio.dir/consumer_rtaudio.cpp.o -MF CMakeFiles/mltrtaudio.dir/consumer_rtaudio.cpp.o.d -o CMakeFiles/mltrtaudio.dir/consumer_rtaudio.cpp.o -c /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp: In member function ‘bool RtAudioConsumer::create_rtaudio(RtAudio::Api, int, int)’: /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp:164:26: error: ‘struct RtAudio::DeviceInfo’ has no member named ‘probed’ 164 | if (info.probed && info.name == resource) { | ^~~~~~ /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp:212:16: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’? 212 | catch (RtAudioError &e) { | ^~~~~~~~~~~~ | RtAudioErrorType In file included from /build/mlt-zme0kO/mlt-7.18.0/src/framework/../framework/mlt.h:50, from /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp:20: /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp:214:49: error: ‘e’ was not declared in this scope 214 | mlt_log_info(getConsumer(), "%s\n", e.getMessage().c_str()); | ^ /build/mlt-zme0kO/mlt-7.18.0/src/framework/../framework/mlt_log.h:88:93: note: in definition of macro ‘mlt_log_info’ 88 | #define mlt_log_info(service, format, args...) mlt_log((service), MLT_LOG_INFO, (format), ##args) | ^~~~ /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp: In member function ‘int RtAudioConsumer::stop()’: /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp:365:24: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’? 365 | catch (RtAudioError &e) { | ^~~~~~~~~~~~ | RtAudioErrorType /build/mlt-zme0kO/mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp:367:58: error: ‘e’ was not declared in this scope 367 | mlt_log_error(getConsumer(), "%s\n", e.getMessage().c_str()); | ^ /build/mlt-zme0kO/mlt-7.18.0/src/framework/../framework/mlt_log.h:85:95: note: in definition of macro ‘mlt_log_error’ 85 | #define mlt_log_error(service, format, args...) mlt_log((service), MLT_LOG_ERROR, (format), ##args) | ^~~~ make[2]: *** [src/modules/rtaudio/CMakeFiles/mltrtaudio.dir/build.make:79: src/modules/rtaudio/CMakeFiles/mltrtaudio.dir/consumer_rtaudio.cpp.o] Error 1 make[2]: Target 'src/modules/rtaudio/CMakeFiles/mltrtaudio.dir/build' not remade because of errors. make[2]: Leaving directory '/build/mlt-zme0kO/mlt-7.18.0/obj-x86_64-linux-gnu' ``` Attached is a patch that fixes the FTBFS (but is otherwise untested). No debdiff this time, sorry. cheers.Description: Fix FTBFS with RtAudio 6 replace try/catch with check for return codes. check device.ID instead of device.probed Author: IOhannes m zmölnig Origin: Debian Forwarded: no Last-Update: 2023-09-09 --- This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ Index: mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp =================================================================== --- mlt-7.18.0.orig/src/modules/rtaudio/consumer_rtaudio.cpp +++ mlt-7.18.0/src/modules/rtaudio/consumer_rtaudio.cpp @@ -161,7 +161,7 @@ public: for (i = 0; i < n; i++) { info = rt->getDeviceInfo(i); mlt_log_verbose(NULL, "RtAudio device %d = %s\n", i, info.name.c_str()); - if (info.probed && info.name == resource) { + if (info.ID > 0 && info.name == resource) { device_id = i; break; } @@ -192,11 +192,11 @@ public: } } - try { if (rt->isStreamOpen()) { rt->closeStream(); } - rt->openStream(¶meters, + RtAudioErrorType err; + err = rt->openStream(¶meters, NULL, RTAUDIO_SINT16, frequency, @@ -204,14 +204,10 @@ public: &rtaudio_callback, this, &options); - rt->startStream(); - } -#ifdef RTERROR_H - catch (RtError &e) { -#else - catch (RtAudioError &e) { -#endif - mlt_log_info(getConsumer(), "%s\n", e.getMessage().c_str()); + if(!err) + err = rt->startStream(); + if (err) { + mlt_log_info(getConsumer(), "%s\n", rt->getErrorText().c_str()); delete rt; rt = NULL; return false; @@ -355,16 +351,9 @@ public: pthread_mutex_unlock(&audio_mutex); if (rt && rt->isStreamOpen()) - try { // Stop the stream - rt->stopStream(); - } -#ifdef RTERROR_H - catch (RtError &e) { -#else - catch (RtAudioError &e) { -#endif - mlt_log_error(getConsumer(), "%s\n", e.getMessage().c_str()); + if(rt->stopStream()) { + mlt_log_error(getConsumer(), "%s\n", rt->getErrorText().c_str()); } delete rt; rt = NULL;
--- End Message ---
--- Begin Message ---Source: mlt Source-Version: 7.20.0-1 Done: Patrick Matthäi <[email protected]> We believe that the bug you reported is fixed in the latest version of mlt, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Patrick Matthäi <[email protected]> (supplier of updated mlt package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 20 Oct 2023 10:14:41 +0200 Source: mlt Architecture: source Version: 7.20.0-1 Distribution: unstable Urgency: high Maintainer: Patrick Matthäi <[email protected]> Changed-By: Patrick Matthäi <[email protected]> Closes: 1051570 Changes: mlt (7.20.0-1) unstable; urgency=high . * New upstream release. * Add patch to fix a FTBFS with RTAudio version 6. Closes: #1051570 Checksums-Sha1: 0db48717260a9081695a0bfe518cc87c2a9563e2 2540 mlt_7.20.0-1.dsc e19e0076b5f75b6d1a5baa58dbf3d5a6e90596bb 1636493 mlt_7.20.0.orig.tar.gz 4784d054fcfb8e9bff069ae9e6aae8bf1f607125 104876 mlt_7.20.0-1.debian.tar.xz 00c6f6af1add5917a23a858ff0f81559185f2ceb 13147 mlt_7.20.0-1_source.buildinfo Checksums-Sha256: 0a2e2b1ea4868d423629b8e05d502c65f66a2f26b1ccc05db02838e7c9a22e88 2540 mlt_7.20.0-1.dsc 7472372b31f76b2eb0ac66c756391be7cb859a3a779c97ccb7dcf7086ac9d816 1636493 mlt_7.20.0.orig.tar.gz fe02a6fce70e777912ab51fd98dd5a2a18aff0a80b11ac71189fb7ce39bfa203 104876 mlt_7.20.0-1.debian.tar.xz 7fded0abc135e8404a1ea279e7b8f9b1619a6625f7fbc118cc6b8952ff534ed9 13147 mlt_7.20.0-1_source.buildinfo Files: df826fad0922d41b491bfc2465f429f4 2540 libs optional mlt_7.20.0-1.dsc 8a5dac939d7251aa1f99eee3ce29b198 1636493 libs optional mlt_7.20.0.orig.tar.gz e8f2f252f31adc03cc5c93caf9289749 104876 libs optional mlt_7.20.0-1.debian.tar.xz ec1d46adac50647cc4fca9548179fa69 13147 libs optional mlt_7.20.0-1_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEWKA9xYJCWk3IuQ4TEtmwSpDL2OQFAmUyQqQACgkQEtmwSpDL 2OTB6Q//W3ymm5Kk/vpP/ZMz59HRjX4KKHTJmEdPA0lVFEmBszGtxpAgXnPN7+CZ 3QXFKpq8Ojb6ptqO7zOM9Sr4Sk70Px/lPrf5qIbZ0EhjD2P7ojkajTkdaY0iItTV VSIOb7Yar4wV9GWfs4VfcmRYwa+PGuYYdxkjU+J1qIL6QV9RvRhmAJEkwwLKii5K iYZOeLvQkE13coYrYGNLLNEcBiT2N3QggzeKBwJb7maAZ6ksLo3iNuWidufQwlVB xXc1VcCRMT3ZEVmqOfZYmxIAuF3hB+2FdA1hL1VHwXU697cMaLDnOb+24h7J/V/Z IBJz82Mdhne27XjKhKuf+gj/enzdFsbT9JtyqRV+RR1Fq6vBbmnKl6a10h99TCkW 7xZqgnXrrz70gQmdl62/ShvWRmTaRPkpmVaT0PukL2Vr4f7ti/6Dw+Bp8rXcDSRh psm7cSBsIDY0mi/x1c4tuCo1HLrUj7ZldX8leYLaJLvCXpB/84m1Ms7QCYBrMLKq GGyiNtxK5KFhsw4penFtBhusYB90bQ9uru0zF8yQIGS/HsQ50dDY2U01tmJ7F15s +jXvg6GUTVjoWkGBFok8M6iQupUTTVImd8bByDVkA1IuCCQCAIPoUkvjncKeSsBH lJNAX/ZE9zID8/2zVU4g/Kp6wIi4LJ0Id4lhYNNbmFeGtBftlxg= =uuh9 -----END PGP SIGNATURE-----
--- End Message ---
