Your message dated Tue, 24 Oct 2023 18:07:14 +0000
with message-id <[email protected]>
and subject line Bug#1021853: fixed in sysprof 45.1-1
has caused the Debian Bug report #1021853,
regarding sysprof: FTBFS on hppa - mmap aliasing issue
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1021853: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021853
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: sysprof
Version: 3.46.0-2
Severity: normal
Tags: ftbfs patch
Dear Maintainer,
The test test-mapped-ring-buffer fails on hppa:
==================================== 2/4 =====================================
test: test-mapped-ring-buffer
start time: 14:55:16
duration: 0.40s
result: killed by signal 6 SIGABRT
command: GSETTINGS_BACKEND=memory G_DEBUG=gc-friendly MALLOC_PERTURB_=142
NO_AT_BRIDGE=1 MALLOC_CHECK_=2 G_TEST_SRCDIR=/<<PKGBUILDDIR>>/src/tests
G_TEST_BUILDDIR=/<<PKGBUILDDIR>>/obj-hppa-linux-gnu/src/tests
/<<PKGBUILDDIR>>/obj-hppa-linux-gnu/src/tests/test-mapped-ring-buffer
----------------------------------- stdout -----------------------------------
# random seed: R02Sb35445e48e2cfa93f89f3c5793901662
1..3
# Start of MappedRingBuffer tests
Bail out! ERROR:../src/tests/test-mapped-ring-buffer.c:43:test_basic_movements:
'reader' should not be NULL
----------------------------------- stderr -----------------------------------
**
ERROR:../src/tests/test-mapped-ring-buffer.c:43:test_basic_movements: 'reader'
should not be NULL
==============================================================================
Full build log is here:
https://buildd.debian.org/status/fetch.php?pkg=sysprof&arch=hppa&ver=3.46.0-3&stamp=1665759904&raw=0
In map_head_and_body_twice(), the second mmap call fails:
mmap2(NULL, 135168, PROT_READ|PROT_WRITE, MAP_SHARED, 3, 0) = 0xf64a2000
mmap2(0xf64b3000, 65536, PROT_READ|PROT_WRITE, MAP_SHARED|MAP_FIXED, 3, 0x1000)
= -1 EINVAL (Invalid argument)
Due to cache issues, all shared mapping of a page must be equivalently
mapped. This requires page mappings to be at the same virtual address
modulo 4 MB. Due to a kernel limitation, all mappings to a file must
be equivalent.
The test can be fixed by rounding the buffer_size used in the mapped
ring buffer to 4 MB on hppa. This makes the two mmap mappings equivalent.
Please send the fix upstream and install if okay.
Regards,
Dave Anglin
-- System Information:
Debian Release: bookworm/sid
APT prefers buildd-unstable
APT policy: (500, 'buildd-unstable'), (500, 'unstable')
Architecture: hppa (parisc64)
Kernel: Linux 5.19.15+ (SMP w/4 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
Index: sysprof-3.46.0/src/libsysprof-capture/mapped-ring-buffer.c
===================================================================
--- sysprof-3.46.0.orig/src/libsysprof-capture/mapped-ring-buffer.c
+++ sysprof-3.46.0/src/libsysprof-capture/mapped-ring-buffer.c
@@ -35,6 +35,7 @@
#define DEFAULT_N_PAGES 32
#define BUFFER_MAX_SIZE ((UINT32_MAX/2)-_sysprof_getpagesize())
+#define SHM_COLOUR 0x00400000
enum {
MODE_READER = 1,
@@ -172,9 +173,16 @@ mapped_ring_buffer_new_reader (size_t bu
page_size = _sysprof_getpagesize ();
- /* Add 1 page for coordination header */
if (buffer_size == 0)
buffer_size = page_size * DEFAULT_N_PAGES;
+
+#ifdef __hppa__
+ /* Round buffer_size up to the shared memory colour boundary */
+ buffer_size += SHM_COLOUR - 1;
+ buffer_size &= ~(SHM_COLOUR - 1);
+#endif
+
+ /* Add 1 page for coordination header */
buffer_size += page_size;
/* Create our memfd (or tmpfs) for writing */
--- End Message ---
--- Begin Message ---
Source: sysprof
Source-Version: 45.1-1
Done: Jeremy Bícha <[email protected]>
We believe that the bug you reported is fixed in the latest version of
sysprof, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jeremy Bícha <[email protected]> (supplier of updated sysprof package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 24 Oct 2023 13:40:54 -0400
Source: sysprof
Built-For-Profiles: noudeb
Architecture: source
Version: 45.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian GNOME Maintainers
<[email protected]>
Changed-By: Jeremy Bícha <[email protected]>
Closes: 1021853
Changes:
sysprof (45.1-1) unstable; urgency=medium
.
* New upstream release
* Extend dh_auto_test timeout (Closes: #1021853)
Checksums-Sha1:
61406406607bdbf7caa81fcca69b9e6f5d335efe 2795 sysprof_45.1-1.dsc
a7ded305f0b39b16be487a9c81ec3601d131abcb 1152148 sysprof_45.1.orig.tar.xz
a0a2329b034e9d9d06baad1cd58c2a533aec8d9b 13848 sysprof_45.1-1.debian.tar.xz
292059385c2d4ce7b485eb8b504b6b839ab8ad3a 18209 sysprof_45.1-1_source.buildinfo
Checksums-Sha256:
f0a09f76076b3c8a759a036a97f05ab718443c5581e2e7a60ea022bde728bc49 2795
sysprof_45.1-1.dsc
323bb9d585613d60c439460331450011f2b90b3d5272625bd858da4c19df2cf9 1152148
sysprof_45.1.orig.tar.xz
e64aede14f2c57d333a218a3cc4754be3ce90900fc2bdd8eccdf711a327e15b7 13848
sysprof_45.1-1.debian.tar.xz
b72b27a39c8994e44c0c45ec796068611fe74fc19edc49b2a2f4bb171ca185f8 18209
sysprof_45.1-1_source.buildinfo
Files:
da3ecaf40bef9a875f7e69947b802aa5 2795 devel optional sysprof_45.1-1.dsc
a06ccd30d1937948964d677430f529cc 1152148 devel optional
sysprof_45.1.orig.tar.xz
a845ddb31485420346a82986e1725293 13848 devel optional
sysprof_45.1-1.debian.tar.xz
0600875d45e1aece0c7b74659cef4a17 18209 devel optional
sysprof_45.1-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEETQvhLw5HdtiqzpaW5mx3Wuv+bH0FAmU4AdMACgkQ5mx3Wuv+
bH3iQQ/9GZYD5BOmIPtuWx8C05+LPun5erWH3uXArrCNcw/I5G3UV81KJchLeGcm
3tDj2+Db7Ed6sR4GHatis3mXyypjgaQ50GAHdhGnsetwF7Z0Bac0NOhSi8valgIY
N49bhPMMc2qXBReOw3zQDGeN0xIYYZX2iiVL5z+EFyhiIU7bpgb1sT734q4njdLo
KRjE9DX6ZL3o+oQ9aKd4gMEbI75EO98S05YnO3EfKUIj2iyFAihKyaEGxE2w05o3
hCn14FmieIFCbtjqt+ThhHWKLRLOXkGa367qCFo6UxspXRh3lihRIaoebBzOZMUP
m3lDvRAd9X23Jll0lfHbkcqYJ6g/IAmicl/fakj4dVfNMW2EwKKV8w5BoGq2brZm
58373kTUW7iPDdCrNl6nZi03A/Hi3wHzz1JaS9K/nBYOyw0V6vDcR7OG18f/mksr
ln4DuO6zh7PG6bgMbWA0AVqbr/iWnRozHqlW3ipZRZpVQHZukOXaWpEIBI2FRF5O
Lfyo3QAQDp64i4zEZWySj0wlWv6Gt/yUzHBhVVi/PHL99bdp30KCWCiAttHtxthX
YcC1ZcASYYPQvS26uEczU/0rl9anh9uJ0WXtWuhlYYodx0GAjYitrTKiSssriSd4
1+kEEJTmX05He0OtRK0cD3cVtayAWupagV+rJfLrnDZb/f8wGuU=
=8dlD
-----END PGP SIGNATURE-----
--- End Message ---
