Your message dated Mon, 30 Oct 2023 07:04:00 +0000
with message-id <e1qxmjc-007vjv...@fasolo.debian.org>
and subject line Bug#1028347: fixed in dh-exec 0.28
has caused the Debian Bug report #1028347,
regarding dh-exec: dh-exec-install-rename does not look in debian/tmp for files 
to move
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1028347: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028347
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dh-exec
Version: 0.27
Severity: important

Looking for solutions to bug #1028202 (install the ncurses-base terminfo
files into /usr/share/terminfo), the dh-exec documentation seemed
promising to me, according to its README.md

,----
| Additionally, assuming we have two binary packages: `foo-gtk` and `foo-utils`,
| and we want to include `/usr/bin/foo-gtk` in the former package, the rest of
| `/usr/bin` in the latter. Our install files would look like these, for 
`foo-gtk`
| and `foo-utils` respectively:
|
|     #! /usr/bin/dh-exec
|     => /usr/bin/foo-gtk
|
|     #! /usr/bin/dh-exec
|     /usr/bin/*
`----

as well as the dh-exec-install manpage:

,----
| The second extension follows a simpler syntax: any filename
| prefixed with "=>" will be moved instead of copied to the package.
| This allows one to move a file out of a directory to a package,
| and install the rest of the files in the same dir into another
| package.
`----

So I figured out I would use these ncurses-{base,term}.install files:

,----ncurses-base.install----
| #! /usr/bin/dh-exec
| usr/share/tabset
| etc/terminfo
| => usr/share/terminfo/E/Eterm
| => usr/share/terminfo/E/Eterm-color
| [...] etc.
`---

,----ncurses-term.install---
| usr/share/terminfo
`----

Unfortunately this did not quite work as expected:

,----
| dh_install -i
| Failed to move 'usr/share/terminfo/E/Eterm': No such file or directory at 
/usr/share/dh-exec/dh-exec-install-rename line 65, <> line 3.
| dh_install: error: debian/ncurses-base.install (executable config) returned 
exit code 127
`----

The file in question, usr/share/terminfo/E/Eterm, exists in debian/tmp,
but dh-exec-install-rename does not look there in line 65.  Prefixing
all the usr/terminfo/*/* files in ncurses-base.install with a leading
debian/tmp lets the build complete, but then this leading debian/tmp
also ends up in the resulting ncurses-base*.deb. :-(

The attached patch works for me, but I have not checked whether it
passes the tests yet.  Writing a new regression test would probably also
be desirable.

An ncurses branch for testing (only a binary-indep build is required)
can be found at
https://salsa.debian.org/joachim-guest/ncurses/-/tree/wip/dh-exec.


diff --git a/lib/dh-exec-install-rename b/lib/dh-exec-install-rename
index 7d4d993..d8b0355 100755
--- a/lib/dh-exec-install-rename
+++ b/lib/dh-exec-install-rename
@@ -63,6 +63,8 @@ if (/([^\s]*)\s+=>\s+([^\s]*)/ || /^=>\s+([^\s]*)/) {

         if ($move_this) {
             move ($src, File::Spec->catfile ($debpath, $dstfile)) or
+		move (File::Spec->catfile ("debian/tmp", $src),
+		      File::Spec->catfile ($debpath, $dstfile)) or
                 die "Failed to move '$src': $!";
         } else {
             cp ($src, File::Spec->catfile ($debpath, $dstfile)) or

--- End Message ---
--- Begin Message ---
Source: dh-exec
Source-Version: 0.28
Done: Craig Small <csm...@debian.org>

We believe that the bug you reported is fixed in the latest version of
dh-exec, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1028...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Craig Small <csm...@debian.org> (supplier of updated dh-exec package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 30 Oct 2023 17:33:45 +1100
Source: dh-exec
Architecture: source
Version: 0.28
Distribution: unstable
Urgency: medium
Maintainer: Craig Small <csm...@debian.org>
Changed-By: Craig Small <csm...@debian.org>
Closes: 840682 1028347
Changes:
 dh-exec (0.28) unstable; urgency=medium
 .
   [Debian Janitor]
   * Remove constraints unnecessary since buster (oldstable):
     + Build-Depends: Drop versioned constraint on perl:any (>= 5.14.2~).
     + Build-Depends: Drop versioned constraint on libdpkg-perl (>= 1.17.14~).
 .
   [Craig Small]
   * install-rename: Look in debian/tmp for files to move Closes: #1028347
   * dh-exec: Add no-defaults to not run filter and strip.
     Closes: #840682
   * Update to standards 4.6.2, no changes required.
Checksums-Sha1:
 c627cc976b75f756e182158549328685db49ca77 1624 dh-exec_0.28.dsc
 2622355c741f9ca45f46a80a36e8003f363d69bc 35952 dh-exec_0.28.tar.xz
 8c6ea41da080ad82b967e06c94132d133ddfcfbc 6357 dh-exec_0.28_amd64.buildinfo
Checksums-Sha256:
 db06800ffe6e87d6bde84d216446bbf17cf8b53c291a393d1a3144882cf6fcf1 1624 
dh-exec_0.28.dsc
 5b789230838ed0d066440073b841784d37a70fbe86530255e0668b87f733222c 35952 
dh-exec_0.28.tar.xz
 506b5ea145fc5d3c04d0bab1762fe555c6b4bc8e2ed98a84190c829c022a1c0b 6357 
dh-exec_0.28_amd64.buildinfo
Files:
 0e9a287885a3f14478d4323c6f8d19b3 1624 devel optional dh-exec_0.28.dsc
 206f4c0bb3150b9480212b902ed4fddb 35952 devel optional dh-exec_0.28.tar.xz
 31e4abec5feefb8134f0cb805eb08059 6357 devel optional 
dh-exec_0.28_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXT3w9TizJ8CqeneiAiFmwP88hOMFAmU/TrwACgkQAiFmwP88
hOPB+Q/9FfIigXUjDgZyo0MgTeawjy5WEH/9VzUTvc/t9luNfRK+72NGRKygopVZ
YQt+WJkxjmY1bl0BInqLzD0ImQ7k0rFjxVIIIy+fTDL6asJ7ucio4txgXZv74UcD
hF7JRNT2hMTRQEKEqk6QEZf2D+nPidzznoALDNG9XPUV18mdYC/Tox7I4nc528OG
wE5bKm9uK8DG6QVSmHCU1hHs6QEYYN6TEcURDaCsEStqwNDBKSwDFDbzOa/AMKv5
ktdac83hKhV39E/AKA2pG99/P/L7B32VZI7iwE8RM1Wmv7253fK9lVF2DUbbd4H+
/F2A2uy1Ul/vxYvz6w0nAo7lCmMX/B/AX3L7KedTucO4/9VuI5zzIqnVqrbKMms3
HZMPZmHKtC3iOZR4mq5+wTK6AZZ8FbXrnr2+3V90eoCaueUxF85c0/uj3cZ+18k6
VBrUQw+w95jLWujWgAGphctGgKMY/ijm0hzx7vS9VpVB0Yh4AMpL1E2n7JXdgmXT
YxNx1oVnjcaN9cm9OjddZ2uOKRO6Exmcg9m16D9molm7m/e2+Mi4A+EH5P0ujPWI
5hqs6/Ith0Ou5T/iZJ4pt8USdnaoeqiX8956kV8Du/8dVjMN6sRhHKu4akVvwT3O
1eMlR+ICeGsjACvpPF6ULNS9EPFuwJP9QEnZ2xXiKFi/ieqorjc=
=5bV/
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to