Your message dated Sat, 25 Nov 2023 18:49:03 +0000
with message-id <[email protected]>
and subject line Bug#1056346: fixed in libgeo-gpx-perl 1.10-1
has caused the Debian Bug report #1056346,
regarding libgeo-gpx-perl: error "can't open file GLOB(...)"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1056346: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1056346
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libgeo-gpx-perl
Version: 1.09-1
Severity: normal

Dear Maintainer,

According to the man page, Geo::Gpx's new() method can be passed a file
name or an already-opened file handle, but when passed a filehandle it
can fail to detect that it *is* a filehandle and attempts to treat it
like a file to be opened.

Here's a recipe to demonstrate the bug:

#  Create a minimal stupid GPX file
echo -e '<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n<gpx 
version="1.1">\n</gpx>' > test.gpx
#  cat it via pipe into a minimal Geo::Gpx script
cat test.gpx | perl -e 'use Geo::Gpx; Geo::Gpx->new(input => \*STDIN);'
#  same but not via a pipe
perl -e 'use Geo::Gpx; Geo::Gpx->new(input => \*STDIN);' < test.gpx

On Debian 11 (libgeo-gpx-perl 0.26-5) the right thing happens:

tortelli$ echo -e '<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n<gpx 
version="1.1">\n</gpx>' > test.gpx
tortelli$ cat test.gpx | perl -e 'use Geo::Gpx; Geo::Gpx->new(input => 
\*STDIN);'
tortelli$ perl -e 'use Geo::Gpx; Geo::Gpx->new(input => \*STDIN);' < test.gpx
tortelli$

On Debian 12 (libgeo-gpx-perl 1.09-1) the wrong thing happens:

farfalle$ echo -e '<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n<gpx 
version="1.1">\n</gpx>' > test.gpx
farfalle$ cat test.gpx | perl -e 'use Geo::Gpx; Geo::Gpx->new(input => 
\*STDIN);'
farfalle$ perl -e 'use Geo::Gpx; Geo::Gpx->new(input => \*STDIN);' < test.gpx
Uncaught exception from user code:
        can't open file GLOB(0x5648fd6bd630) No such file or directory at 
/usr/share/perl5/Geo/Gpx.pm line 155.
        Geo::Gpx::new("Geo::Gpx", "input", GLOB(0x5648fd6bd630)) called at -e 
line 1
farfalle$

As far as the user is concerned, 'cat blah |' and '< blah' are both
facilitating some command to read an *already-opened file* from stdin.
/usr/share/perl5/Geo/Gpx.pm:155 is using '(-f ...)' to determine if
the thing needs opening, but '(-f ...)' is not suitable for this! It
is only suitable for determining whether its operand is *or was opened
from* a file. Here's a demo with pure Perl:

farfalle$ perl -e 'printf "%d\n", (-f \*STDIN);' < /etc/passwd
1
farfalle$ cat /etc/passwd | perl -e 'printf "%d\n", (-f \*STDIN);'
0
farfalle$

Debian 11 and 12 show exactly the same output from these commands. In
both commands the file /etc/passwd *is already open* as far as
perl is concerned. But the difference in output (1 or 0) illustrates
that using '(-f ...)' is not a good test for whether something needs
opening.

I note that Debian 11's libgeo-gpx-perl's /usr/share/perl5/Geo/Gpx.pm 
does not use '(-f ...)'.

Alexis

--- End Message ---
--- Begin Message ---
Source: libgeo-gpx-perl
Source-Version: 1.10-1
Done: Bas Couwenberg <[email protected]>

We believe that the bug you reported is fixed in the latest version of
libgeo-gpx-perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bas Couwenberg <[email protected]> (supplier of updated libgeo-gpx-perl 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 25 Nov 2023 19:31:33 +0100
Source: libgeo-gpx-perl
Architecture: source
Version: 1.10-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Bas Couwenberg <[email protected]>
Closes: 1056346
Changes:
 libgeo-gpx-perl (1.10-1) unstable; urgency=medium
 .
   * New upstream release.
     (closes: #1056346)
   * Bump Standards-Version to 4.6.2, no changes.
   * Bump debhelper compat to 13.
   * Enable Salsa CI.
   * Add xclip to Suggests for waypoints_clip().
Checksums-Sha1:
 1384dabf54fe180c07a402c67c08dc7b7d9b80ea 2280 libgeo-gpx-perl_1.10-1.dsc
 b6d0d74f822e57e9d220aeb6d852bf9ed0cb4e69 43580 libgeo-gpx-perl_1.10.orig.tar.gz
 a0dfcdfa167600aa99d19c1b21d24c4de9971b13 3244 
libgeo-gpx-perl_1.10-1.debian.tar.xz
 24361c697ecfcc87f759c063456ce40a42179d26 9971 
libgeo-gpx-perl_1.10-1_amd64.buildinfo
Checksums-Sha256:
 a3f52cab10d9415c259d27d2b364dfd158d178706e8af685332a202f2f4d1b3c 2280 
libgeo-gpx-perl_1.10-1.dsc
 cf5ebf1e415c5fe6b12f5c21c4c1b705460bf03801bc8d730ee77cb6e6b7159e 43580 
libgeo-gpx-perl_1.10.orig.tar.gz
 681905ea0c0a694d29d9e6da68214567277816acbcdacc4c720938799ace4ad9 3244 
libgeo-gpx-perl_1.10-1.debian.tar.xz
 1d104e5d606159867bb422a795061ad1924aea71c625238f23b37273b74e50bc 9971 
libgeo-gpx-perl_1.10-1_amd64.buildinfo
Files:
 d86157334a936a739d6e5f6ed40746b4 2280 perl optional libgeo-gpx-perl_1.10-1.dsc
 0f5af2789fe8bb99d9fc63ff0788f7e5 43580 perl optional 
libgeo-gpx-perl_1.10.orig.tar.gz
 3f021aedcea147f7aa4ea6d0f6bb09d8 3244 perl optional 
libgeo-gpx-perl_1.10-1.debian.tar.xz
 8dc0bfa12f3d935f05786cd18241c566 9971 perl optional 
libgeo-gpx-perl_1.10-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEgYLeQXBWQI1hRlDRZ1DxCuiNSvEFAmViPkYACgkQZ1DxCuiN
SvE11w//dU1inMUsPLiEM6F7piEsvzfVliMCCgnrgVU1ZdpmAR+3NP/KJH6O74s5
iNVOz7rg5yag4M0cozkZAl04l+DOK4IjgOKWBGBhF9r3EYDjuc7xpnOFqHodtqJG
SzGThH/+lKkQq9RoxSPd0Q9cLg7XDfMHJ2Ac87OhxY4ozWnkFKr3FtTkJWKq9Bf9
ktSqZtPDIFUKzWecko4EjoYinQL/+WZxYsoItCfd59xMUZB18FHO0sTIKUF6f/41
ik1p/Sz7dpTpef8Z+NLmr1ljHVcmiafA46htNejYTtlmN082J1gB5Z1CAn3XmqNp
ORS6lkoiwQfcqgqM7Ml9kknhlMgWOOMvJjBO/Ffjt2/NUImCE2ieVH1ogyu6xeOD
T90VNOXdF7DYKOtapZ1RBu11ktT4AcV7rshhJEPfA+mFgxFCPl8FERXom88iFGHK
VBTm9JiVhIA4KM0Bv9HpCZS9E4srIlLnnaPqSf9ZWnfFGzoV0eHuXKXj9byfhRn5
a9/pJZlCH92hO7Jfyc2uu3Y8Js2D26PYrMl+C+d/y4EeiDzpTLfVkl8E6jzQTw+6
dhGXBXiQD/sC+VRgTyPfTNbVZu4LqtyjzudXdCdQQPdS8hjd8KlNX5gM4Uvste/6
e4TkTEo1YLhD73IBZXkK/TU5a7OEvN7HV8Nmlz8T+xAOuYfaid0=
=sSSt
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to