Your message dated Tue, 19 Dec 2023 14:57:54 -0800
with message-id <87bkal7qbx.fsf@contorta>
and subject line Re: libadwaita-1: reproducible builds: Embedded date in .xml
file
has caused the Debian Bug report #1005793,
regarding libadwaita-1: reproducible builds: Embedded date in .xml file
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1005793: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005793
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libadwaita-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]
The file /usr/share/metainfo/org.gnome.Adwaita1.Demo.metainfo.xml
contains an embedded build date:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libadwaita-1.html
<release·version="1.0.2"·date="2023-03-19">
vs.
<release·version="1.0.2"·date="2022-02-15">
The attached patch fixes this by removing the call to date from the
meson.build file.
An alternate option would be to use the SOURCE_DATE_EPOCH environment
variable, and there is a meson example available:
https://reproducible-builds.org/docs/source-date-epoch/
This would be better if the package somehow fails to work correctly when
there is no date in this file, though ideally no timestamp would be
better if possible.
With this patch applied, libadwaita-1 should build reproducibly on
tests.reproducible-builds.org!
Thanks for maintaining libadwaita-1!
live well,
vagrant
From c0be5862ff331f874e674a041209451f91329ed6 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <[email protected]>
Date: Tue, 15 Feb 2022 01:06:49 +0000
Subject: [PATCH] demo/data/meson.build: Remove build date.
The build date does not appear to be required, and makes the build
unreproducible when built on a different date.
---
demo/data/meson.build | 8 --------
1 file changed, 8 deletions(-)
diff --git a/demo/data/meson.build b/demo/data/meson.build
index 612410c5..55b4152c 100644
--- a/demo/data/meson.build
+++ b/demo/data/meson.build
@@ -15,14 +15,6 @@ if desktop_utils.found()
endif
today = 'unknown'
-date = find_program('date',
- required: false)
-if date.found()
- r = run_command(date, '-I')
- if r.returncode() == 0
- today = r.stdout().strip()
- endif
-endif
appdata_config = configuration_data()
appdata_config.set('BUILD_VERSION', meson.project_version())
--
2.34.1
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Version: 1.4.0-1
On 2022-02-14, Vagrant Cascadian wrote:
> The file /usr/share/metainfo/org.gnome.Adwaita1.Demo.metainfo.xml
> contains an embedded build date:
>
>
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libadwaita-1.html
>
> <release·version="1.0.2"·date="2023-03-19">
> vs.
> <release·version="1.0.2"·date="2022-02-15">
>
> The attached patch fixes this by removing the call to date from the
> meson.build file.
>
>
> An alternate option would be to use the SOURCE_DATE_EPOCH environment
> variable, and there is a meson example available:
>
> https://reproducible-builds.org/docs/source-date-epoch/
Upstream added support for SOURCE_DATE_EPOCH at some point in the
meson.build file; all the builds since 1.4.0-1 appear to be
reproducible:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libadwaita-1.html
Marking as done.
live well,
vagrant
signature.asc
Description: PGP signature
--- End Message ---
