Your message dated Mon, 29 Jan 2024 04:34:06 +0000
with message-id <[email protected]>
and subject line Bug#1059917: fixed in guake 3.10-2
has caused the Debian Bug report #1059917,
regarding guake: build race for /usr/share/glib-2.0/schemas/gschemas.compiled
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1059917: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059917
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: guake
Version: 3.10-1
Severity: normal
User: [email protected]
X-Debbugs-Cc: [email protected]

Dear Maintainer,

I'm an occasional volunteer for the Reproducible Builds[0] project,
and recently noticed that the quake package failed to build reproducibly
from source.

The difference between the builds was the presence-or-absence of a file at
the path /usr/share/glib-2.0/schemas/gschemas.compiled in the built package.

This file should not be shipped in the contents of distro packages[1][2] (but
can be regenerated by them after installation, as guake's postinst script
does).

So: why is the file _sometimes_ found when building the guake package from
source?  It think it's due to a race condition in the Makefile:

  install-system: install-schemas compile-shemas install-locale install-guake


The 'compile-shemas' (sic) target expects to compile source .xml files from a
parameterized $(DESTDIR)$(gsettingsschemadir) path that expands to the build
dir with an /glib-2.0/schemas suffix.  However: the .xml files are created in
that path by the 'install-schemas' target.

Even though 'compile-shemas' is listed _after_ 'install-schemas', it's possible
for 'make' to run them both in parallel when enabled[3].

If the files aren't there by the time 'compile-shemas' runs, we see a message:

  No schema files found: doing nothing.

...and no gschemas.compiled file is created (as is desired!  but by relying on
a race condition).


One fix here could be to update the Makefile so that it maps the dependency
between the two relevant build targets correctly, ensuring that
'install-schemas' runs before 'compile-shemas'.

However: I think a simpler fix for Debian's packaging could be to set the
COMPILE_SCHEMAS environment flag used by the Makefile to zero, to disable
creation of the glib-2.0 gschemas.compiled file -- avoiding the race condition
entirely.

Regards,
James

[0] - https://reproducible-builds.org/

[1] - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884142

[2] - https://github.com/Guake/guake/pull/1893#discussion_r707307822

[3] - https://www.gnu.org/software/make/manual/html_node/Parallel.html

--- End Message ---
--- Begin Message ---
Source: guake
Source-Version: 3.10-2
Done: Daniel Echeverri <[email protected]>

We believe that the bug you reported is fixed in the latest version of
guake, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Echeverri <[email protected]> (supplier of updated guake package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 28 Jan 2024 21:36:10 -0500
Source: guake
Architecture: source
Version: 3.10-2
Distribution: unstable
Urgency: medium
Maintainer: Daniel Echeverri <[email protected]>
Changed-By: Daniel Echeverri <[email protected]>
Closes: 1059917
Changes:
 guake (3.10-2) unstable; urgency=medium
 .
   [ Alexandre Detiste ]
   * remove extranous dep. on old python3-mock
 .
   [ Daniel Echeverri ]
   * Disable creation of glib-2.0 gschemas.compiled (Closes: #1059917)
Checksums-Sha1:
 80e4c6276e7e795d0ba9f70745fe468b36d17a3b 2252 guake_3.10-2.dsc
 3807f854a4364aca8bbd22a6be93b8cfb3e5a57e 17528 guake_3.10-2.debian.tar.xz
 0a4100e8e473c9918fb0856b66cf8c486abfb196 9743 guake_3.10-2_amd64.buildinfo
Checksums-Sha256:
 00e645bfc4269dad09e12fdeea1b981fab65527f7964e6a11b787c5f4f67e9b7 2252 
guake_3.10-2.dsc
 d9ff2d4e243021bae836b2344b15bc462fe08985582b1449b4202b3cb8db13a9 17528 
guake_3.10-2.debian.tar.xz
 68c4dc2c629c10441c322119c4da379e0f78e827e62bbb686568d8aab63f73f5 9743 
guake_3.10-2_amd64.buildinfo
Files:
 93d648e67610395164b4a6e6f220d435 2252 x11 optional guake_3.10-2.dsc
 54077b6f4d4d5ffaaa4c9d479ddc359a 17528 x11 optional guake_3.10-2.debian.tar.xz
 1336b561b61de221579bd6f9a08e4771 9743 x11 optional guake_3.10-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEE0NCFsWnDv9lASFj6IfwpUEtSMNsFAmW3JiITHGVwc2lsb25A
ZGViaWFuLm9yZwAKCRAh/ClQS1Iw2xYaEADIHKGCsXsI9T+po1Ua2fpARIvKErhx
fyB1yIMQllA4mcn9FnqovuYI9Tzw2w0cdPuKHCOz/k8Fb0CpyMAWtNkpDBJ7675C
5t59oyWYGiQbiMfrB9s6EGJVTg7rJlHSEJm1XMI/Y6LGrV6NUVr2ioPpVYptiUC1
3plPOuUgD2K7VNKpmAeuhS3aBzWglhPLVgudt3OkNlK3CxmkvYThuWmc7aI4jabM
aRdaU5I2aRySriAwcXwV6zVZ47E3TixWufB6c487ASVKrrxqefOIKqUem12eHtso
FUeE3Ll1xDUSf+WWqGycOGaft3qIpcezSwPkumLZDOwCMnG9MwbwURZ6unMfk+R1
fHeOVqNXI/G1iWXutc1UiiH1uGHYpxWglS4iaQF9LNMvGHIZcZ8y+gkPMVKlO1RU
syHA4oApIfncnvNKJvmm+UfAJw9SWJxrqQkqJCjcZH1zATGSoGkqIgqo7MxHBUY7
KemCLo8gCIVjbdUqqykJC1/ApUhnKLQQxsXipjNSWJFhX0Pm0YxgGAjkpmxB478H
S/1nwZdv0cSmxMlXvH9mDQNsNwP8QLhWQoFNj6CPS+nhCLkSZtdCKh22tQ1syUAZ
1F0HQFiBdAum/MQMHM3az3v0u/ctK8UgCtr7frvzX2eWd9dvkyFNRNJKiG6JQPKz
+XzNNZhoIeDJaQ==
=pIsT
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to