Your message dated Sun, 17 Mar 2024 23:13:14 +0100
with message-id <[email protected]>
and subject line Re: [Pkg-mailman-hackers] Bug#1031928:
python3-django-hyperkitty: Javascript not loaded because of HTML error
has caused the Debian Bug report #1031928,
regarding python3-django-hyperkitty: Javascript not loaded because of HTML error
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1031928: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031928
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python3-django-hyperkitty
Version: 1.3.4-4
Severity: grave
Tags: patch
Justification: renders package unusable
Dear Maintainer,
I set up mailman3 including the web interface and the hyperkitty
archiver with Apache2 and a test mailing list.
Upon accessing the archive at
https://<mywebserver>/mailman3/hyperkitty/list/test@<mydomain>/
I immediately noticed that the page was incomplete, showing only
rotating spinners where some of the context should be.
Further investigation showed that the HTML is wrong:
<script type="text/javascript"
src="/mailman3/static/hyperkitty/libs/popper/popper.min.js" />
<script type="text/javascript"
src="/mailman3/static/hyperkitty/libs/bootstrap/javascripts/bootstrap.min.js" />
...
In normal HTML (not XHTML) a <script> element needs to be closed with a
</script> tag, the XML-style /> ending is not recognized. The result is
that browsers (at least Firefox and Chromium) ignore all scripts except
the first.
replacing "/>" with "></script>" on the offending lines fixes the
problem
PS: I do notice that those lines are enclosed in
{% compress js %}...{% endcompress %} so it could also be that that
doesn't work properly
-- System Information:
Debian Release: 11.6
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-21-amd64 (SMP w/2 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages python3-django-hyperkitty depends on:
ii fonts-glyphicons-halflings 1.009~3.4.1+dfsg-2
ii libjs-bootstrap4 4.5.2+dfsg1-8~deb11u1
ii libjs-sphinxdoc 3.4.3-2
ii python3 3.9.2-3
ii python3-dateutil 2.8.1-6
ii python3-django 2:2.2.28-1~deb11u1
ii python3-django-compressor 2.4-2
ii python3-django-extensions 3.0.3-3
ii python3-django-gravatar2 1.4.4-2
ii python3-django-haystack 3.0-1
ii python3-django-mailman3 1.3.5-2
ii python3-django-q 1.2.1-1
ii python3-djangorestframework 3.12.1-1
ii python3-elasticsearch 7.1.0-3
ii python3-flufl.lock 5.0.1-1
ii python3-mailmanclient 3.3.2-1
ii python3-networkx 2.5+ds-2
ii python3-robot-detection 0.4.0-2
ii python3-tz 2021.1-1
Versions of packages python3-django-hyperkitty recommends:
ii mailman3-web 0+20200530-2
python3-django-hyperkitty suggests no packages.
-- no debconf information
--- orig/base.html 2023-02-25 14:55:29.682952431 +0100
+++ fixed/base.html 2023-02-25 14:55:42.702972701 +0100
@@ -218,18 +218,18 @@
<script src="{% static 'hyperkitty/libs/jquery/jquery-1.10.1.min.js'
%}"></script>
<script src="{% static
'hyperkitty/libs/jquery/jquery-ui-1.10.3.custom.min.js' %}"></script>
{% compress js %}
- <script type="text/javascript" src="{% static
'hyperkitty/libs/popper/popper.min.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/libs/bootstrap/javascripts/bootstrap.min.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/libs/mousetrap/mousetrap.min.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/libs/jquery.expander.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/libs/d3.v2.min.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/libs/jquery.hotkeys.js' %}" />
- <script type="text/javascript" src="{% static 'django-mailman3/js/main.js'
%}" />
- <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-common.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-index.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-overview.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-thread.js' %}" />
- <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-userprofile.js' %}" />
+ <script type="text/javascript" src="{% static
'hyperkitty/libs/popper/popper.min.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/libs/bootstrap/javascripts/bootstrap.min.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/libs/mousetrap/mousetrap.min.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/libs/jquery.expander.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/libs/d3.v2.min.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/libs/jquery.hotkeys.js' %}" ></script>
+ <script type="text/javascript" src="{% static 'django-mailman3/js/main.js'
%}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-common.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-index.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-overview.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-thread.js' %}" ></script>
+ <script type="text/javascript" src="{% static
'hyperkitty/js/hyperkitty-userprofile.js' %}" ></script>
{% endcompress %}
{% block additionaljs %} {% endblock %}
--- End Message ---
--- Begin Message ---
Considering the version of django-compressor in bookworm, I think this
bug can be closed.
Feel free to reopen if I'm wrong.
James Addison <[email protected]> wrote on 04/03/2023 at 13:21:34+0100:
> Package: python3-django-hyperkitty
> Followup-For: Bug #1031928
> X-Debbugs-Cc: [email protected]
>
>> Can I change the severity of the bug?
>
> You should be able to do that, yes: by placing BTS (bug tracking system)
> control commands (as 'pseudoheaders') at the start of your email messages to
> bug threads: https://www.debian.org/Bugs/Reporting#additionalpseudoheaders
>
>> > Would you be willing to send your patch to the upstream hyperkitty
>> > project[1]
>> > as well? (likely as a merge request on their GitLab instance)
>
>> Sure, but it seems to be fixed in upstream already, presumably because
>> they use a significantly newer version of django-compressor (4.3.1
>> instead of 2.4). The newer version of django-compressor reformats
>> <script .. /> to <script ..></script> even if COMPRESS_ENABLED = False.
>
> Fair point.. hmm. Ideally we'd want test coverage to ensure that it doesn't
> happen again, though.
>
> The upstream codebase does appear to assert on the contents[1] of the HTML
> response in some cases; something similar could work as a regression test
> for this bug.
>
> [1] -
> https://gitlab.com/mailman/hyperkitty/-/blob/aae84b89184b9ae048ca693d332b7478f8734d4e/hyperkitty/tests/views/test_index.py#L214-220
>
> _______________________________________________
> Pkg-mailman-hackers mailing list
> [email protected]
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-mailman-hackers
signature.asc
Description: PGP signature
--- End Message ---
