Your message dated Sat, 6 Apr 2024 11:14:28 +0200
with message-id <[email protected]>
and subject line Re: FTBFS: removed definition of refreshed bool github
monero-project/monero #8673
has caused the Debian Bug report #1025927,
regarding FTBFS: removed definition of refreshed bool github
monero-project/monero #8673
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1025927: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025927
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cryptocoin
Version: 0.18.0.0+~0+20200826-1
Severity: normal
Dear Maintainer,
I was unable to build the package from source due to debian treating
warnings as errors. I've asked upstream if they want the patch, and
they seem to be declining.
>From conversation on https://github.com/monero-project/monero/pull/8673
<selsta> It should not fail to build from source due to an unused variable,
unless you changed other things.
log=<<EOIRC
Day changed to 11 Dec 2022
04:15 -xmr-pr:#monero-dev- cjac opened pull request #8673: removed unused
refreshed bool
04:15 -xmr-pr:#monero-dev- >
https://github.com/monero-project/monero/pull/8673
18:28 < cjac> hi folks, could I get a LGTM for
https://github.com/monero-project/monero/pull/8673 ?
18:29 < cjac> selsta: the FTBFS came from particularly strict gcc flags
18:29 < cjac> this is the debian policy, so it's keeping debian from
building. I could commit this patch
to debian, but I wanted to check with you folks first.
18:30 < cjac> https://paste.debian.net/1263691/
18:52 <+selsta> cjac: where did you add this GCC flag? and why does it
cause the compiler to get killed?
18:54 <+selsta> if you add some kind of "treat warnings as errors" flag it
wouldn't kill the compiler as
far as i'm aware
20:21 < jtgrassie> cjac: "this is the debian policy, so it's keeping debian
from building." <- package
maintainers are free t use whatever compiler options
they like
20:22 < jtgrassie> you're only highlighting a warning, not an error
21:36 < cjac> jtgrassie, selsta: no problem. I can patch the debian
package, but our policy is to try to
offer upstream first. If you don't want this patch, no
worries.
EOIRC
I tried removing the definition of the offending variable, but it is
used elsewhere, so instead I removed the definition.
This patch will merely remove the definition of the refreshed bool at
declaration time.
=== Patch begins ===
diff --git a/debian/patches/2002_privacy.patch
b/debian/patches/2002_privacy.patch
index a2725ba47..6d4f78ac5 100644
--- a/debian/patches/2002_privacy.patch
+++ b/debian/patches/2002_privacy.patch
@@ -6,7 +6,7 @@ Last-Update: 2022-07-31
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/README.md
+++ b/README.md
-@@ -10,7 +10,6 @@ Portions Copyright (c) 2012-2013 The Cryptonote
developers.
+@@ -10,7 +10,6 @@
- [Research](#research)
- [Announcements](#announcements)
- [Translations](#translations)
@@ -14,7 +14,7 @@ This patch header follows DEP-3:
http://dep.debian.net/deps/dep3/
- [Introduction](#introduction)
- [About this project](#about-this-project)
- [Supporting the project](#supporting-the-project)
-@@ -56,15 +55,6 @@ The CLI wallet is available in different languages. If
you want to help translat
+@@ -56,15 +55,6 @@
If you need help/support/info about translations, contact the
localization workgroup. You can find the complete list of contacts on the
repository of the workgroup: [monero-translat
ions](https://github.com/monero-ecosystem/monero-translations#contacts).
@@ -30,7 +30,7 @@ This patch header follows DEP-3:
http://dep.debian.net/deps/dep3/
## Introduction
Monero is a private, secure, untraceable, decentralised digital currency.
You are your bank, you control your funds, and nobody can trace your
transfers unless you allow them to do
so.
-@@ -101,11 +91,11 @@ The Bitcoin donation address is:
+@@ -101,11 +91,11 @@
Core development funding and/or some supporting services are also
graciously provided by [sponsors](
https://www.getmonero.org/community/sponsorships/):
diff --git a/debian/patches/2003_refreshed_ftbfs_8673.patch
b/debian/patches/2003_refreshed_ftbfs_8673.patch
new file mode 100644
index 000000000..79a2d2390
--- /dev/null
+++ b/debian/patches/2003_refreshed_ftbfs_8673.patch
@@ -0,0 +1,19 @@
+removed definition of refreshed bool #8673
+
+https://github.com/monero-project/monero/pull/8673
+
+/usr/src/git/salsa/cryptocoin-team/monero/src/wallet/wallet2.cpp:3427:8:
warning: variable ‘refreshed’ set but not used [-Wunused-but-set-variable]
+3427 | bool refreshed = false;
+
+Fails to build from source.
+--- a/src/wallet/wallet2.cpp
++++ b/src/wallet/wallet2.cpp
+@@ -3424,7 +3424,7 @@
+ uint64_t blocks_start_height;
+ std::vector<cryptonote::block_complete_entry> blocks;
+ std::vector<parsed_block> parsed_blocks;
+- bool refreshed = false;
++ bool refreshed;
+ std::shared_ptr<std::map<std::pair<uint64_t, uint64_t>, size_t>>
output_tracker_cache;
+ hw::device &hwdev = m_account.get_device();
+
diff --git a/debian/patches/series b/debian/patches/series
index f04e571a7..c4c103630 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
2001_system_shared_libs.patch
2002_privacy.patch
+2003_refreshed_ftbfs_8673.patch
=== Patch ends ===
-- System Information:
Debian Release: 11.5
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-18-amd64 (SMP w/12 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE
not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
--- End Message ---
--- Begin Message ---
As there was no answer, I am closing this unreproducible bug report.
--- End Message ---
