Your message dated Tue, 09 Apr 2024 12:39:43 +0000
with message-id <[email protected]>
and subject line Bug#1068377: fixed in python-oslo.messaging 14.7.0-3
has caused the Debian Bug report #1068377,
regarding python-oslo.messaging: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1068377: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068377
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: python-oslo.messaging
Version: 14.7.0-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: hostname
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed that
python-oslo.messaging could not be built reproducibly.
This is because the documentation captures the hostname of the build
system. Specifically:
├── ./usr/share/doc/python3-oslo.messaging/html/configuration/opts.htm
│ │ Type:
│ │ string
│ │ Default:
| │ - ionos11-amd64
│ │ │ │ │ + i-capture-the-hostname
│ │ Hostname used by queue manager
Patch attached that uses the Python "blah = None" / "if blah is None"
pattern so that the Python default is the value "None" whilst the
underlying functionality remains the same — ie. defaulting to
socket.gethostname().
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible-build.patch 2024-04-04 10:31:01.530250426
+0100
@@ -0,0 +1,35 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2024-04-04
+
+--- python-oslo.messaging-14.7.0.orig/oslo_messaging/_drivers/impl_rabbit.py
++++ python-oslo.messaging-14.7.0/oslo_messaging/_drivers/impl_rabbit.py
+@@ -246,7 +246,7 @@ rabbit_opts = [
+ default=False,
+ help='Should we use consistant queue names or random ones'),
+ cfg.StrOpt('hostname',
+- default=socket.gethostname(),
++ default=None,
+ help='Hostname used by queue manager'),
+ cfg.StrOpt('processname',
+ default=os.path.basename(sys.argv[0]),
+@@ -697,6 +697,10 @@ class Connection(object):
+ self.enable_cancel_on_failover = driver_conf.enable_cancel_on_failover
+ self.use_queue_manager = driver_conf.use_queue_manager
+
++ self.hostname = driver_conf.hostname
++ if self.hostname is None:
++ self.hostname = socket.gethostname()
++
+ if self.rabbit_stream_fanout and self.rabbit_qos_prefetch_count <= 0:
+ raise RuntimeError('Configuration Error: rabbit_stream_fanout '
+ 'need rabbit_qos_prefetch_count to be set to '
+@@ -888,7 +892,7 @@ class Connection(object):
+
+ if self.use_queue_manager:
+ self._q_manager = amqpdriver.QManager(
+- hostname=driver_conf.hostname,
++ hostname=self.hostname,
+ processname=driver_conf.processname)
+ else:
+ self._q_manager = None
--- a/debian/patches/series 2024-04-04 10:18:59.452475473 +0100
--- b/debian/patches/series 2024-04-04 10:31:00.538244802 +0100
@@ -1 +1,2 @@
no-functional-test.patch
+reproducible-build.patch
--- End Message ---
--- Begin Message ---
Source: python-oslo.messaging
Source-Version: 14.7.0-3
Done: Thomas Goirand <[email protected]>
We believe that the bug you reported is fixed in the latest version of
python-oslo.messaging, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Goirand <[email protected]> (supplier of updated python-oslo.messaging
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 09 Apr 2024 12:00:31 +0200
Source: python-oslo.messaging
Architecture: source
Version: 14.7.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenStack <[email protected]>
Changed-By: Thomas Goirand <[email protected]>
Closes: 1068377
Changes:
python-oslo.messaging (14.7.0-3) unstable; urgency=medium
.
* Make oslo.messaging, zaqar and magnum reproducible by adding this simple
patch: reproducible.patch (Closes: #1068377).
Checksums-Sha1:
a1cdb230449089fd3fabfcd37e7de5c7e0bd8163 2887
python-oslo.messaging_14.7.0-3.dsc
bfa2e90fe0bd07986852037c1f6c812f23155b1c 8712
python-oslo.messaging_14.7.0-3.debian.tar.xz
f164f152a491ac1019b4d636461730e6e99f62e3 12909
python-oslo.messaging_14.7.0-3_amd64.buildinfo
Checksums-Sha256:
76d2f24012294a00cd7396a45aeced7a82d1593274a1c1470600f5a1a90e6513 2887
python-oslo.messaging_14.7.0-3.dsc
eee4a7d83453c9f7853d5af9aa8e510d4730bfdca83fe2cc3248584be53d58d6 8712
python-oslo.messaging_14.7.0-3.debian.tar.xz
8e777927d699ca4e429e7ba09221eab0a54ccc0a9877e67fcbf5a74142f09828 12909
python-oslo.messaging_14.7.0-3_amd64.buildinfo
Files:
5bbe9c2534505811a7449c1caae249e7 2887 python optional
python-oslo.messaging_14.7.0-3.dsc
86e24f687101d5ffa55ac2825a36338c 8712 python optional
python-oslo.messaging_14.7.0-3.debian.tar.xz
8d33e32e47853d6897a12e0ce50b163f 12909 python optional
python-oslo.messaging_14.7.0-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEoLGp81CJVhMOekJc1BatFaxrQ/4FAmYVK/IACgkQ1BatFaxr
Q/5B5w/+IbrzL5tqCqv0nrMfHoLhhUx+DrA9ArBPURD1MqZllBo0apwhTWeB0F11
Z8BoX603kwzWBacB8YXm4TfknSM65VAyvnqwEBIaB79kkwjZwFhAmNByWzniaw0g
xAK23n6NvL1Fm8UOC9unmeQ3X3vCd09QzTkbpq3KIJkli7F3Pe73m2WocRAOs4A+
wbWmYuiK3Te4DhtumIyO/7ypFoedG0m8FiA8/cu3R+4nyUUu25IeyU1PegTYFcue
n2wap+J2+54hrJbbJRQGHLn8zCqbwnekpHs3xCLJl62bFOROPVn8aQ/RbXSIIyAI
8+9cyIhPlVylsrd9Vz7kz5V8sc4TroCzbuuo0JP2yhQQyX2SO1KgqstIjCGu7dxs
D+uXKO56X2jWwjXnap2kmLzBwKQyyESXWnIPj0jDs2ZxNcV7NHqDLaWbdUD1Yj/7
AKPyMaMu+DWRVXL+klJkym1dUPiPr6ZZY9h6l79ULLrGvnt7eic+8K2X7wOKOwZT
5vvIuLsCYOpYbi5dHHYlytW2/yKJ6eLwRp2uMvcQOkn54GnBPZPNgc6U3TftZhTD
UXnU22pKEl4uohYG9wDWy6TyJJUgnYUCBfaA9lZAQqWG0RsAhQiznhzrY0fruOqw
GKDZqvm6lF4qlpEHyPozq0UMTvnLLHNVMPkvkiK9H3lkDJkFSn8=
=RPWm
-----END PGP SIGNATURE-----
pgpeOFW7KSkxJ.pgp
Description: PGP signature
--- End Message ---
