Your message dated Fri, 26 Apr 2024 20:43:11 +0000
with message-id <[email protected]>
and subject line Bug#1068176: fixed in goldendict-ng 24.02.16-2
has caused the Debian Bug report #1068176,
regarding goldendict-ng: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1068176: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068176
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: goldendict-ng
Version: 23.12.26-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timezone
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
goldendict-ng could not be built reproducibly.

This is because it does not specify the "UTC" argument to CMake's
TIMESTAMP macro function, so the build time embedded in the final
binary, whilst based on SOURCE_DATE_EPOCH, varies by the build
timezone.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-


--- a/debian/patches/0002-Reproducible-build.patch      1970-01-01 
01:00:00.000000000 +0100
--- b/debian/patches/0002-Reproducible-build.patch      2024-04-01 
11:02:36.411764040 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2024-04-01
+
+--- goldendict-ng-23.12.26.orig/CMakeLists.txt
++++ goldendict-ng-23.12.26/CMakeLists.txt
+@@ -54,7 +54,7 @@ set(CMAKE_AUTORCC ON) # not included in
+ #### Things required during configuration
+ 
+ block() # generate version.txt
+-    string(TIMESTAMP build_time)
++    string(TIMESTAMP build_time UTC)
+     find_package(Git)
+     if (EXISTS "${CMAKE_SOURCE_DIR}/.git" AND GIT_FOUND)
+         execute_process(
--- a/debian/patches/series     2024-04-01 09:53:57.209332464 +0100
--- b/debian/patches/series     2024-04-01 11:02:35.515760642 +0100
@@ -1 +1,2 @@
 0001-Disable-checkUpdate-by-default.patch
+0002-Reproducible-build.patch

--- End Message ---
--- Begin Message ---
Source: goldendict-ng
Source-Version: 24.02.16-2
Done: Boyuan Yang <[email protected]>

We believe that the bug you reported is fixed in the latest version of
goldendict-ng, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <[email protected]> (supplier of updated goldendict-ng package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 26 Apr 2024 14:58:09 -0400
Source: goldendict-ng
Architecture: source
Version: 24.02.16-2
Distribution: unstable
Urgency: medium
Maintainer: Boyuan Yang <[email protected]>
Changed-By: Boyuan Yang <[email protected]>
Closes: 1044294 1068176
Changes:
 goldendict-ng (24.02.16-2) unstable; urgency=medium
 .
   * d/p/e62dded0f62c143406df775b604e86cb933d92ee.patch:
     Fix reproducible-builds issue, patch from upstream. (Closes: #1068176)
   * d/rules: Clean src/scripts/jquery-3.6.0.slim.min.js in dh_clean.
     (Closes: #1044294)
Checksums-Sha1:
 505522afde154655fa00e2d0cfc2f979f31ad0ae 2360 goldendict-ng_24.02.16-2.dsc
 7de6da3201832fdf0b1f9727820391e117562bbf 5134268 
goldendict-ng_24.02.16.orig.tar.xz
 404b6740d2b23d9921b9b16a492125d7583e2b21 23452 
goldendict-ng_24.02.16-2.debian.tar.xz
 fb8c9c63c10abaeaba47b7be37718472e9a0af57 19033 
goldendict-ng_24.02.16-2_amd64.buildinfo
Checksums-Sha256:
 d1ac04168c6278b781d6159bc4e1bdceff5437f00a04b4a673654e510a624a50 2360 
goldendict-ng_24.02.16-2.dsc
 e626ca361f4e8607df4cbbf11b7441fc6563527da23b8d21d65c7458f1808cc8 5134268 
goldendict-ng_24.02.16.orig.tar.xz
 3336d6d601a5a8f3ae5d85ab6a6199721e1307b030ea6f2e4913241de870b1aa 23452 
goldendict-ng_24.02.16-2.debian.tar.xz
 0d66b1801ef7e383f748bf3db387fbdbee2d7547136410b8f70f7349635ddbb2 19033 
goldendict-ng_24.02.16-2_amd64.buildinfo
Files:
 0bca52a02c48cce77595c123d1ce4aa2 2360 utils optional 
goldendict-ng_24.02.16-2.dsc
 8d5767e0127d1e3fe8f6a3aa7dc51560 5134268 utils optional 
goldendict-ng_24.02.16.orig.tar.xz
 dace362793c7266668d5e5a9cc721e00 23452 utils optional 
goldendict-ng_24.02.16-2.debian.tar.xz
 f85f4de3e962df1db550ff578b906ad5 19033 utils optional 
goldendict-ng_24.02.16-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmYsCJEACgkQwpPntGGC
Ws5WbRAAmS6XlTqqS3K/PknHo/vMW0GbKAUnOmtVLl7r1aDDyRooJOZwguklItcf
7QuPRZctYCeYFlLsypkOfoWhFfTRmrVN+0tC32fyi+pDkzZhcIPSZtdKWNWexoaY
RMqg8eUYNAQWT/o0fTsHAwr7SI665BYkCVmh2tI+ZRmE2WGPIRF5vGi7xUKLs2pc
if3D6hY1H+aEwbs1J7Dev76XjbCT+VtJSw75U7d2XhYigqMG5yvX+K+j4wLrs7F4
/gWzSPrI7DQHQmyxW0SHJYHFJYN7iUJ9lt5N4IaWDDH21oHMLUxC63BmCapDYsV8
P4am5VKpFoSP+PyhxwU68BX8NLxktRz6nCu/sRPTTeENwz2LdOGW5P7IXdUQBFpA
6EWSdoH3LnXqn9yHOXsFMLBAADP1ss22WyU7QkwwWxtzcjTho2NxFYkIgVvKrjGg
wTQN3qACNJZcvgeuQW9UtbRI3bgh80ASKwYHQrRJr53flFIJ7LYdyC7dEgoCsaji
xrUM1Tbeh3Smquu0q9TWWaNz+xFtrkGbCrGvMSzO6MwOrMnSitDiWk+9gs16+/UG
Xl/3YTpjqdlid2ol63vQhDVGefsBSFVDL1oipxf5uyvlHkMVsJ5zwt8qtMZY492D
1PlAipJE4MHr2z8JVcCoLJeOuO3dALp7sXI6lY3sE4u/s/LGQNo=
=439Z
-----END PGP SIGNATURE-----

Attachment: pgp2lNTXYnsgy.pgp
Description: PGP signature


--- End Message ---

Reply via email to