Your message dated Mon, 13 May 2024 16:49:26 +0000
with message-id <[email protected]>
and subject line Bug#1067815: fixed in click 0.5.2-3
has caused the Debian Bug report #1067815,
regarding click: please add support for loongarch
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1067815: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067815
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: click
Severity: normal
Tags: patch
User: [email protected]
Usertags: loong64
X-Debbugs-Cc: [email protected]
Dear Maintainer,
click failed to test on loongarch platform, please refer to the attached patch
to fix the error.
-- System Information:
Debian Release: trixie/sid
APT prefers unreleased
APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: loong64 (loongarch64)
Kernel: Linux 5.10.0-60.96.0.126.oe2203.loongarch64 (SMP w/32 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
>From ad41a4ef425dcc65692d272d4589552ebfc6d933 Mon Sep 17 00:00:00 2001
From: wuruilong <[email protected]>
Date: Wed, 27 Mar 2024 06:13:07 +0000
Subject: [PATCH] add support for loongarch
---
configure.ac | 2 ++
preload/clickpreload.c | 18 ++++++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/configure.ac b/configure.ac
index ff69711..fca64bb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -57,6 +57,8 @@ AS_IF([test "${DBUS_TEST_RUNNER_CHECK}" != "yes"],
[AC_MSG_ERROR([dbus-test-runn
AC_CHECK_PROG(GDBUS_CHECK,gdbus,yes)
AS_IF([test "${GDBUS_CHECK}" != "yes"], [AC_MSG_ERROR([gdbus (glib) not
found])])
+AC_CHECK_FUNC(__xmknod __xstat __xstat64)
+
# Structure characteristics needed for the Python/C integration in the test
# suite.
AC_COMPUTE_INT([STAT_OFFSET_UID], [offsetof(struct stat, st_uid)], [
diff --git a/preload/clickpreload.c b/preload/clickpreload.c
index 2799bff..2c564ab 100644
--- a/preload/clickpreload.c
+++ b/preload/clickpreload.c
@@ -60,9 +60,15 @@ static int (*libc_open) (const char *, int, ...) = (void *)
0;
static int (*libc_open64) (const char *, int, ...) = (void *) 0;
#endif
static int (*libc_symlink) (const char *, const char *) = (void *) 0;
+#ifdef HAVE___XMKNOD
static int (*libc___xmknod) (int, const char *, mode_t, dev_t *) = (void *) 0;
+#endif
+#ifdef HAVE___XSTAT
static int (*libc___xstat) (int, const char *, struct stat *) = (void *) 0;
+#endif
+#ifdef HAVE___XSTAT64
static int (*libc___xstat64) (int, const char *, struct stat64 *) = (void *) 0;
+#endif
static int (*libc_stat) (const char *, struct stat *) = (void *) 0;
#ifdef __GLIBC__
static int (*libc_stat64) (const char *, struct stat64 *) = (void *) 0;
@@ -125,9 +131,15 @@ static void __attribute__ ((constructor))
clickpreload_init (void)
GET_NEXT_SYMBOL (open64);
#endif
GET_NEXT_SYMBOL (symlink);
+#ifdef HAVE___XMKNOD
GET_NEXT_SYMBOL (__xmknod);
+#endif
+#ifdef HAVE___XSTAT
GET_NEXT_SYMBOL (__xstat);
+#endif
+#ifdef HAVE___XSTAT64
GET_NEXT_SYMBOL (__xstat64);
+#endif
GET_NEXT_SYMBOL (stat);
#ifdef __GLIBC__
GET_NEXT_SYMBOL (stat64);
@@ -430,6 +442,7 @@ int open64 (const char *pathname, int flags, ...)
}
#endif
+#ifdef HAVE___XMKNOD
int __xmknod (int ver, const char *pathname, mode_t mode, dev_t *dev)
{
if (!libc___xmknod)
@@ -438,7 +451,9 @@ int __xmknod (int ver, const char *pathname, mode_t mode,
dev_t *dev)
clickpreload_assert_path_in_instdir ("mknod", pathname);
return (*libc___xmknod) (ver, pathname, mode, dev);
}
+#endif
+#ifdef HAVE___XSTAT
int __xstat (int ver, const char *pathname, struct stat *buf)
{
if (!libc___xstat)
@@ -449,7 +464,9 @@ int __xstat (int ver, const char *pathname, struct stat
*buf)
return (*libc___xstat) (ver, pathname, buf);
}
+#endif
+#ifdef HAVE___XSTAT64
int __xstat64 (int ver, const char *pathname, struct stat64 *buf)
{
if (!libc___xstat64)
@@ -460,6 +477,7 @@ int __xstat64 (int ver, const char *pathname, struct stat64
*buf)
return (*libc___xstat64) (ver, pathname, buf);
}
+#endif
int stat(const char * pathname, struct stat * buf)
{
--
2.43.0
--- End Message ---
--- Begin Message ---
Source: click
Source-Version: 0.5.2-3
Done: Mike Gabriel <[email protected]>
We believe that the bug you reported is fixed in the latest version of
click, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mike Gabriel <[email protected]> (supplier of updated click package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 13 May 2024 18:21:51 +0200
Source: click
Architecture: source
Version: 0.5.2-3
Distribution: unstable
Urgency: medium
Maintainer: Debian UBports Team <[email protected]>
Changed-By: Mike Gabriel <[email protected]>
Closes: 1067815 1070982
Changes:
click (0.5.2-3) unstable; urgency=medium
.
* debian/watch:
+ Update file for recent GitLab changes of the tags overview page.
* debian/patches:
+ Add 0006_fix-implicit-function-declaration.patch. Make -Werror=implicit-
function-declaration unnecessary.
+ Add 0007_add-support-for-loongarch.patch. Thanks to Ruilong Wu for
providing the patch. Resolve FTBFS on loongarch architecture. (Closes:
#1067815).
* debian/rules:
+ Drop DEB_CFLAGS_MAINT_STRIP = -Werror=implicit-function-declaration.
* debian/{rules,click.install}:
+ Set systemdsystemunitdir to /usr/lib/systemd/system (not
/lib/systemd/system/ anymore).
* Revert "debian/control: Make bin:pkg python3-click-package arch:all."
The python3-click-package module contains:
preload_path = "/usr/lib/<multiarch>/click/libclickpreload.so"
in paths.py and should thus always be arch:any. This should fix
autopkgtest builds on non-amd64 architectures. (Closes: #1070982).
* debian/control:
+ Bump Standards-Version to 4.7.0. No changes needed.
+ Drop B-D python3-six. Patched out in 1015_drop-using-six.patch.
Checksums-Sha1:
b9d6cc85ed625961a1695b57e3c170762ffff5fc 2911 click_0.5.2-3.dsc
bd8ee383db0fc8781fafd6436b78fdf4010812d6 37512 click_0.5.2-3.debian.tar.xz
dc0b2fce83d7021d41ff69d80751c2782d082d95 10347 click_0.5.2-3_source.buildinfo
Checksums-Sha256:
b5c9703bff25e72453a43d6f298537458a415840446e1a8bf439dbc80485deec 2911
click_0.5.2-3.dsc
136de4fff13dc062e77c364a690374b02277f68029a87e91b471d765f87ab98f 37512
click_0.5.2-3.debian.tar.xz
23d8f1455c25befb81aaf369e7733dece630ae6f20c58b150fde4a74cbb94bd2 10347
click_0.5.2-3_source.buildinfo
Files:
9454f6599064f90a01453ccfdcf21988 2911 admin optional click_0.5.2-3.dsc
aacb29db6cff87a7b6fd7267541a2743 37512 admin optional
click_0.5.2-3.debian.tar.xz
18fb2f89ef8a3346301c8f627662c739 10347 admin optional
click_0.5.2-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmZCPvQVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxrIAQAICd4Qp8X6c+2XKNqz3W+0siyYdS
6SEf3F9KkmOzm2cOH1q+CItjgyGcGpv0q8taJ6H59WNXuZVRZPieztRy5l/hpbBR
+PkouuFD9Akggnx3DSBq8ikFnwVyNDF8iDzopFqb7rt6y3Ov7rHLdxYeFzfi6H2S
skhBxm33boKLmaeUZM+bb6+JDZWg6ndJWsAGSLanzoCzCpRPIEYM2NGzdEEfZcdK
iczqR7JW565n4jgnJqjlc9qYfivckneNlGSC3tOQKfdJWMKIAKFNFESRWbFE2qP/
sHwOgetg9xJAHmpGg2pcPXYD30InOylO3BZrAFqVR0PVOBoywGcfJvqszvy+QSKS
cgv8vRNRcOQ0nvvKal7VtWLwgocgGHe46DKw1XKJfAPfZp4rqcOErzhuHs+EJrRi
ec5sSGdROyND1J0Z0D6AfjSXY4hDoIqhWQVgui+O1ExNQ5vIU1GaGht1T96k51z9
0hzrCV2GkDXZNh8R2Vi8R9+iWQ0LlLKYmEPD1cszoEqUQPnI//rKh72l+KDPnlGY
sqjJKaseGfX/AG4lTvauyW3WeWt4bH+JgcsQz133MDnIpxhf3xAQKS8UECfoJX0e
vI3LT7WiNyP2A/dRswU9SxUphByt7RmQqakuClrfRmVrJbeZfIP3STzRklks/+7E
YeTgmIYj6w1zX6Rw
=7Y9x
-----END PGP SIGNATURE-----
pgpjd8JZZVUk6.pgp
Description: PGP signature
--- End Message ---
