Your message dated Tue, 11 Jun 2024 10:04:17 +0000
with message-id <e1sgymt-0043nc...@fasolo.debian.org>
and subject line Bug#1072933: fixed in bfs 3.3.1-2
has caused the Debian Bug report #1072933,
regarding bfs: ftbfs on riscv64 due to unrecognized opcode `pause', extension
`zihintpause' required
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1072933: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072933
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: bfs
Version: 3.3.1-1
Severity: important
Tags: ftbfs, patch
User: debian-ri...@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-ri...@lists.debian.org
Dear Maintainer,
bfs has one ftbfs issue on riscv64:
```
....
[ CC ] src/stat.c
/tmp/ccR1L1lA.s: Assembler messages:
/tmp/ccR1L1lA.s:670: Error: unrecognized opcode `pause', extension
`zihintpause' required
make[1]: *** [Makefile:66: obj/src/sighook.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
...
```
The full buildd log is here:
https://buildd.debian.org/status/fetch.php?pkg=bfs&arch=riscv64&ver=3.3.1-1&stamp=1717488400&raw=0
It seems the gcc(13) does not support `zihintpause` extension by default
unless the extension is enabled in `-march`.
Fortunately upstream has submitted one commit[0] to fix the issue and I
have tested it on my local real riscv64 hardware. Could you apply it on
next upload to fix the issue?
[0]:
https://github.com/tavianator/bfs/commit/e93a1dccd82f831a2f0d2cc382d8af5e1fda55ed
--
Regards,
--
Bo YU
diff -Nru bfs-3.3.1/debian/changelog bfs-3.3.1/debian/changelog
--- bfs-3.3.1/debian/changelog 2024-06-04 15:26:30.000000000 +0800
+++ bfs-3.3.1/debian/changelog 2024-06-10 22:55:31.000000000 +0800
@@ -1,3 +1,10 @@
+bfs (3.3.1-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix ftbfs on riscv64. (Closes: #-1)
+
+ -- Bo YU <tsu.y...@gmail.com> Mon, 10 Jun 2024 22:55:31 +0800
+
bfs (3.3.1-1) unstable; urgency=medium
* New upstream release.
diff -Nru bfs-3.3.1/debian/patches/00-fix-riscv64-ftbfs.patch
bfs-3.3.1/debian/patches/00-fix-riscv64-ftbfs.patch
--- bfs-3.3.1/debian/patches/00-fix-riscv64-ftbfs.patch 1970-01-01
08:00:00.000000000 +0800
+++ bfs-3.3.1/debian/patches/00-fix-riscv64-ftbfs.patch 2024-06-10
22:55:20.000000000 +0800
@@ -0,0 +1,52 @@
+From e93a1dccd82f831a2f0d2cc382d8af5e1fda55ed Mon Sep 17 00:00:00 2001
+From: Tavian Barnes <taviana...@tavianator.com>
+Date: Thu, 6 Jun 2024 10:23:14 -0400
+Subject: [PATCH] atomic: Fix RISC-V build with GCC < 14
+
+Prior to GCC 14.1, the __builtin_riscv_pause() can cause an error if the
+appropriate extension is not enabled in -march:
+
+ /tmp/ccR1L1lA.s: Assembler messages:
+ /tmp/ccR1L1lA.s:670: Error: unrecognized opcode `pause', extension
`zihintpause' required
+
+Link: https://gcc.gnu.org/pipermail/gcc-patches/2023-August/626748.html
+Link:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=c2d04dd659c499d8df19f68d0602ad4c7d7065c2
+Link:
https://buildd.debian.org/status/fetch.php?pkg=bfs&arch=riscv64&ver=3.3.1-1&stamp=1717488400&raw=0
+---
+ build/has/builtin-riscv-pause.c | 7 +++++++
+ build/header.mk | 1 +
+ src/atomic.h | 2 +-
+ 3 files changed, 9 insertions(+), 1 deletion(-)
+ create mode 100644 build/has/builtin-riscv-pause.c
+
+--- /dev/null
++++ b/build/has/builtin-riscv-pause.c
+@@ -0,0 +1,7 @@
++// Copyright © Tavian Barnes <taviana...@tavianator.com>
++// SPDX-License-Identifier: 0BSD
++
++int main(void) {
++ __builtin_riscv_pause();
++ return 0;
++}
+--- a/build/header.mk
++++ b/build/header.mk
+@@ -16,6 +16,7 @@
+ gen/has/acl-is-trivial-np.h \
+ gen/has/acl-trivial.h \
+ gen/has/aligned-alloc.h \
++ gen/has/builtin-riscv-pause.h \
+ gen/has/confstr.h \
+ gen/has/extattr-get-file.h \
+ gen/has/extattr-get-link.h \
+--- a/src/atomic.h
++++ b/src/atomic.h
+@@ -109,7 +109,7 @@
+ # define spin_loop() __builtin_ia32_pause()
+ #elif __has_builtin(__builtin_arm_yield)
+ # define spin_loop() __builtin_arm_yield()
+-#elif __has_builtin(__builtin_riscv_pause)
++#elif BFS_HAS_BUILTIN_RISCV_PAUSE
+ # define spin_loop() __builtin_riscv_pause()
+ #else
+ # define spin_loop() ((void)0)
diff -Nru bfs-3.3.1/debian/patches/series bfs-3.3.1/debian/patches/series
--- bfs-3.3.1/debian/patches/series 1970-01-01 08:00:00.000000000 +0800
+++ bfs-3.3.1/debian/patches/series 2024-06-10 22:54:59.000000000 +0800
@@ -0,0 +1 @@
+00-fix-riscv64-ftbfs.patch
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: bfs
Source-Version: 3.3.1-2
Done: Chris Lamb <la...@debian.org>
We believe that the bug you reported is fixed in the latest version of
bfs, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1072...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <la...@debian.org> (supplier of updated bfs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 11 Jun 2024 10:49:08 +0100
Source: bfs
Architecture: source
Version: 3.3.1-2
Distribution: unstable
Urgency: medium
Maintainer: Chris Lamb <la...@debian.org>
Changed-By: Chris Lamb <la...@debian.org>
Closes: 1072933
Changes:
bfs (3.3.1-2) unstable; urgency=medium
.
* Apply patch from upstream to fix FTBFS on riscv64. (Closes: #1072933)
Checksums-Sha1:
7206dd22a0819455a931c3751c59c8c9f23b9f63 1872 bfs_3.3.1-2.dsc
aef0877e3dda23e195c53cee0a397a9152c6a1b7 5100 bfs_3.3.1-2.debian.tar.xz
43baf1ba14c1a05ef7536c6ed1778f977a3470de 6058 bfs_3.3.1-2_amd64.buildinfo
Checksums-Sha256:
bb39d49c4283d14f8f421ea75a14aaaf3206473ed26e61dd76bc19a13d000e98 1872
bfs_3.3.1-2.dsc
8cda2cad50d91930ccd86ce1cc3bf86ed7f12c12059d6c4bc9ac4434852b3096 5100
bfs_3.3.1-2.debian.tar.xz
f0c1c57f547f91c0f9c8b20a6f777c3fa0ce45dd00dad755dde15ca9d37cd262 6058
bfs_3.3.1-2_amd64.buildinfo
Files:
6e28d7bc7649e0c3f2aed4e3c5afdf52 1872 utils optional bfs_3.3.1-2.dsc
7cfdf9e52645510f406de5e03fcf12db 5100 utils optional bfs_3.3.1-2.debian.tar.xz
73e5f46bb9a25505008db5d4395af2c9 6058 utils optional
bfs_3.3.1-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmZoHqIACgkQHpU+J9Qx
HljdZRAAkqq2260ijf5bcueBzwaT8Kr6OkKHShBUH/wDP75l4b7Acig6HzadOwoO
0PnCoohtU4g6LAPG54nYsxCdGIxSP9NuEPUQo5vPC5NaUxuCo1uqCQSbN6W8mSLz
v4OtPp0O7e0qWnlPECXQwoKQuZWzpJTofOwmZQYEuPe38QsKcztpJP6r7NQURp08
S5uAB/1yNqo8MRHBnm7UVlZRIHkCpRgluHpc+yAr7CrVJsEBmWYkWg7lW7wkVKHZ
uLVZXVt/iKTPDFcOeN3az2GW2gO7CEcSjsmMQiVD1+WpNcDEVGQ8YrlhNVvqMQgj
+sQGwBNu9gLIbPPWifE4I1fYLtQh2u8aT55vMbCCwKItifVBASkJtLlidERMlPSL
LAXFE9ykAVKHgQXDqMM9ur/vMKRTDVGD26IjUbDbcdOFm1o06v3ot2OC+JMOV+J0
XdVX4r/1cS7KKp6iLO38T/5xOFiVFSAXLmw/3GyFYLOeqC4GTKmpb40GCf5X33EI
7AtQhok9PqkOmWRcbSRp4n3mTxCj7BG5o7947mWFibpOFw3IEPqxYhOEWaXgqUIG
xitZ8g7qWqpCI82byLGrGNVfGIA+hiHsDe4N65yIZ+cIDCnbbBt61+HGrVN4Jr41
EVskDpk7l9+qK33544h01KeR27aKuy46jpo8JVjDc4sOxurMbNI=
=vGXa
-----END PGP SIGNATURE-----
pgpTbJ1t94Ai6.pgp
Description: PGP signature
--- End Message ---
