Your message dated Tue, 25 Jun 2024 15:28:09 +0000
with message-id <[email protected]>
and subject line Bug#1074116: fixed in mshr
2019.2.0~git20230811.ff54a68+dfsg1-2exp1
has caused the Debian Bug report #1074116,
regarding mshr: FTBFS with CGAL 6.0
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1074116: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1074116
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mshr
Version: 2019.2.0~git20200924.c27eb18+dfsg1-7
Severity: normal
Tags: ftbfs
X-Debbugs-Cc: [email protected]
Dear maintainer,
your package fails to build with cgal 6.0~beta1-1, which has recently been
uploaded to experimental. See [1] for the release notes with breaking changes.
[1] https://github.com/CGAL/cgal/releases/tag/v6.0-beta1
Some issues can be fixed just by requiring C++17 (see attached patch). I did
not investigate what is required to adapt to the changes related to
boost::optional/variant.
Best regards,
Joachim
Index: mshr-2019.2.0~git20230811.ff54a68+dfsg1/CMakeLists.txt
===================================================================
--- mshr-2019.2.0~git20230811.ff54a68+dfsg1.orig/CMakeLists.txt
+++ mshr-2019.2.0~git20230811.ff54a68+dfsg1/CMakeLists.txt
@@ -14,7 +14,7 @@ endif()
# CGAL setup
option(USE_SYSTEM_CGAL "Do not build CGAL, but use an existing build instead."
OFF)
if (USE_SYSTEM_CGAL)
- find_package(CGAL 5 CONFIG REQUIRED)
+ find_package(CGAL 6 CONFIG REQUIRED)
endif()
# Borrow some cmake modules from cgal
@@ -43,8 +43,8 @@ MACRO(LIST_CONTAINS var value)
ENDFOREACH (value2)
ENDMACRO(LIST_CONTAINS)
-# Use C++14 to support std:enable_if used by CGAL 5
-set(CMAKE_CXX_STANDARD 14)
+# Use C++17 as required by CGAL 6
+set(CMAKE_CXX_STANDARD 17)
# Boost
# This is workaround to avoid that find_package(Boost)
@@ -161,7 +161,7 @@ target_link_libraries( mshr
)
# CMAKE_CXX_STANDARD is ignored ;( Need to set standard manually here.
-set_property(TARGET mshr PROPERTY CXX_STANDARD 14)
+set_property(TARGET mshr PROPERTY CXX_STANDARD 17)
# install library
install(TARGETS mshr
@@ -181,7 +181,7 @@ if (ENABLE_MSHRABLE)
)
# CMAKE_CXX_STANDARD is ignored ;( Need to set standard manually here.
-set_property(TARGET mshrable PROPERTY CXX_STANDARD 14)
+set_property(TARGET mshrable PROPERTY CXX_STANDARD 17)
# install app
install(TARGETS mshrable
Index: mshr-2019.2.0~git20230811.ff54a68+dfsg1/python/setup.py
===================================================================
--- mshr-2019.2.0~git20230811.ff54a68+dfsg1.orig/python/setup.py
+++ mshr-2019.2.0~git20230811.ff54a68+dfsg1/python/setup.py
@@ -36,8 +36,8 @@ mshr_ext = Extension('mshr.cpp',
include_dirs=include_dirs,
library_dirs=config['mshr']['lib_dirs'].split(";"),
libraries=config['mshr']['libs'].split(";"),
- extra_compile_args=['-std=c++14'],
- language='c++14')
+ extra_compile_args=['-std=c++17'],
+ language='c++17')
setup(name = 'mshr',
--- End Message ---
--- Begin Message ---
Source: mshr
Source-Version: 2019.2.0~git20230811.ff54a68+dfsg1-2exp1
Done: Francesco Ballarin <[email protected]>
We believe that the bug you reported is fixed in the latest version of
mshr, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Francesco Ballarin <[email protected]> (supplier of updated mshr
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 25 Jun 2024 12:40:24 +0000
Source: mshr
Architecture: source
Version: 2019.2.0~git20230811.ff54a68+dfsg1-2exp1
Distribution: experimental
Urgency: medium
Maintainer: Debian Science Team
<[email protected]>
Changed-By: Francesco Ballarin <[email protected]>
Closes: 1074116
Changes:
mshr (2019.2.0~git20230811.ff54a68+dfsg1-2exp1) experimental; urgency=medium
.
* Add Francesco Ballarin to uploaders
* Add patch CGAL_6_compatibility.diff for compatibility with CGAL 6:
- bump minum required CGAL version to 6 in cmake
- require C++17 standard in cmake
- replace boost::get and assignment to a local variable with CGAL::assign
Closes: #1074116
* Build-Depends on libcgal-dev >= 6.0~
Checksums-Sha1:
11920a08a208198fa112f4842124f7b153ec86e5 3106
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1.dsc
11fec0f895d37f5baabf025b7e07573f8bfb4b55 14104
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1.debian.tar.xz
d5b07daf43056598940d41531ca01d832a6548a4 17076
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1_source.buildinfo
Checksums-Sha256:
cdf1618596a1fb7fb8bc220a03c98de6746b4df025d2985406df2da5dc4abf54 3106
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1.dsc
a2e58279eed15b3a1f6046b41018c7abe47614310f66283eb2542ab530b849c4 14104
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1.debian.tar.xz
892964efdc0270c8252b07a9897295f231c179f05c431740695db4786a920155 17076
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1_source.buildinfo
Files:
3efd393066d0a2bc903087d23292717f 3106 math optional
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1.dsc
307051cc1e688b0138752fe02e2446d9 14104 math optional
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1.debian.tar.xz
ad1d33a0fbe2cf7de93410ae7510d963 17076 math optional
mshr_2019.2.0~git20230811.ff54a68+dfsg1-2exp1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEG10EseUHu/A2aeK4AfNfwz5zr4wFAmZ6yJYACgkQAfNfwz5z
r4zNKQ/9FggpQp/zZI+ay+bf7tPsIr4gyTvBVmkjpgmqBvYgzagprfxGCtxbuNs+
XrHbdib47cLRN8yZsyPUNH2K+cTJ27BOBhNffGWuPBj4sseN8XTnsAQ1qr4Kkfka
WrXjpCodhYozj4UWa0dkeXnLfeOYOUaW9ekVbw3XfAhqEMjCCrAOQkkEjIx7V/it
lQ2K87hKn8Ru3WUX2yLv+O3ErvDTEr8FkSRqa1QpkvxjPizuooUlK46iPQ6wTBzQ
dU18i8YitjISGpvYlSiI9HKnEf8/ICnB60Qi/aw/v4i3DkKg0vQrCNlfx+8q2Ira
9NzrJqXZbg7Z6ccUNtgEyKhHQTbW6zC6ITRWaTMievSgHwTz9v6Z3UzMrbiR9Ksv
EApmpJa6mqiq7nwEXVI/oKjVeXBYR5VYSup5YMkqMvWBfUT8FwvSu0IjT/U60+Ie
H4Wd1t6MTtUm3uDONuWelemi5LqTsL6W4c/ikeve0Oz0ORKuY8jWpbL/nnlkMBvU
1gAn59AY2r1MBxKVKwoBlv3kQBpLWU8psfDRBowd/DuWBZ/IQXBMg0pFYBGZGV1N
7CMsnfw0LLGm+sdmeRrnRN/wRStRaVcz+lJu9vGtL1lAjiaap9cLHIq22bUyWGmx
k9IZ7qMbZ4zsQ4iAFxXyntaJeZ+EJskDEqdiAaF/tA2oFQITfyQ=
=A3pg
-----END PGP SIGNATURE-----
pgpJvgNVBemmr.pgp
Description: PGP signature
--- End Message ---
