Your message dated Wed, 10 Jul 2024 05:18:55 +0000 with message-id <e1srpjd-00dpoy...@fasolo.debian.org> and subject line Bug#1051567: fixed in cubicsdr 0.2.7+dfsg-4 has caused the Debian Bug report #1051567, regarding cubicsdr: FTBFS with RtAudio 6 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1051567: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051567 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: cubicsdr Version: 0.2.7+dfsg-2 Severity: important Tags: ftbfs patch Dear Maintainer, cubicsdr ftbfs with RtAudio6 (currently found in experimental) ``` /<<PKGBUILDDIR>>/src/audio/AudioThread.cpp: In member function ‘void AudioThread::setupDevice(int)’: /<<PKGBUILDDIR>>/src/audio/AudioThread.cpp:435:12: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’? 435 | catch (RtAudioError& e) { | ^~~~~~~~~~~~ | RtAudioErrorType /<<PKGBUILDDIR>>/src/audio/AudioThread.cpp:436:9: error: ‘e’ was not declared in this scope 436 | e.printMessage(); | ^ /<<PKGBUILDDIR>>/src/audio/AudioThread.cpp: In member function ‘virtual void AudioThread::run()’: /<<PKGBUILDDIR>>/src/audio/AudioThread.cpp:539:16: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’? 539 | catch (RtAudioError& e) { | ^~~~~~~~~~~~ | RtAudioErrorType /<<PKGBUILDDIR>>/src/audio/AudioThread.cpp:540:13: error: ‘e’ was not declared in this scope 540 | e.printMessage(); | ^ make[3]: *** [CMakeFiles/CubicSDR.dir/build.make:485: CMakeFiles/CubicSDR.dir/src/audio/AudioThread.cpp.o] Error 1 make[3]: *** Waiting for unfinished jobs.... ``` Attached you find a patch that fixes the FTBFS (but is otherwise untested, so use with care). No debdiff this time, sorry cheersDescription: Fix FTBFS with RtAudio 6 Replace try/catch with checking for return codes Author: IOhannes m zmölnig Origin: Debian Forwarded: no Last-Update: 2023-09-09 --- This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ Index: cubicsdr-0.2.7+dfsg/src/audio/AudioThread.cpp =================================================================== --- cubicsdr-0.2.7+dfsg.orig/src/audio/AudioThread.cpp +++ cubicsdr-0.2.7+dfsg/src/audio/AudioThread.cpp @@ -7,6 +7,7 @@ #include "CubicSDR.h" #include "DemodulatorInstance.h" #include <mutex> +#include <iostream> //50 ms #define HEARTBEAT_CHECK_PERIOD_MICROS (50 * 1000) @@ -378,7 +379,6 @@ void AudioThread::setupDevice(int device opts.streamName = "CubicSDR Audio Output"; - try { if (deviceController.find(outputDevice.load()) != deviceController.end()) { //'this' is not the controller, so remove it from the bounded list: //beware, we must take the controller mutex, because the audio callback may use the list of bounded @@ -418,8 +418,14 @@ void AudioThread::setupDevice(int device else if (deviceController[parameters.deviceId] == this) { //Attach callback - dac.openStream(¶meters, nullptr, RTAUDIO_FLOAT32, sampleRate, &nBufferFrames, &audioCallback, (void *)this, &opts); - dac.startStream(); + if(dac.openStream(¶meters, nullptr, RTAUDIO_FLOAT32, sampleRate, &nBufferFrames, &audioCallback, (void *)this, &opts)) { + std::cerr << dac.getErrorText() << std::endl; + return; + } + if(dac.startStream()) { + std::cerr << dac.getErrorText() << std::endl; + return; + } } else { //we are a bound thread, add ourselves to the controller deviceController[parameters.deviceId]. @@ -431,11 +437,6 @@ void AudioThread::setupDevice(int device } active = true; - } - catch (RtAudioError& e) { - e.printMessage(); - return; - } if (deviceId != -1) { outputDevice = deviceId; } @@ -530,15 +531,12 @@ void AudioThread::run() { } else { // 'this' is a controller thread: - try { if (dac.isStreamOpen()) { - dac.stopStream(); + if(dac.stopStream()) { + std::cerr << dac.getErrorText() << std::endl; + } } dac.closeStream(); - } - catch (RtAudioError& e) { - e.printMessage(); - } } // std::cout << "Audio thread done." << std::endl;
--- End Message ---
--- Begin Message ---Source: cubicsdr Source-Version: 0.2.7+dfsg-4 Done: tony mancill <tmanc...@debian.org> We believe that the bug you reported is fixed in the latest version of cubicsdr, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1051...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. tony mancill <tmanc...@debian.org> (supplier of updated cubicsdr package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 09 Jul 2024 21:47:37 -0700 Source: cubicsdr Architecture: source Version: 0.2.7+dfsg-4 Distribution: unstable Urgency: medium Maintainer: Debian Hamradio Maintainers <debian-h...@lists.debian.org> Changed-By: tony mancill <tmanc...@debian.org> Closes: 1051567 Changes: cubicsdr (0.2.7+dfsg-4) unstable; urgency=medium . * Team upload. * Fix FTBFS with RtAudio 6 (Closes: #1051567) Thank you to IOhannes m zmoelnig for the patch. Checksums-Sha1: 336babd5b7879fa3bbe1a9455ab6c9b9f1f8dd03 2158 cubicsdr_0.2.7+dfsg-4.dsc a8e42fe9f76e0b02eb352ce82f705293d4e7c8b9 13332 cubicsdr_0.2.7+dfsg-4.debian.tar.xz eaab62661c35311b0a58af4ab57719e8b4b260b1 13386 cubicsdr_0.2.7+dfsg-4_amd64.buildinfo Checksums-Sha256: c61c86a34061494c736c68ee2bc64e8725ca64dbd078e7e558bda72b5aca042f 2158 cubicsdr_0.2.7+dfsg-4.dsc 3135d5f783cd7c7cc086018b80154fb0b6aca42056b72e84ff272b78b13c3363 13332 cubicsdr_0.2.7+dfsg-4.debian.tar.xz fd6647a23863e4bc74cdd31950a386e0ee43af4b7bfe2dbdb2a502290261b9bb 13386 cubicsdr_0.2.7+dfsg-4_amd64.buildinfo Files: 0b413c0384d072be58319bcd0fe039ff 2158 hamradio optional cubicsdr_0.2.7+dfsg-4.dsc ee5741e824a2fc51c16874e8748d1f95 13332 hamradio optional cubicsdr_0.2.7+dfsg-4.debian.tar.xz 3b3bfe15d195d9adff7ea571a1526b9c 13386 hamradio optional cubicsdr_0.2.7+dfsg-4_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmaOFh4UHHRtYW5jaWxs QGRlYmlhbi5vcmcACgkQIdIFiZdLPpbGGg/9FYS3vXpkIfrjHWzuduzKdDpHNt8N Fpq6qMgLg4AfC8iUu+CbXLA/SuriMBmK0LA6eLZvPPDm+k7l6EmtPi9vUS++MJE3 PlnkhjvD2blquW1qeDNGaA0/R0Ee+0hTYWgMAl2xgtblTGbNYZxcx7akdzlCU0H4 QQL3I2DOYJSIa74NQzZqjJFpX3E50bgnZ8ufnRzxr8h/zBgZuACBk8X3Ua/nYAgr p7vir2Io31ICe+Gvn/AfplGI/DxEizaDQp2lGP6h1WPujAg3RXXeiHcruguIIBjl NAOgD57DVE7sx0w6AkR29ZgeO6A54nqo4zLF/GcJJI9pZyNRW54Jo0+er7e2oVXQ UCZZBDoXwQSKlIB441YMco+uEki8Y6sVkdmonh7ZpRsq73EhQ0CmoCQcTwxXpDKP z+bxxtxDHVgYq+gLxMvNLrXuv5FKfbDwd7IyTqjTsIoY3fS6VhYuKcu/OJDgGiMO azwQgcE90wVb+ucuquDFMLq1fv0dlAYgsiAxvDQ7r6lJAAV5FtjE0HqlcEoygfLb jPtA/YbI9KFdToKT1wHtaRRaXoXhR4itmBxvqi24v9Dr3ferpudazOSusRFZZtC/ VFW0VtNHmIzs/ODIfYJkpwML+ie9wJb4TfhN/oIwFgNIzZbuJ/90Pp7W7E7kFY45 cEYq7nl/YeK1GVc= =sAL1 -----END PGP SIGNATURE-----
pgpf8GUSYJdW9.pgp
Description: PGP signature
--- End Message ---
