Your message dated Wed, 31 Jul 2024 09:34:24 +0000
with message-id <[email protected]>
and subject line Bug#1013257: fixed in libxsmm 1.17-4
has caused the Debian Bug report #1013257,
regarding libxsmm: please make the build (partly) reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1013257: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1013257
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libxsmm
Version: 1.17-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
libxsmm could not be built reproducibly.

This is because it ships a build.txt with an absolute build path and
uses the current date in some headers files. These are fixed in the
attached patch.

However, the ABSDIR (also in build.txt) is embedded in in the libxsmm.a
library in an ELF text header.


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-
--- a/debian/patches/0003-Reproducible-build.patch      1970-01-01 
01:00:00.000000000 +0100
--- b/debian/patches/0003-Reproducible-build.patch      2022-06-20 
09:01:20.106293806 +0100
@@ -0,0 +1,39 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2022-06-20
+
+--- libxsmm-1.17.orig/scripts/libxsmm_config.py
++++ libxsmm-1.17/scripts/libxsmm_config.py
+@@ -10,9 +10,11 @@
+ # Hans Pabst (Intel Corp.)
+ 
###############################################################################
+ from string import Template
+-from datetime import date
++import datetime
+ import libxsmm_utilities
+ import fnmatch
++import os
++import time
+ import sys
+ 
+ 
+@@ -87,6 +89,10 @@ if __name__ == "__main__":
+         maxn = libxsmm_utilities.max_mnk(mnklist, avgdim, 1)
+         maxk = libxsmm_utilities.max_mnk(mnklist, avgdim, 2)
+ 
++        build_date = datetime.datetime.utcfromtimestamp(
++            int(os.environ.get('SOURCE_DATE_EPOCH', time.time()))
++        )
++
+         substitute = {
+             "VERSION": realversion,
+             "BRANCH": branch,
+@@ -94,7 +100,7 @@ if __name__ == "__main__":
+             "MINOR": minor,
+             "UPDATE": update,
+             "PATCH": patch,
+-            "DATE": date.today().strftime("%Y%m%d"),
++            "DATE": build_date.strftime("%Y%m%d"),
+             "CACHELINE": cacheline,
+             "PREFETCH": [-1, prefetch][0 <= prefetch],
+             "MAX_MNK": maxmnk,
--- a/debian/patches/series     2022-06-20 08:24:21.976388516 +0100
--- b/debian/patches/series     2022-06-20 08:46:51.618995900 +0100
@@ -1,2 +1,3 @@
 0001-Makefile-rebuild-fix.patch
 0002-Makefile-fix-pkgconfigdir.patch
+0003-Reproducible-build.patch
--- a/debian/rules      2022-06-20 08:24:21.976388516 +0100
--- b/debian/rules      2022-06-20 08:49:26.476766896 +0100
@@ -16,6 +16,8 @@
        # Do not include docs in /usr/share/libxsmm
        rm -f debian/*/usr/share/libxsmm/*.md
        rm -f debian/*/usr/share/libxsmm/*.pdf
+       # Do not include build.txt
+       rm -f ./debian/*/usr/share/libxsmm/build.txt
 
 execute_after_dh_installdocs:
        # Do not install broken symlinks
--- a/scripts/libxsmm_config.py 2022-06-20 08:24:21.984388483 +0100
--- b/scripts/libxsmm_config.py 2022-06-20 09:01:29.846352447 +0100
@@ -10,9 +10,11 @@
 # Hans Pabst (Intel Corp.)
 ###############################################################################
 from string import Template
-from datetime import date
+import datetime
 import libxsmm_utilities
 import fnmatch
+import os
+import time
 import sys
 
 
@@ -87,6 +89,10 @@
         maxn = libxsmm_utilities.max_mnk(mnklist, avgdim, 1)
         maxk = libxsmm_utilities.max_mnk(mnklist, avgdim, 2)
 
+        build_date = datetime.datetime.utcfromtimestamp(
+            int(os.environ.get('SOURCE_DATE_EPOCH', time.time()))
+        )
+
         substitute = {
             "VERSION": realversion,
             "BRANCH": branch,
@@ -94,7 +100,7 @@
             "MINOR": minor,
             "UPDATE": update,
             "PATCH": patch,
-            "DATE": date.today().strftime("%Y%m%d"),
+            "DATE": build_date.strftime("%Y%m%d"),
             "CACHELINE": cacheline,
             "PREFETCH": [-1, prefetch][0 <= prefetch],
             "MAX_MNK": maxmnk,

--- End Message ---
--- Begin Message ---
Source: libxsmm
Source-Version: 1.17-4
Done: Mattia Rizzolo <[email protected]>

We believe that the bug you reported is fixed in the latest version of
libxsmm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mattia Rizzolo <[email protected]> (supplier of updated libxsmm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 31 Jul 2024 17:47:36 +0900
Source: libxsmm
Architecture: source
Version: 1.17-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<[email protected]>
Changed-By: Mattia Rizzolo <[email protected]>
Closes: 1013257
Changes:
 libxsmm (1.17-4) unstable; urgency=medium
 .
   * Team upload.
   * Bump Standards-Version to 4.7.0, no changes needed
   * Add patch to make the build reproducible.
     Thanks to Chris Lamb for the patch (Closes: #1013257)
   * Set R³:no.
Checksums-Sha1:
 504b485a9e882b925914e1f0f7df234e629921ef 1984 libxsmm_1.17-4.dsc
 d68e7638d585904c24969e625d60870637766ca6 5120 libxsmm_1.17-4.debian.tar.xz
 c4465e6851a011632200e9ce4150296b6532c27e 6928 libxsmm_1.17-4_amd64.buildinfo
Checksums-Sha256:
 9282ba833679d52d703ef2d26d02e4b6ff8bb11656211a38a6909aed1be4097a 1984 
libxsmm_1.17-4.dsc
 84e636704842f6b50a22e98f6032092eaca291a3139dac54a949f3a92bceb748 5120 
libxsmm_1.17-4.debian.tar.xz
 412bb4d6c82194471ba1a32e35d97f8c9a7bfda519291db8f3d3af615e6044f0 6928 
libxsmm_1.17-4_amd64.buildinfo
Files:
 cb1aec21f5293564dbca27241757cb9e 1984 libs optional libxsmm_1.17-4.dsc
 dcef06214ae339bffdb430d6bdf1897c 5120 libs optional 
libxsmm_1.17-4.debian.tar.xz
 7249f890b406077529f46ea041b10a34 6928 libs optional 
libxsmm_1.17-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAmap/oUACgkQCBa54Yx2
K62ZkQ//ZeHAMBcibBDBA9IlKKsXngqNTg8zkfJNoGCf3IxtceCHSg+2e3ff4YfJ
EeYuJPFokYYZiDHzjUPSnLvdUfF2rzyq0jQsNNK16rJgVL3cKU1ZMmZJFFMIJiMR
YCOLmnVNcWG9CROc3Yn8yGZSk9lds81l2d1uZtI4KOqUfGP86wm8Za5ghnnkPMBt
zB4akJ5WgGN+ySs58EHjz38JazLd9WafPzEp1k717NAp//vcYvG0N9NOCvnAs2OB
ssKRrqxTHC0HvhgULgOpc5l4pDwM7XLXSI1/tewWE1MPvM+TK/1GW+wzGKZIUxz8
GJrjy9+l4bVabrsXWWR6oG/3xZmttx/wvKerOMcO5tF30vFzeaW3znWJly/dzAYf
XX/AxmgnKX/uBhX9HlRRMJ/8gpLR7JbUTA5Ps05rrDozQ9jcMRdyKd8YWdVXeRri
hU14LeX53tktlSRvu1MssbUwo5i2c32EANbhRD4pX4hu6J6owoj5H3IuCDOmHrwU
HFayU76uv3in3oX3uK1Gf1CSkCM7CZEzol2RohyoTwsHGJtVxYzrsWCrc/R3ZWyR
cwKTffTG1J2kufnWQNpA7kerCFw8Co0/wWaSIfbK8T2WbqZw8IRyiVPLbJOWlUR8
Susl/hpwG+V58bJbK6KcgubgMJb33w52pge4SlstiZndJAfLfP4=
=jzW4
-----END PGP SIGNATURE-----

Attachment: pgp2lwmpKCa_7.pgp
Description: PGP signature


--- End Message ---

Reply via email to