Your message dated Mon, 05 Aug 2024 13:08:52 +0100
with message-id <[email protected]>
and subject line Re: Bug#970278: smartlist: please make the build reproducible
has caused the Debian Bug report #970278,
regarding smartlist: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
970278: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970278
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: smartlist
Version: 3.15-25
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: environment
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
smartlist could not be built reproducibly.
This is because the choplist binary contains the current user via the
LISTID define. Given that has been the build user's username for many
years (?), I suspect it makes no difference what value this actually
has, but patch attached that sets it to "list" (ie. to match the name
of uid 38).
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build 1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build 2020-09-14 10:51:03.215780208 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <[email protected]>
+Last-Update: 2020-09-14
+
+--- smartlist-3.15.orig/SmartList/install.sh2
++++ smartlist-3.15/SmartList/install.sh2
+@@ -26,7 +26,7 @@ hfile=targetdir.h
+
+ cat >$hfile <<HERE
+ #define TARGETDIR "$ltarget"
+-#define LISTID "$listid"
++#define LISTID "list"
+ #define PROCMAIL "../$bindir/procmail"
+ #define INIT_PATH "PATH=../$bindir"
+ HERE
--- a/debian/patches/series 2020-09-14 10:40:33.562733323 +0100
--- b/debian/patches/series 2020-09-14 10:51:02.215766362 +0100
@@ -31,3 +31,4 @@
smartlist-20
smartlist-21
smartlist-22
+reproducible-build
--- End Message ---
--- Begin Message ---
Chris Lamb wrote:
>> I don't think I will be able to test this theory without some help
>> to reproduce the problem, everything I need is to know what variable
>> variation is the one making the build to be different.
>
> ACK this. I will look at this new version once it's picked up by our
> automated testing framework.
Despite neither of us making any conscious change to bring this about,
smartlist looks reproducible now, so I'm happy to close this bug.
(Indeed, doing so via [email protected].)
Thanks for bringing this bug back to my attention.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] 🍥 chris-lamb.co.uk
`-
--- End Message ---
