Your message dated Mon, 26 Aug 2024 18:49:00 +0000
with message-id <[email protected]>
and subject line Bug#1079701: fixed in dbus-fast 2.23.0-2
has caused the Debian Bug report #1079701,
regarding dbus-fast: Please don't build-depend on dbus-x11
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1079701: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1079701
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: dbus-fast
Version: 2.23.0-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: dbus-launch dbus-launch-for-tests
dbus-fast relies on dbus-launch (dbus-x11) to run its test suite,
but it doesn't need to: dbus-daemon is sufficient. Please consider the
attached patch, which avoids pulling in X11 libraries and various bits
of historical backwards-compatibility glue around X11 autolaunching.
See also <https://lists.debian.org/debian-devel/2016/08/msg00554.html>,
a mass bug filing in 2016.
The autopkgtests still pass with the attached patch (tested in qemu, lxc,
podman) and according to diffoscope, the resulting binaries are identical.
Thanks,
smcv
>From e91932b938cc93af7ba13c74a813071e9582abf5 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Mon, 26 Aug 2024 15:27:32 +0100
Subject: [PATCH] Use dbus-run-session for tests in preference to dbus-launch
This avoids relying on X11 autolaunch mechanisms that have never been
completely reliable, and also avoids pulling in backwards-compatibility
code in /etc/X11/Xsession.d.
Closes: #-1
---
debian/control | 2 +-
debian/rules | 2 +-
debian/tests/control | 2 +-
debian/tests/run-tests | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/debian/control b/debian/control
index 9c4052d..2dc30a4 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,7 @@ Section: python
Priority: optional
Build-Depends:
cython3 (>= 3.0.5),
- dbus-x11 <!nocheck>,
+ dbus-daemon <!nocheck>,
debhelper-compat (= 13),
dh-sequence-python3,
dh-sequence-sphinxdoc,
diff --git a/debian/rules b/debian/rules
index 84a1c57..78bd022 100755
--- a/debian/rules
+++ b/debian/rules
@@ -19,7 +19,7 @@ override_dh_auto_clean:
rm -rf dbus_fast.egg-info/ src/dbus_fast/*.c src/dbus_fast/*/*.c docs/_build setup.py
override_dh_auto_test:
- xvfb-run -a dbus-launch --exit-with-session dh_auto_test --no-parallel
+ xvfb-run -a dbus-run-session -- dh_auto_test --no-parallel
override_dh_auto_build:
dh_auto_build $@ --buildsystem=pybuild
diff --git a/debian/tests/control b/debian/tests/control
index 9b66c72..c6c318d 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,6 +1,6 @@
Tests: run-tests
Depends:
- dbus-x11,
+ dbus-daemon,
python3-all,
python3-poetry-core,
python3-pytest,
diff --git a/debian/tests/run-tests b/debian/tests/run-tests
index fd62616..e8087a6 100755
--- a/debian/tests/run-tests
+++ b/debian/tests/run-tests
@@ -2,5 +2,5 @@
set -e
cp -r test* "$AUTOPKGTEST_TMP/" && cd "$AUTOPKGTEST_TMP"
for py in $(py3versions -s); do
- xvfb-run -a dbus-launch --exit-with-session $py -Wd -m pytest -v -x -k "not test_tcp_connection_with_forwarding and not test_glib_properties and not test_sending_signals_between_buses" --no-cov 2>&1
+ xvfb-run -a dbus-run-session -- $py -Wd -m pytest -v -x -k "not test_tcp_connection_with_forwarding and not test_glib_properties and not test_sending_signals_between_buses" --no-cov 2>&1
done
--
2.45.2
--- End Message ---
--- Begin Message ---
Source: dbus-fast
Source-Version: 2.23.0-2
Done: Edward Betts <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dbus-fast, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Edward Betts <[email protected]> (supplier of updated dbus-fast package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 26 Aug 2024 17:06:16 +0100
Source: dbus-fast
Architecture: source
Version: 2.23.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team <[email protected]>
Changed-By: Edward Betts <[email protected]>
Closes: 1079701
Changes:
dbus-fast (2.23.0-2) unstable; urgency=medium
.
* Switch build-depends from dbus-x11 to dbus. Thanks to Simon McVittie for
the patch. (Closes: #1079701)
* No need to skip any tests now.
Checksums-Sha1:
59131d2acd7023db43e4b4f5bfdbe42ce422aa17 2528 dbus-fast_2.23.0-2.dsc
5c273a5445974f42866eb64434db4847718e1adb 4376 dbus-fast_2.23.0-2.debian.tar.xz
65cbf17833184334ebb93d3971b468414c93bb52 12478
dbus-fast_2.23.0-2_source.buildinfo
Checksums-Sha256:
911bb08e072501db25ab25fc5348c937e0fd80cd6101a2203100bd6941c01028 2528
dbus-fast_2.23.0-2.dsc
469732a44e19965259510d088789fcab3e66526d03891fc52f4dbe948ec271f0 4376
dbus-fast_2.23.0-2.debian.tar.xz
749f7818200ab2707670a166cb45929d1b62f4851c558cc6c504a55fd7b0d792 12478
dbus-fast_2.23.0-2_source.buildinfo
Files:
5b5c9735c05fd97ab911d6fd1198050f 2528 python optional dbus-fast_2.23.0-2.dsc
93ca586a572b389a41e82f5397b21879 4376 python optional
dbus-fast_2.23.0-2.debian.tar.xz
a6752e033e523d3519a2def9aac731df 12478 python optional
dbus-fast_2.23.0-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE+4rPp4xyYInDitAmlgWhCYxjuSoFAmbMx38ACgkQlgWhCYxj
uSrn5Q/9Hs1SLr1NmMATpTf8LnL9BrI8VY5c32bS2byB+i7O1Z7WEt5hoaZmx54i
UGX8yi35B2GfpT4MfUcYP3ATAS7A3zuAU/r15qsN+vJomfaUtIVERDYNlgnYSxXE
IqnBLE5o9ZurU7Ip39OqaWtUotNtk7awgI0E2lbuTVJAHbe0TUmJNaDmSvcyVPVF
Buc9UtpgltBH8TYGJFRJJVEZPlHLKPogUjg9nMkjMGuZChSHwgOSxAx+hFpEUlFD
VyDBrSwt2CAa7NGreEuu5S8q+l7/p3q235W5+AJvbUC+FMx/z53b04OD1lYqmvvd
xv8q8TTQ8YeOLy7Ft/O4oZ89DQprrEh7OAqdsOF3ffBSDp6zwhfHjgRb55RXvlYd
YY2UukOnOUhUedozgBghp8BF4PsYrA251ocqZciIPxp2dlKGTN1eky/OivX4fCEA
MOTFIsVbFfWPFUvsshqev06kBYnwIivgzZAB5aX0aJEYihrO/pUtIkpcYYceFOhh
j98QZEB1fDt430Fyz/Es4EPC3bRpajtMHooaPJEQ3ApLwD5ffsVBMTg9WJBdSY5s
+shJBxN5jeJlbY5lndo7KtITFawDMb4RG8wYvaZC9mjQMYwytesDYh8XwIKQCeNC
ipbqrh8N3gLhEGViZHVx6SBAC4rrBbYS7vOyg+yBgqGnaOkKP48=
=+E4o
-----END PGP SIGNATURE-----
pgp1U44HpzZEG.pgp
Description: PGP signature
--- End Message ---
