Your message dated Fri, 04 Oct 2024 17:05:08 +0000
with message-id <e1swljo-000ou0...@fasolo.debian.org>
and subject line Bug#1079204: fixed in gap-guava 3.19+ds-3
has caused the Debian Bug report #1079204,
regarding gap-guava: Uninitialized array can cause random failures
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1079204: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1079204
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: gap-guava
Version: 3.19+ds-2
Severity: normal
Tags: patch
X-Debbugs-Cc: scho...@ubuntu.com
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oracular ubuntu-patch
Hi,
FYI we've patched the Ubuntu package to fix an uninitialized array for
the `comment` variable that can make the autopkgtests fail, depending on
the state of the stack. It turns out that it doesn't fail on Debian CI,
presumably because we're not using the same default compile flags in
Ubuntu, resulting in changes of the stack layout.
It has been reported upstream, but I'm also leaving it here in case it
starts to fail before they release a new version upstream with the fix.
Cheers,
Simon
-- System Information:
Debian Release: trixie/sid
APT prefers noble-updates
APT policy: (500, 'noble-updates'), (500, 'noble-security'), (500, 'noble'),
(100, 'noble-proposed'), (100, 'noble-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.8.0-40-generic (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER, TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru
gap-guava-3.19+ds/debian/patches/0001-desauto-initialize-the-comment-array-to-a-sensible-v.patch
gap-guava-3.19+ds/debian/patches/0001-desauto-initialize-the-comment-array-to-a-sensible-v.patch
---
gap-guava-3.19+ds/debian/patches/0001-desauto-initialize-the-comment-array-to-a-sensible-v.patch
1970-01-01 01:00:00.000000000 +0100
+++
gap-guava-3.19+ds/debian/patches/0001-desauto-initialize-the-comment-array-to-a-sensible-v.patch
2024-08-21 12:58:45.000000000 +0200
@@ -0,0 +1,44 @@
+From 3d6cdfdaed734159a7fa3d272a3b2ba6f74df4b6 Mon Sep 17 00:00:00 2001
+From: Simon Chopin <simon.cho...@canonical.com>
+Date: Wed, 21 Aug 2024 10:42:56 +0000
+Subject: [PATCH] desauto: initialize the comment array to a sensible value
+
+If left uninitialized, the comment array is passed down to client code
+without being even written to, which means it contains whatever happens
+to be on the stack whenever the frame for `main` is created. Recent
+changes to glibc start code have changed said content, and the new one
+happens to break the test suite when propagated into some temporary
+files that are then fed to the main leonconv binary.
+
+That explains why using ThreadSanitizer "fixes" the test suite:
+presumably, the runtime initialization code happens to write in that
+aread of the stack and changes yet again the contents of the comment
+array, which happens to suit whatever expectations are in leonconv.
+
+Fixes #98
+
+Bug: https://github.com/gap-packages/guava/issues/98
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/2077414
+Forwarded: yes, https://github.com/gap-packages/guava/pull/99
+---
+ src/leon/src/desauto.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/leon/src/desauto.c b/src/leon/src/desauto.c
+index 13c7a80..d4efae3 100644
+--- a/src/leon/src/desauto.c
++++ b/src/leon/src/desauto.c
+@@ -202,7 +202,7 @@ int main( int argc, char *argv[])
+ char tempArg[8];
+ enum { DESIGN_AUTO, DESIGN_ISO, MATRIX_AUTO, MATRIX_ISO, CODE_AUTO,
+ CODE_ISO} computationType = DESIGN_AUTO;
+- char comment[1024];
++ char comment[1024] = "";
+
+ /* Check whether the first parameters are iso, code, or matrix.
+ Set the computation type. */
+
+base-commit: 6824a6b57b515e0dbdd202eecd780948d2828726
+--
+2.45.2
+
diff -Nru gap-guava-3.19+ds/debian/patches/series
gap-guava-3.19+ds/debian/patches/series
--- gap-guava-3.19+ds/debian/patches/series 2022-09-10 13:59:09.000000000
+0200
+++ gap-guava-3.19+ds/debian/patches/series 2024-08-21 13:00:25.000000000
+0200
@@ -1 +1,2 @@
debianization.patch
+0001-desauto-initialize-the-comment-array-to-a-sensible-v.patch
--- End Message ---
--- Begin Message ---
Source: gap-guava
Source-Version: 3.19+ds-3
Done: Jerome Benoit <calcu...@rezozer.net>
We believe that the bug you reported is fixed in the latest version of
gap-guava, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1079...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jerome Benoit <calcu...@rezozer.net> (supplier of updated gap-guava package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 04 Oct 2024 16:49:48 +0000
Source: gap-guava
Architecture: source
Version: 3.19+ds-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<debian-science-maintain...@alioth-lists.debian.net>
Changed-By: Jerome Benoit <calcu...@rezozer.net>
Closes: 1079204
Changes:
gap-guava (3.19+ds-3) unstable; urgency=medium
.
* SBF: initialize a wild char array that derails tests (Closes: #1079204),
thanks to Simon Chopin <scho...@ubuntu.com>.
Checksums-Sha1:
d37f175707c0ee9eea990fd6172196e22fc81148 2896 gap-guava_3.19+ds-3.dsc
621000d16599bca3900dbe00675f539b76ffb7c0 8228 gap-guava_3.19+ds-3.debian.tar.xz
10899268c0bb1317d9e3e1647c6947956a80e0b1 9452
gap-guava_3.19+ds-3_source.buildinfo
Checksums-Sha256:
e26ae8a6dbae8e2647af862a987dae48987f175620059a26a861488e6c37fd68 2896
gap-guava_3.19+ds-3.dsc
cc927d795f70f328d4b5af1b6e33fd9ac4b63d6c859415bd12d1c2aeffe0bae4 8228
gap-guava_3.19+ds-3.debian.tar.xz
9bf8573451baf93c159963b3c3d1f22968bff2373c37e2bc67b5d92773ca831f 9452
gap-guava_3.19+ds-3_source.buildinfo
Files:
1c34496994e219e1b7f4249cde6996f2 2896 math optional gap-guava_3.19+ds-3.dsc
95b3b934b6bb4dc5f99162226e526ff8 8228 math optional
gap-guava_3.19+ds-3.debian.tar.xz
76f657d3eb466b1bcbff5ec9580ddb82 9452 math optional
gap-guava_3.19+ds-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQRJBAEBCgAzFiEEriiuFXEN/x2H5adiP5IZpn82xosFAmcAHdwVHGNhbGN1bHVz
QHJlem96ZXIubmV0AAoJED+SGaZ/NsaLY1Yf/R5YhvFzyqQ2qHBj1qmnI6Xns8ph
iz0kLWu2UItsfPCPRQ91z9KJm10QPDKpv3s8zw6xfd5gkVK/FxO4Vx0chISZevsP
qOl+kSOq8CW+z41iDZeaU3ReQ+NAJvZVd6HPV/beNh0TvOI7eem1hSukvOeX9a8s
1OA3+DUvHdQEWyC4xsHx7MwzW82pcbrlQBcDS1DBGNiSJOlhr0ecZvCvmKiOr0TX
VfjHBFcrC5yQ4vTlmxz658wtxb23pXp7TmVjKShYKr2O48RBtD5B2ox9NVE/NH17
lMqBc4Fk9z/TvrUaB9lApB6Wa6gi1BIyomSCQjOGP6bc3P7M9KZB1yDCDhjhuEYz
IIFMZUXkcuGhshceyvrddCYA300AT5YeHLxOxrH9oSdTRBoCJ0KElBFKILpg9A28
xZ7GmAB+Sw/ktBeRqodyzgmzV8QsIV2xZrtpyuAmrStJiO0G1cF2Kf3KsIlCvRkW
mm2/n0wiFPLRcZd7lkulPp6y0xcZtJ/98CQmvbuw7qStymhQ7QSnzLHuKT7mqZgl
JLsGuuRr8keGpmZTaELBYG4Bga4Rg9Rf+V0UtgWUMVQngwjs9bXF84LPPvuNJ+i1
UGj6p2G7nTQ2GwP+5697QPFFyhUeeTmxSF+TfHabDB2EHtbEXOJ+XichzUkMrhNh
M0BWdPR4OCYKLoBIWtkmpIkm3joaiCj6WhQupULCAsu9Cibq+8HqMASfyFdfKBUQ
/tMxbwsrVhl+VTHGqepynxcJaToPXbVDS6ZkB2XLNErtmFX+R+tq8oLAhrA8BkYr
L6r8DsX1ctBBupPMXlSKA9igVb83+On8lWrszLp90+KWX+batPOhKEsBmCyIRwWQ
9n27iafb6rUBJSnIOKfGClJgXtpSvvZroWIgnJpvIKx80N+Ic04daoWk6QrQRu7b
FsmFvalxTFhmt36XdrTKanJdp0hYGqeLG7PXqmWS6vcmSajK4qbIUKRi4wfhIP2h
Bjf91liakyZG82mktSb60ZEJapb2gjiAMxy9rr4TREqQlXTuMHoSrlIT+VqFdyiQ
9b2RqNhN2kEYNylO11e9Bb5U6Hv/+5TJaaEFoC1HLihN7n0hQ34ZlaGERLenbIed
N+pWbLcROh7dQzFvQKs03kxvZV7CE0X2khmcxQ5vtSIHKcDZ0crNfqhAs/rowcNy
Z6xNctnNMPkn7FgQG/GgLoR1I/axh3hMTSbi3U3+IJ7VJUb+nvHX4+Xn69W5aZtN
01+mq2xYZfGaZlU5Sf6WCyTB8v6QePK/P6TwEC4O/8N8VdfC3NKHAjWm7mUwS/Op
IFyoD8roK9EGYO9ar1m13z1v0EkU4cyeIMklshyUAlHSF9qC5VpYoJYtcRo=
=FU27
-----END PGP SIGNATURE-----
pgp7uSNXcUlue.pgp
Description: PGP signature
--- End Message ---
