Your message dated Mon, 07 Oct 2024 15:06:44 +0000
with message-id <[email protected]>
and subject line Bug#1081391: fixed in cage 0.2.0-1
has caused the Debian Bug report #1081391,
regarding cage: Missing touch_frame handler, Qt Wayland platform plugin may not
work correctly.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1081391: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1081391
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cage
Severity: normal
Tags: patch upstream
Dear Maintainer,
wl_touch::frame() is expected to be sent to client to indicate end of
touch frame event and not sending it may cause issues.
For example, Qt applications using Qt Wayland platform plugin do not
consider touch events until this end of frame to be received.
This problem is solved by upstream in commit:
https://github.com/cage-kiosk/cage/commit/7ec7e3df2bfc2069219285ccca676327480fa471
The buttons in my Qt application can not be clicked using touchscreen
with version in bookworm repository. After applied this patch, problem
solved.
-- System Information:
Debian Release: 12.7
APT prefers stable-security
APT policy: (500, 'stable-security'), (500, 'proposed-updates'), (500,
'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64
Kernel: Linux 6.1.0-25-amd64 (SMP w/28 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_USER,
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE
not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages cage depends on:
ii libc6 2.36-9+deb12u8
ii libpixman-1-0 0.42.2-1
ii libwayland-server0 1.21.0-1
pn libwlroots10 <none>
ii libxkbcommon0 1.5.0-1
cage recommends no packages.
cage suggests no packages.
From 7ec7e3df2bfc2069219285ccca676327480fa471 Mon Sep 17 00:00:00 2001
From: Jonathan GUILLOT <[email protected]>
Date: Wed, 23 Aug 2023 18:40:15 +0200
Subject: [PATCH] seat: add missing touch_frame handler
wl_touch::frame() is expected to be sent to client to indicate end of
touch frame event and not sending it may cause issues.
For example, Qt applications using Qt Wayland platform plugin do not
consider touch events until this end of frame to be received.
---
seat.c | 12 ++++++++++++
seat.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/seat.c b/seat.c
index 5d80e33..80fd86a 100644
--- a/seat.c
+++ b/seat.c
@@ -565,6 +565,15 @@ handle_touch_motion(struct wl_listener *listener, void *data)
wlr_idle_notify_activity(seat->server->idle, seat->seat);
}
+static void
+handle_touch_frame(struct wl_listener *listener, void *data)
+{
+ struct cg_seat *seat = wl_container_of(listener, seat, touch_frame);
+
+ wlr_seat_touch_notify_frame(seat->seat);
+ wlr_idle_notify_activity(seat->server->idle, seat->seat);
+}
+
static void
handle_cursor_frame(struct wl_listener *listener, void *data)
{
@@ -748,6 +757,7 @@ handle_destroy(struct wl_listener *listener, void *data)
wl_list_remove(&seat->touch_down.link);
wl_list_remove(&seat->touch_up.link);
wl_list_remove(&seat->touch_motion.link);
+ wl_list_remove(&seat->touch_frame.link);
wl_list_remove(&seat->request_set_cursor.link);
wl_list_remove(&seat->request_set_selection.link);
wl_list_remove(&seat->request_set_primary_selection.link);
@@ -830,6 +840,8 @@ seat_create(struct cg_server *server, struct wlr_backend *backend)
wl_signal_add(&seat->cursor->events.touch_up, &seat->touch_up);
seat->touch_motion.notify = handle_touch_motion;
wl_signal_add(&seat->cursor->events.touch_motion, &seat->touch_motion);
+ seat->touch_frame.notify = handle_touch_frame;
+ wl_signal_add(&seat->cursor->events.touch_frame, &seat->touch_frame);
seat->request_set_cursor.notify = handle_request_set_cursor;
wl_signal_add(&seat->seat->events.request_set_cursor, &seat->request_set_cursor);
diff --git a/seat.h b/seat.h
index 52cbee4..19ed936 100644
--- a/seat.h
+++ b/seat.h
@@ -39,6 +39,7 @@ struct cg_seat {
struct wl_listener touch_down;
struct wl_listener touch_up;
struct wl_listener touch_motion;
+ struct wl_listener touch_frame;
struct wl_list drag_icons;
struct wl_listener request_start_drag;
--- End Message ---
--- Begin Message ---
Source: cage
Source-Version: 0.2.0-1
Done: Birger Schacht <[email protected]>
We believe that the bug you reported is fixed in the latest version of
cage, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Birger Schacht <[email protected]> (supplier of updated cage package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 07 Oct 2024 16:06:52 +0200
Source: cage
Architecture: source
Version: 0.2.0-1
Distribution: experimental
Urgency: medium
Maintainer: Sway and related packages team <[email protected]>
Changed-By: Birger Schacht <[email protected]>
Closes: 1081391
Changes:
cage (0.2.0-1) experimental; urgency=medium
.
* New upstream release (Closes: #1081391)
* d/control: bump wlroots build dependency
* d/rules: drop dh_auto_configure override (it was only used for the
xwayland compile time option, which does not exist anymore)
Checksums-Sha1:
b6c01ccc1c285aa61b0323ea04a869c274903172 2026 cage_0.2.0-1.dsc
1129d88fae512e64cd33bbd6005608751bfb0298 24107 cage_0.2.0.orig.tar.gz
219ebf62a14cb9e08f46d32c4cd3bb8cea8cc17f 7068 cage_0.2.0-1.debian.tar.xz
99a0474fedfb7f24adf3cff787b2da4bcbeb6b16 11690 cage_0.2.0-1_amd64.buildinfo
Checksums-Sha256:
bd2071de55c9011defb6363852e9384c1153d6d028553e5b4c2223adfb405660 2026
cage_0.2.0-1.dsc
9d3f659e0f19636a958f9e1bf4d22268d7e2705d7e2989888401ec443c1cb6c3 24107
cage_0.2.0.orig.tar.gz
777c7cc67fac10731b4f81dd11b5180380c4cfff861c54714880aa80f2bab5b9 7068
cage_0.2.0-1.debian.tar.xz
a9408f1a7131d6277042842c42200f2eb467dc54ea92b290fd7016cfb2c8e79a 11690
cage_0.2.0-1_amd64.buildinfo
Files:
8e4c4b10f9c2aa7997ce0b07f4c17f05 2026 x11 optional cage_0.2.0-1.dsc
020af0e5c9f3c67f6121ccdc6573f889 24107 x11 optional cage_0.2.0.orig.tar.gz
82c820d90c13b088fcd55636d2278406 7068 x11 optional cage_0.2.0-1.debian.tar.xz
a053da31dc9ac0b91ff807d7e1a95c81 11690 x11 optional
cage_0.2.0-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEEOvC8tnwmrEjOtOW8KgxdYPIEvbAFAmcD8woSHGJpcmdlckBk
ZWJpYW4ub3JnAAoJECoMXWDyBL2w1LUP+wYmRZAzdZc24xvDpuPQwjkRg3oSHCBZ
dnnCY5Z+yalUmlMCbq/xyS0MqjSfUlp+0/uekKgzXQ5RqDnfBwmbL1KJNRhHbYEe
3GURQzvBLOLapo1T/H/0/sFJZ8MSCu1RIODfJPj+d7Q4vtpZoaOSjo8LaXHsaKHl
pne0ATE9Af+XQs2YaWWbZXl8QW0RtBZOM0WXHAG9c0gWicnfej5/ldE3lbNygJa9
tb6ABcrIC859h+yKZs3wbI44+Wi+9rIK+c5fjzoftxlvmyMr3xDcsBpxWiKs8NEy
31jgbErmCFdUqn4IogtBebarlHyRdxNyQTI8CL0gvZ5/vwqI8Ol81NWWhsTksU7m
JOe5toX+VJtwkneYYTjWD4z6DjFvo8cCSjNFW6ovQF/6L3H2mx1IuD+XdBrxFzCY
+ywrnnGr1xPOJ/LWczzoCZYDWDIuZ5TBJmbeJblbLpxd4qdvtN7uCGjl28fu+OP5
xl18ytNVLnvNaAD8JiDXihgYrJrRTLk1SagVXftMvWPpLIZuVAhaFmtiAhzygZt7
+Gbzz4W9pQ0s2it3hwsvr+lZLyHntdvUzIvBlNwZI3lYvP4DwmR5u2/rM6BmlkbP
YPVfuM3gY3vFZE1x3Dr7M+K0W33d7zjSsQClWhTfQMUcvx6dOct3txPAxmCUSPdI
2jmb8wjOt5x3
=F3Q2
-----END PGP SIGNATURE-----
pgpONWhcmETGr.pgp
Description: PGP signature
--- End Message ---
