Your message dated Wed, 06 Nov 2024 16:20:35 +0000
with message-id <[email protected]>
and subject line Bug#1086612: fixed in hardinfo 2.2.1-2
has caused the Debian Bug report #1086612,
regarding hardinfo: FTBFS: Fixed 2 code writing errors on loong64
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1086612: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086612
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: hardinfo
Version: 2.2.1-1
Severity: normal
Tags: ftbfs patch
User: [email protected]
Usertags: loong64
Hi maintainers,
Compiling the hardinfo failed for loong64 in the Debian Package
Auto-Building environment.
The build error log is as follows,
```
first error......
/<<PKGBUILDDIR>>/modules/devices/loongarch64/processor.c:56:44: error:
‘q’ undeclared (first use in this function)
56 | return g_slist_append(NULL, processor);q
| ^
/<<PKGBUILDDIR>>/modules/devices/loongarch64/processor.c:56:44: note:
each undeclared identifier is reported only once for each function it
appears in
/<<PKGBUILDDIR>>/modules/devices/loongarch64/processor.c:56:45: error:
expected ‘;’ before ‘}’ token
56 | return g_slist_append(NULL, processor);q
| ^
| ;
57 | }
second error......
/usr/include/glib-2.0/glib/gstrfuncs.h:324:9: note: macro "g_strdup"
defined here
324 | #define g_strdup(x) g_strdup_inline (x)
| ^~~~~~~~
/<<PKGBUILDDIR>>/modules/devices/loongarch64/processor.c:71:17: error:
assignment to ‘gchar *’ {aka ‘char *’} from incompatible pointer type
‘gchar * (*)(const gchar *)’ {aka ‘char * (*)(const char *)’}
[-Wincompatible-pointer-types]
71 | if(!ret) ret=g_strdup("Loongarch64 Processor
(%s/NoDT)",processor_name_default_(processors));
| ^
......
```
The full log can be found at
https://buildd.debian.org/status/fetch.php?pkg=hardinfo&arch=loong64&ver=2.2.1-1&stamp=1730360209&raw=0.
After investigation, I found that there were coding errors in the
upstream since release-2.1.16pre version.
Please check https://github.com/hardinfo2/hardinfo2/blob/release-2.1.16pre.
I have fixed above 2 code writing errors on loong64.
Please consider the patch attached.
I have built hardinfo 2.2.1-1 successfully in my local ENV and all test
cases passed.
```
dh_builddeb -O--buildsystem=cmake
dpkg-deb: building package 'hardinfo' in
'../hardinfo_2.2.1-1+loong64_all.deb'.
dpkg-deb: building package 'hardinfo2' in
'../hardinfo2_2.2.1-1+loong64_loong64.deb'.
dpkg-deb: building package 'hardinfo2-dbgsym' in
'../hardinfo2-dbgsym_2.2.1-1+loong64_loong64.deb'.
dpkg-genbuildinfo -O../hardinfo_2.2.1-1+loong64_loong64.buildinfo
dpkg-genchanges -O../hardinfo_2.2.1-1+loong64_loong64.changes
```
Best regards,
Dandan Zhang
diff -Nru hardinfo-2.2.1/debian/changelog hardinfo-2.2.1/debian/changelog
--- hardinfo-2.2.1/debian/changelog 2024-10-30 20:20:26.000000000 +0000
+++ hardinfo-2.2.1/debian/changelog 2024-11-02 03:49:01.000000000 +0000
@@ -1,3 +1,11 @@
+hardinfo (2.2.1-1+loong64) unreleased; urgency=medium
+
+ * Fix 2 build errors on loong64 (FTBFS)
+ - error: expected ';' before '}' token
+ - error: macro "g_strdup" passed 2 arguments, but takes just 1
+
+ -- Dandan Zhang <[email protected]> Sat, 02 Nov 2024 11:49:01 +0800
+
hardinfo (2.2.1-1) unstable; urgency=medium
* New upstream release.
diff -Nru hardinfo-2.2.1/debian/patches/Fix-FTBFS-on-loong64.patch
hardinfo-2.2.1/debian/patches/Fix-FTBFS-on-loong64.patch
--- hardinfo-2.2.1/debian/patches/Fix-FTBFS-on-loong64.patch 1970-01-01
00:00:00.000000000 +0000
+++ hardinfo-2.2.1/debian/patches/Fix-FTBFS-on-loong64.patch 2024-11-02
03:49:01.000000000 +0000
@@ -0,0 +1,48 @@
+Description: Fixed FTBFS on loong64
+ .
+ hardinfo (2.2.1-1+loong64) unreleased; urgency=medium
+ .
+ * Fix 2 build errors on loong64 (FTBFS)
+ - error: expected ';' before '}' token
+ - error: macro "g_strdup" passed 2 arguments, but takes just 1
+Author: Dandan Zhang <[email protected]>
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout https://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: (upstream|backport|vendor|other), (<patch-url>|commit:<commit-id>)
+Bug: <upstream-bugtracker-url>
+Bug-Debian: https://bugs.debian.org/<bugnumber>
+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
+Forwarded: (no|not-needed|<patch-forwarded-url>)
+Applied-Upstream: <version>, (<commit-url>|commit:<commid-id>)
+Reviewed-By: <name and email of someone who approved/reviewed the patch>
+Last-Update: 2024-11-02
+
+--- hardinfo-2.2.1.orig/modules/devices/loongarch64/processor.c
++++ hardinfo-2.2.1/modules/devices/loongarch64/processor.c
+@@ -53,7 +53,7 @@ processor_scan(void)
+
+ fclose(cpuinfo);
+
+- return g_slist_append(NULL, processor);q
++ return g_slist_append(NULL, processor);
+ }
+
+ gchar *processor_name(GSList * processors) {
+@@ -64,11 +64,11 @@ gchar *processor_name(GSList * processor
+
+ if (compat != NULL) {
+ //FIXME - Add table for incoming compatible DT info
+- ret= g_strdup_printf("Loongarch64 Processor
(%s/%s)",processor_name_default(processors), compat);
++ ret = g_strdup_printf("Loongarch64 Processor
(%s/%s)",processor_name_default(processors), compat);
+ g_free(compat);
+ }
+
+- if(!ret) ret=g_strdup("Loongarch64 Processor
(%s/NoDT)",processor_name_default_(processors));
++ if(!ret) ret = g_strdup("Loongarch64 Processor (%s/NoDT)");
+ return ret;
+ }
+
diff -Nru hardinfo-2.2.1/debian/patches/series
hardinfo-2.2.1/debian/patches/series
--- hardinfo-2.2.1/debian/patches/series 1970-01-01 00:00:00.000000000
+0000
+++ hardinfo-2.2.1/debian/patches/series 2024-11-02 03:49:01.000000000
+0000
@@ -0,0 +1 @@
+Fix-FTBFS-on-loong64.patch
--- End Message ---
--- Begin Message ---
Source: hardinfo
Source-Version: 2.2.1-2
Done: Boyuan Yang <[email protected]>
We believe that the bug you reported is fixed in the latest version of
hardinfo, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Boyuan Yang <[email protected]> (supplier of updated hardinfo package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 03 Nov 2024 10:47:28 -0500
Source: hardinfo
Architecture: source
Version: 2.2.1-2
Distribution: unstable
Urgency: medium
Maintainer: Boyuan Yang <[email protected]>
Changed-By: Boyuan Yang <[email protected]>
Closes: 1086612
Changes:
hardinfo (2.2.1-2) unstable; urgency=medium
.
* debian/patches/backport/4da6e7843e79bb69520164c1ff2e2e776be8a05e.patch:
Add upstream patch to fix FTBFS on loongarch. (Closes: #1086612)
Checksums-Sha1:
1d2b2de2b3f8c36dacb35023c0faf4846f3b49a5 2365 hardinfo_2.2.1-2.dsc
8e4277724856491d65303d4d2fbd0e5543ebb14f 13787088 hardinfo_2.2.1.orig.tar.gz
8eb672dd19da8a4c26c9356628f6bb788160e2dd 11848 hardinfo_2.2.1-2.debian.tar.xz
855d030a523355fa658d0fc6ef7ff87da9c598e6 17461 hardinfo_2.2.1-2_amd64.buildinfo
Checksums-Sha256:
564737a103e4e030438b445e3020afbd5d9697e0644820387344c5b3d717b1f7 2365
hardinfo_2.2.1-2.dsc
1a6476d0a2c159b90b3a7648e8e50abc1cf2d6ca33d05b0a4121d0efa5db5186 13787088
hardinfo_2.2.1.orig.tar.gz
e09b43ab39e108948630f4d5eef0d740b6e0056981d4fde778c564fd3454b7e8 11848
hardinfo_2.2.1-2.debian.tar.xz
c2ad97c72bcbe91386a1ef4d2470938acb1afafa505f41f1b95e3e5e710fba47 17461
hardinfo_2.2.1-2_amd64.buildinfo
Files:
dee181f61d57b023ba3d10f354f4e656 2365 x11 optional hardinfo_2.2.1-2.dsc
ae1f99d58cf2bebea4c47f7bc74ca777 13787088 x11 optional
hardinfo_2.2.1.orig.tar.gz
fd9daf30c6ffafe2c81d221c17f02cd7 11848 x11 optional
hardinfo_2.2.1-2.debian.tar.xz
82fa21d1a437e20111f02bb9be3f8bc3 17461 x11 optional
hardinfo_2.2.1-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmcnm6kACgkQwpPntGGC
Ws6khQ/8C+ZHyZEa2ehc5s5Pl3R3tU3XcCKAiM92Vbs5u3Q3dR1yAmDTMQ5dTuZP
kOORY4iPplQNQezneCXfcr6p2Onbd73SLEB6h1bBGeleOkOatrnUEcn8dk6y8Z+8
DyAwQs5GHWtPACmjTaUwrjkq9MbkkFn3fOcdqT/s7cmfqrqrtSuqh/AApqf8iQe2
DaD/Geus06mif1yvtLaUctdzRw1CncVpBeE8WuhMe7plmP3KDPk37n458mf7l0Wu
ERf4zcez8wwBuIxP8cHtHds3Q8x3KheyXH3qRXx05zJOUWP92iH+WFdqxBGgI2ax
zyccGJDIP/c3bFMFlotUWGJuz9G1K4L0wtt+icboPWpGoGXPrdj9/4Rg5co0Xs3J
NVB8zrVjR2lWU9gSHEjtdxHBwFMcspCIiHdkLCN+kRm8QlQVKShnzhqHZdPmgysi
IHMjkRZdqm8yKmRAwgxfaOc38R5EDExmhEiyNjC71/jqzENRIgU6KFW/U23V580j
z/BGRWlPBtUAbjl8ZRUw/XsySnTWnP08IxG2jJn8lnk2tTUZDEz+Ka4zEZTu26zJ
M02x6hmkirBWBXMYFOda9uVj9tlT5jW4e07bppSnkUx1DOwQsOyZF+xjCHFoaIAM
H2iWaY4XI3CoZLygkkLYSwI83e8j1KEW4J2v0S2ByC7syXvA8Ac=
=bISg
-----END PGP SIGNATURE-----
pgpWi_NGHMzAB.pgp
Description: PGP signature
--- End Message ---
