Your message dated Thu, 2 Jan 2025 22:19:31 +0100
with message-id <[email protected]>
and subject line git-daemon-sysvinit package removed
has caused the Debian Bug report #854499,
regarding git-daemon-sysvinit: unconditionally enables --verbose, causing IP 
addresses to be logged
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
854499: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854499
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: git-daemon-sysvinit
Version: 1:2.1.4-2.1+deb8u2
Severity: normal

Dear Maintainer,

/etc/init.d/git-daemon always passes the --verbose option to
git-daemon. Since there is no corresponding option like --quiet that
would be able to counter it, there's no way to disable IP address
logging without modifying /etc/init.d/git-daemon itself.

Instead --verbose should be included in GIT_DAEMON_OPTIONS in the
default /etc/default/git-daemon file so that the user can remove it.

Logging IP addresses can be problematic within the EU due to privacy
laws, especially since git-daemon-sysvinit is usually used to provide a
public, unauthenticated service (thus no need to identify the user) and
without a way to inform the user about the privacy policy.

Sascha

-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (990, 'stable-updates'), (990, 'stable'), (100, 'testing')
Architecture: armhf (armv7l)

Kernel: Linux 4.8.17-wandboard-29-00002-g49a7648fc7ba (SMP w/4 CPU cores; 
PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages git-daemon-sysvinit depends on:
ii  adduser  3.113+nmu3
ii  git      1:2.1.4-2.1+deb8u2

git-daemon-sysvinit recommends no packages.

git-daemon-sysvinit suggests no packages.

-- Configuration Files:
/etc/default/git-daemon changed:
GIT_DAEMON_ENABLE=true
GIT_DAEMON_USER=gitdaemon
GIT_DAEMON_BASE_PATH=/var/lib/git
GIT_DAEMON_DIRECTORY=/var/lib/git
GIT_DAEMON_OPTIONS=""

/etc/init.d/git-daemon changed:
PATH=/sbin:/usr/sbin:/bin:/usr/bin:/usr/lib/git-core
DESC="git-daemon service"
NAME=git-daemon
DAEMON=/usr/lib/git-core/$NAME
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
[ -e /usr/share/git-core/sysvinit/sentinel ] || exit 0
[ -r /etc/default/$NAME ] && . /etc/default/$NAME
GIT_DAEMON_USER=${GIT_DAEMON_USER:-gitdaemon}
GIT_DAEMON_BASE_PATH=${GIT_DAEMON_BASE_PATH:-/var/lib}
GIT_DAEMON_DIRECTORY=${GIT_DAEMON_DIRECTORY:-/var/lib/git}
DAEMON_ARGS="--user=$GIT_DAEMON_USER --pid-file=$PIDFILE --detach"
DAEMON_ARGS="$DAEMON_ARGS --reuseaddr $GIT_DAEMON_OPTIONS"
DAEMON_ARGS="$DAEMON_ARGS --base-path=$GIT_DAEMON_BASE_PATH 
$GIT_DAEMON_DIRECTORY"
. /lib/init/vars.sh
. /lib/lsb/init-functions
do_start()
{
        # Return
        #   0 if daemon has been started
        #   1 if daemon was already running
        #   2 if daemon could not be started
        start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON 
--test > /dev/null \
                || return 1
        start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON -- \
                $DAEMON_ARGS \
                || return 2
}
do_stop()
{
        # Return
        #   0 if daemon has been stopped
        #   1 if daemon was already stopped
        #   2 if daemon could not be stopped
        #   other if a failure occurred
        start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile 
$PIDFILE --name $NAME
        RETVAL="$?"
        [ "$RETVAL" = 2 ] && return 2
        # Many daemons don't delete their pidfiles when they exit.
        rm -f $PIDFILE
        return "$RETVAL"
}
case "$1" in
  start)
    if [ $GIT_DAEMON_ENABLE = true ]; then
        [ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC " "$NAME"
    else
        [ "$VERBOSE" != no ] && log_warning_msg "$NAME not enabled in 
/etc/default/$NAME, not starting..."
        exit 0
    fi
    do_start
    case "$?" in
                0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;;
                2) [ "$VERBOSE" != no ] && log_end_msg 1 ;;
        esac
  ;;
  stop)
        [ "$VERBOSE" != no ] && log_daemon_msg "Stopping $DESC" "$NAME"
        do_stop
        case "$?" in
                0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;;
                2) [ "$VERBOSE" != no ] && log_end_msg 1 ;;
        esac
        ;;
  status)
       status_of_proc "$DAEMON" "$NAME" && exit 0 || exit $?
       ;;
  restart|force-reload)
        if [ $GIT_DAEMON_ENABLE != true ]; then
                [ "$VERBOSE" != no ] && log_warning_msg "$NAME not enabled in 
/etc/default/$NAME, stopping..."
                do_stop
                case "$?" in
                  0|1)
                        log_end_msg 0 ;;
                  *)
                        log_end_msg 1 ;;
                esac
                exit
        fi
        log_daemon_msg "Restarting $DESC" "$NAME"
        do_stop
        case "$?" in
          0|1)
                do_start
                case "$?" in
                        0) log_end_msg 0 ;;
                        1) log_end_msg 1 ;; # Old process is still running
                        *) log_end_msg 1 ;; # Failed to start
                esac
                ;;
          *)
                # Failed to stop
                log_end_msg 1
                ;;
        esac
        ;;
  *)
        echo "Usage: $SCRIPTNAME {start|stop|status|restart|force-reload}" >&2
        exit 3
        ;;
esac
:


-- no debconf information

--- End Message ---
--- Begin Message ---
Source: git
Source-Version: 1:2.47.1-1

The latest version of git in sid does not include sysvinit
configuration any more, meaning this bug no longer applies.

--- End Message ---

Reply via email to