Your message dated Fri, 24 Jan 2025 02:49:13 +0000
with message-id <[email protected]>
and subject line Bug#722958: fixed in udt 4.11+dfsg1-1.1
has caused the Debian Bug report #722958,
regarding udt: Fails to build with --as-needed linker option (patch)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
722958: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=722958
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: udt
Version: 4.11+dfsg-1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu saucy ubuntu-patch



In Ubuntu, the attached patch was applied to achieve the following:

  * 0001-Link-against-libpthread.patch: Fix linking with --as-needed.
  * 0002-Set-soname-on-shared-library.patch: Rebase against the above.

Now, by way of explanation, there were two different ways to fix this:

1) Move your -lpthread to the end of the linker line (so it comes after
   the objects that reference its symbols).
2) Switch from -lpthread (a linker call) to -pthread (a GCC switch that
   always links pthread).

Given that the second option was a 1-char patch, and we already KNOW we
need that library linked against pthread, the second option was the
simplest, but one could certainly argue that the first could be a bit
more correct, as it means --as-needed could drop pthread on the floor
if it wasn't actually referenced.  Purely an academic discussion, since
the library obviously uses pthread and doesn't seem likely to stop.

... Adam

-- System Information:
Debian Release: wheezy/sid
  APT prefers saucy-updates
  APT policy: (500, 'saucy-updates'), (500, 'saucy-security'), (500, 'saucy')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11.0-5-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru udt-4.11+dfsg/debian/changelog udt-4.11+dfsg/debian/changelog
diff -Nru udt-4.11+dfsg/debian/patches/0001-Link-against-libpthread.patch udt-4.11+dfsg/debian/patches/0001-Link-against-libpthread.patch
--- udt-4.11+dfsg/debian/patches/0001-Link-against-libpthread.patch	2013-07-01 20:36:48.000000000 -0400
+++ udt-4.11+dfsg/debian/patches/0001-Link-against-libpthread.patch	2013-09-14 15:53:01.000000000 -0400
@@ -17,7 +17,7 @@
  libudt.so: $(OBJS)
  ifneq ($(os), OSX)
 -	$(C++) -shared -o $@ $^
-+	$(C++) -shared -lpthread -o $@ $^
++	$(C++) -shared -pthread -o $@ $^
  else
  	$(C++) -dynamiclib -o libudt.dylib -lstdc++ -lpthread -lm $^
  endif
diff -Nru udt-4.11+dfsg/debian/patches/0002-Set-soname-on-shared-library.patch udt-4.11+dfsg/debian/patches/0002-Set-soname-on-shared-library.patch
--- udt-4.11+dfsg/debian/patches/0002-Set-soname-on-shared-library.patch	2013-07-01 20:36:48.000000000 -0400
+++ udt-4.11+dfsg/debian/patches/0002-Set-soname-on-shared-library.patch	2013-09-14 15:53:52.000000000 -0400
@@ -16,8 +16,8 @@
  
  libudt.so: $(OBJS)
  ifneq ($(os), OSX)
--	$(C++) -shared -lpthread -o $@ $^
-+	$(C++) -shared -lpthread -Wl,-soname,libudt.so.0 -o $@ $^
+-	$(C++) -shared -pthread -o $@ $^
++	$(C++) -shared -pthread -Wl,-soname,libudt.so.0 -o $@ $^
  else
  	$(C++) -dynamiclib -o libudt.dylib -lstdc++ -lpthread -lm $^
  endif

--- End Message ---
--- Begin Message ---
Source: udt
Source-Version: 4.11+dfsg1-1.1
Done: Chris Hofstaedtler <[email protected]>

We believe that the bug you reported is fixed in the latest version of
udt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Hofstaedtler <[email protected]> (supplier of updated udt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 24 Jan 2025 02:23:06 +0100
Source: udt
Architecture: source
Version: 4.11+dfsg1-1.1
Distribution: unstable
Urgency: medium
Maintainer: Jon Bernard <[email protected]>
Changed-By: Chris Hofstaedtler <[email protected]>
Closes: 646778 722958 994675
Changes:
 udt (4.11+dfsg1-1.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Guillem Jover ]
   * Enable portability beyond i386 and amd64 (Closes: #646778)
 .
   [ Adam Conrad ]
   * Fix FBTFS with --as-needed (Closes: #722958)
 .
   [ Helmut Grohne ]
   * Use CXX as C++ compiler name variable (Closes: #994675)
Checksums-Sha1:
 8cdd6bcfbde506baf4ea630e65701868528e3417 2010 udt_4.11+dfsg1-1.1.dsc
 d925fd462327109cef1b4668099f3a8e41403033 6424 udt_4.11+dfsg1-1.1.debian.tar.xz
Checksums-Sha256:
 89b3a81a4007b908fee805bd21f968e8911c1b8245d8bef105d9f4d7ccf5fd95 2010 
udt_4.11+dfsg1-1.1.dsc
 7c532c8026c50bb1fbad491b3ec1640931ca36c2923d530dfc85c66aa2b39365 6424 
udt_4.11+dfsg1-1.1.debian.tar.xz
Files:
 faf19ebb69734c8b5045f7170fbee8fb 2010 libs extra udt_4.11+dfsg1-1.1.dsc
 080c665a3df6cf432e70d91ed9863cf1 6424 libs extra 
udt_4.11+dfsg1-1.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfRrP+tnggGycTNOSXBPW25MFLgMFAmeS6+AACgkQXBPW25MF
LgPokA//fLStSD2W0Lm0GzN9InFaUu4OxE8f5O4Ituu/0u32vFe5wLz835y913oe
cO7Tx8tiLagDw3pUI2G0QKLVwOMZayt+b3M2ErbXkSwKsqacIvOaPBnlxeXzyZKj
uPuulguWkV6gqjr9CSdtNR78sxIAyY+TTOYI66J3lqPOGhC50q7Ul5gHXKo5KySF
KG+c/6oHjlsmTOaXzI2br3YeLS9cVb6ClCDwyN+MgBd1+zTCP8iuraWg3ffD2Iuy
8NrbRdxd7S+CdorkOwz523b/9zGuNYJqKgrewg8TXkBbp3Qf44T/HWUpj+LHMirb
Px0Ja+cyt59zMIHkVCMQ9mtk9GJPP3VnSXrQISDieECt0SPvsiMRMm59rg619IML
CRl7pdPjf8AhJDkA9d5jHOOwu6wdX9+2hzK9CCHEhgVuVtxRheOMJghgpcPxS2xL
RSIQJ48vqbf8H6JfGxsQ/goJ+JekOL0vB4fNhE2vKR5Yv6orXn4vzJftguPyVvb8
ojd7+4HIDuXomCNWFf+f3/aRsuzDxAPEwzjp50gFVj6hYZTF2lM1gStE3YzSrymG
H4nspq4da1JwXMXmSGujscaxlBSHfqO711yWO0+yzXI4aJZy/X3VwoX9sAxyyr/p
ILOdOZaiK4vxC3mFBIiAM51eXkZVULbxeYHL2sIZoQ/orFF4Bqk=
=0ys4
-----END PGP SIGNATURE-----

Attachment: pgp5DJ3MV2uUV.pgp
Description: PGP signature


--- End Message ---

Reply via email to