Your message dated Mon, 17 Feb 2025 08:50:45 +0000
with message-id <[email protected]>
and subject line Bug#1089921: fixed in ghc 9.6.6-4
has caused the Debian Bug report #1089921,
regarding ghc: Cherry-pick upstream patch to fix "relocation R_LARCH_B26 
overflow"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1089921: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1089921
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ghc
Version: 9.6.6-3
Severity: important
Tags: ftbfs help
User: [email protected]
Usertags: loong64

Hi maintainers,

We have cherry-picked 5 commits from upstream for the B26 overflow issue.
The local validation result is: haskell-pandoc build passes by building 
ghc-->haskell-*-->haskell-pandoc.

We intend to remove the previous patch backported by fanpeng as follows.
```
ghc (9.6.6-3) unstable; urgency=medium


   [ fanpeng <[email protected]> ]
   * debian/patches/7e2d3eb507da184cf3337d36715fd82a81643d91.patch:
     - upstream fix for loong64 build failures (Closes: #1085966)
```

The attached new patches fix the "B26 overflow" problem by simply adding the 
-mcmodel=medium moduleflag to LLVM IR.  
Adding the moduleflag to the generated LLVM IR is already implemented in the 
ghc upstream, but not in ghc-9.6.6. So we need to backport these patches to 
ghc-9.6.6 in order to pass the -mcmodel=medium moduleflag to the LLVM 
IR. In addition, for the behavior “pass -mcmodel=medium moduleflag to 
LoongArch's LLVM 
IR”, we have implemented the code, and we have pushed the patch to ghc upstream 
already, so what we are doing this time is just backporting.

A few of our guidelines for submitting these patches are as follows, in order 
of priority.
1. Don't modify public Functionality, such as Functionality of other 
architectures except LoongArch.
2. Backporting code directly from upstream to ghc-9.6.6, try not to modify 
patches.
3. Backport and modify as little as possible.

The attachment includes 5 patches as follows
The number at the top of the patch name indicates the order in which the 
patches should be applied.

Both 1) and 2) are directly backported from upstream. 3) is the changed 
upstream patch, in fact the content is the same as the upstream patch, but due 
to the inconsistency between ghc-9.6.6 and ghc upstream's baseline, i.e., the 
line number of the upstream patch does not match the code in ghc-9.6.6, so we 
have to manually apply the content of upstream patch. 4) The modified upstream 
patch (the one we committed to upstream) has the same problem as 3), the line 
number of the upstream patch does not match the code in ghc-9.6.6, so we have 
to apply the content of upstream patch manually. And some minor modifications 
were made. 1)-4) are backported from upstream. Their corresponding upstream 
commitIDs are stored in the corresponding patch files. 5) is for the 
debian/rules change

The details of the attached patches are as follows:
- patch: 0001-llvmGen-Add-export-list-to-GHC.Llvm.MetaData.patch
Cherry-pick from upstream
The corresponding upstream commit is: fcfc1777c22ad47613256c3c5e7304cfd29bc761
Role:  required to add a moduleflag to the llvm IR.

- patch: 0002-llvmGen-Allow-LlvmLits-in-MetaExprs.patch
Cherry-pick from upstream
The corresponding upstream commit is: 5880fff6d353a14785c457999fded5a7100c9514
Role: required to add a moduleflag to the llvm IR.

- patch: 0003-llvmGen-Introduce-infrastructure-for-module-flag-metadata.patch
Cherry-pick from upstream
The corresponding upstream commit is: a6a3874276ced1b037365c059dcd0a758e813a5b
Role: required to add a moduleflag to the llvm IR.

- patch: 0004-llvmGen-Introduce-infrastructure-for-module-flag-metadata.patch
Cherry-pick from upstream with little change.
The corresponding upstream commit is: a6a3874276ced1b037365c059dcd0a758e813a5b
Role: required to add a moduleflag to the llvm IR.
NOTE: We made a little change on the upstream patch because we have to: without 
the change, a large number of patches would need to be backported to ghc-9.6.6 
so that the upstream patch(a6a3874276ced1b037365c059dcd0a758e813a5b) could be 
backported to ghc-9.6.6, and one of these would break the public interface, 
i.e., the stack alignment ghc option would be removed. We don't want that 
happen, so we have to made the change on the upstream patch. 

- patch: 0005-rules-pass-mcmodel-medium-option-to-C-files-on-LoongArch
Not cherry-pick from upstream
Role: 1) C files in rts are compiled using the C compiler, and 2) when 
compiling some software, the object files generated by some C code are linked 
together with the program's object files. This patch passes the -mcmodel=medium 
option to the C compiler.


Best regards,
Xin Wang

Attachment: 0001-llvmGen-Add-export-list-to-GHC.Llvm.MetaData.patch
Description: Binary data

Attachment: 0002-llvmGen-Allow-LlvmLits-in-MetaExprs.patch
Description: Binary data

Attachment: 0003-llvmGen-Introduce-infrastructure-for-module-flag-metadata.patch
Description: Binary data

Attachment: 0004-llvmGen-Pass-mcmodel-medium-option-to-LLVM-backend-on-LoongArch.patch
Description: Binary data

Attachment: 0005-rules-pass-mcmodel-medium-option-to-C-files-on-LoongArch.patch
Description: Binary data


--- End Message ---
--- Begin Message ---
Source: ghc
Source-Version: 9.6.6-4
Done: Gianfranco Costamagna <[email protected]>

We believe that the bug you reported is fixed in the latest version of
ghc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gianfranco Costamagna <[email protected]> (supplier of updated ghc 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 17 Feb 2025 09:44:23 +0100
Source: ghc
Built-For-Profiles: noudeb
Architecture: source
Version: 9.6.6-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Haskell Group 
<[email protected]>
Changed-By: Gianfranco Costamagna <[email protected]>
Closes: 1089921 1094995
Changes:
 ghc (9.6.6-4) unstable; urgency=medium
 .
   [ John Paul Adrian Glaubitz ]
   * Add patch to fix FTBFS on alpha (Closes#: 1086830)
 .
   [ Gianfranco Costamagna ]
   * Add binutils-gold to armel and armhf, according to rules file
     (Closes: #1094995)
 .
   [ 王鑫 <[email protected]> ]
   * Update loongarch64 patch with new upstream backported commits
    (Closes: #1089921)
Checksums-Sha1:
 a951f4c14f21f6ff7cb412467a475c2233485534 2747 ghc_9.6.6-4.dsc
 a06c108c8231f1ee9b09827470709e7dbfdfc1c1 71244 ghc_9.6.6-4.debian.tar.xz
 79ffc19e6641a18ebf241f7a0cb9742953b719cf 7951 ghc_9.6.6-4_source.buildinfo
Checksums-Sha256:
 b8400efd5927b68a1a9f646e668697862d4af7a9d39a9a3f666c7fbe7ea481be 2747 
ghc_9.6.6-4.dsc
 0b9aa23fcca10ba2dda88d855872ffecf8bf8328723baa0cc1677436e87b2bb0 71244 
ghc_9.6.6-4.debian.tar.xz
 bbf57b88d6db6efb074561f43db4fc0c0cf617b988525ad52995bdb1adc37e7e 7951 
ghc_9.6.6-4_source.buildinfo
Files:
 ba12ca1e8e7af4fc85f59b6ce8644c90 2747 haskell optional ghc_9.6.6-4.dsc
 127e8dac1457d96ae996d052721646c1 71244 haskell optional 
ghc_9.6.6-4.debian.tar.xz
 c7f31120740c3c6384f3d5c37d8df038 7951 haskell optional 
ghc_9.6.6-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkpeKbhleSSGCX3/w808JdE6fXdkFAmey91AACgkQ808JdE6f
XdlpgBAAnLpK4Shv0uPwP/hwWz44JUZNRlM9fTO0l4otoUi9FMP9yL/DDlu0zcIS
EhFWmRqndAMKcRFPpIcgU8gFIsM/shyAzOAERO6+bpft2KqpAMfgT+boISrk6rg0
IcPJKmzPh6fmuk61Vl6ws07DZ81PmMqFv/8S8hRNGUTdLosN1wtCMKn2YUAU74f0
EH9MmIqL510OjSdk1bI8Sk+qvg2BDFypHS8org7QLGzIS/vDy0Fb6WqW6hzFzgSZ
pCaVj2sRgQCE9xbAYVFcnXYabJ+En4B6M3mXh90Zrrx70l7LUMMTImWeHreWnsws
xsOOPSUl+Ej3rgnHPGN9VtCYwCMIFCYF/jPpm7uhKx/kR1ZXMlqbV90/IBPBcwPJ
yArk93S5ihiXSa3lsMhqIuJM/zJrKV9aRbMIrFKa4L3XqCHfT4GjAFzrHMqQwMsn
S6IgeUr4ZrEtzfeIuFrDh6PGTcTn0eet+ic+yqORJVaDIWjqKchph12lFGekqqWM
OP640yXo+YbUXB2e89+V5ZD2GQt7ydLgnfuaRtDdT5+OgXPlMBs2YwLgbv228234
U73hYRwh3MLuCzZrerY0J+QZ+C/OoODlo5rdm+VO0iTr5XVNlLY+uMI7GaCNQK++
3TihxJHady9boWUVk5mU3HHzkxGeixr1fie2UnRKKHnTXrxbSUc=
=aWMv
-----END PGP SIGNATURE-----

Attachment: pgpMTMDTuTIz8.pgp
Description: PGP signature


--- End Message ---

Reply via email to