Your message dated Fri, 07 Mar 2025 10:49:07 +0000
with message-id <[email protected]>
and subject line Bug#1096103: fixed in dh-cargo 32
has caused the Debian Bug report #1096103,
regarding dh-cargo: Use new substvar assignment syntax for optionally used
variables
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1096103: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1096103
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-cargo
Version: 31
Severity: normal
Tags: patch
Hi!
Prompted by a discussion about lintian warnings about
Static-Built-Using usage (via Holger Levsen), I realized that dh-cargo
was most probably not using the new substvars assignment syntax to
avoid warning when the variables do not get used.
I'm assuming the cargo:Built-Using and the cargo:X-Cargo-Built-Using
are considered obsolete and supported currently for backwards
compatibility until all rust packages have been switched to use
cargo:Static-Built-Using. But it could be that there are legitimate
uses for cargo:Built-Using (due to license compliance)?
Attached an untested patch improving this. (A similar change was
recently applied for dh-golang, which is in a similar situation.)
Thanks,
Guillem
From 7bac0658d9e09fc4d28bfbddffedbae96feb71a9 Mon Sep 17 00:00:00 2001
From: Guillem Jover <[email protected]>
Date: Sun, 16 Feb 2025 12:03:30 +0100
Subject: [PATCH] dh-cargo-built-using: Use ?= operator for obsolete substvars
The new field to transition to is Static-Built-Using, the other fields
(Built-Using and X-Cargo-Built-Using) are now considered obsolete, and
supported for backwards compatibility until all rust packages have been
switched.
To avoid confusing packagers, use the new substvar assignment syntax (?=,
supported since dpkg 1.21.8) to denote optionally used substvars, which
will avoid emitting a warning if those substvars end up not being used.
---
dh-cargo-built-using | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dh-cargo-built-using b/dh-cargo-built-using
index 10208fd..b62dd57 100755
--- a/dh-cargo-built-using
+++ b/dh-cargo-built-using
@@ -157,8 +157,8 @@ output_built_using() {
esac
built_using_x="${built_using_x}$src (= $srcver), "
done
- echo "cargo:Built-Using=${built_using%, }" >> "debian/$binpkg.substvars"
- echo "cargo:X-Cargo-Built-Using=${built_using_x%, }" >> "debian/$binpkg.substvars"
+ echo "cargo:Built-Using?=${built_using%, }" >> "debian/$binpkg.substvars"
+ echo "cargo:X-Cargo-Built-Using?=${built_using_x%, }" >> "debian/$binpkg.substvars"
echo "cargo:Static-Built-Using=${built_using_x%, }" >> "debian/$binpkg.substvars"
}
--
2.47.2
--- End Message ---
--- Begin Message ---
Source: dh-cargo
Source-Version: 32
Done: Fabian Grünbichler <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dh-cargo, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Fabian Grünbichler <[email protected]> (supplier of updated
dh-cargo package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 07 Mar 2025 10:26:02 +0100
Source: dh-cargo
Architecture: source
Version: 32
Distribution: unstable
Urgency: medium
Maintainer: Rust Maintainers <[email protected]>
Changed-By: Fabian Grünbichler <[email protected]>
Closes: 1096103
Changes:
dh-cargo (32) unstable; urgency=medium
.
[ Fabian Grünbichler ]
* dh-cargo-built-using: fix cross-builds
* dh-cargo-built-using: mark X-Cargo-Built-Using as deprecated
.
[ Guillem Jover ]
* dh-cargo-built-using: Use ?= operator for obsolete substvars (Closes:
#1096103)
Checksums-Sha1:
24f61d4643b58d284d7b74e94631e390f568fc06 1708 dh-cargo_32.dsc
16e4c688cc256ba4ff71733147084b1fcf3dc00f 10016 dh-cargo_32.tar.xz
fcf2f8f8989374bb024f7b9019b9226b37876bbb 5365 dh-cargo_32_source.buildinfo
Checksums-Sha256:
9d0f4d7102a41284ad82bb08cf6a59bb9bcaa94b5d306ba63bda45a99fdd2912 1708
dh-cargo_32.dsc
3840c7bc8ba3b0f246419372db8647d08145daa131c550e1c2a85ab1dd4a8da5 10016
dh-cargo_32.tar.xz
5fd6e0eb2e6617998d49f0a6ce42b7c9eefa4b38d049541ae599c0397d593082 5365
dh-cargo_32_source.buildinfo
Files:
2d88bc5dcf9889e94cfc006238076e44 1708 devel optional dh-cargo_32.dsc
92d0ef6b3afa44ade7fa4c12dc021d20 10016 devel optional dh-cargo_32.tar.xz
96d25650f300089ba4535b300426c503 5365 devel optional
dh-cargo_32_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJVBAEBCgA/FiEEbdkGe7ToK0Amc9ppdh5TKjcTRTAFAmfKyT8hHGRlYmlhbkBm
YWJpYW4uZ3J1ZW5iaWNobGVyLmVtYWlsAAoJEHYeUyo3E0UwR/UQALO+XcFwPZ3w
fW8uQMcepL6jsQQ2n5Fu2f7maIbjkujkBd8gRaguh8jI9z6NOdE99Lzh2hhknoOb
wlcp+7m6rlbU9JagttoSDCikv3qZg1w4h3Y2iDGea25pfPqdOsMIUnpI1PDL+RUv
1/bB6Gol4Wt+izrI6nFxwxhHcP+KFhyyjvDArzbhCqXEUTU6LCevfY4z6AxYllpX
CJ3nPQwL1f5066TGU/CG6Mamz2uW+AhYpmKG8tqC1zz8b5BsUDRcNsCk2WhPzP3P
VzeRoQM51GtsR0iMi96prFNRRFNPuKf0bRiXw85jwYuEa4wS/MtbnIpBcm8lTSDS
WsHlq9YZDuNbWSV+jI2ze28YfJSVwz0FfSTYnjI3fXYwO7u1W7bjge0Bvjqoy9Bp
vl7oobOwsO7weo0i2Eh8XBshW+Y1ZV1+E57J2loxD2yD1uZrna+fmg9aswfXz9/d
iMVisEOW9zn6qdMBXwcvw97ZDsO2ceXaFzutQR2oXz29jzSCWpoQt11p2RwagBjX
wi+KPJF6c+O8a6JfFus9EXsX75uTrClJDgJs2gb97YAycLq6NpavCKStz9DMLE41
j/LlUJWGsYQ+Q+dvH33s9T13NTD+AWQi+Qm6CQUPdb/rFspy/dJnr9WXrGF8KIar
Qd+dRA1A9nB4+jc23JtQWlTpLmv13MJK
=eSsp
-----END PGP SIGNATURE-----
pgpdZ0a_vnRAg.pgp
Description: PGP signature
--- End Message ---
