Your message dated Sat, 08 Mar 2025 00:36:48 +0000
with message-id <[email protected]>
and subject line Bug#1092623: fixed in runit 2.2.0-1
has caused the Debian Bug report #1092623,
regarding runit: multiple build defects, mostly cosmetic and blhc false
positives
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1092623: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1092623
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: runit
Version: 2.1.2-60
Severity: normal
Dear Maintainer,
While investigating unstable results from the blhc test in runit's CI
pipeline on Salsa, I found a number of defects in the runit build system
in the version on the current next branch in the packaging repo. These
are mostly minor with varying impact but which I don't think warrant
individual bugs:
1) Interleaved build output with parallel make results in unpredictable
false positives from blhc, e.g.:
LDFLAGS missing (-Wl,-z,relro -Wl,-z,now): + exec cc -g -O2
-Werror=implicit-function-declaration
-D__DEB_CANARY_CFLAGS_06ee4c5c93a9957c9b1bb3bd89e800c8__
-ffile-prefix-map=/builds/abower/runit/debian/output/source_dir=.
-fstack-protector-strong -fstack-clash-protection -Wformat
-Werror=format-security -fcf-protection
-D__DEB_CANARY_CPPFLAGS_231141b34c82aa95e48810a9d1b33a79__ -Wdate-time
-D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration
-D__DEB_CANARY_CFLAGS_ebd9629fc3ae5e9f6611e2ee05a31cef__
-ffile-prefix-map=/builds/abower/runit/debian/output/source_dir=.
-fstack-protector-strong -fstack-clash-protection -Wformat./compile
stralloc_pend.c
Note in this example how it ends "-Wformat./compile stralloc_pend.c".
This is because the "./compile stralloc_pend.c" from another recipe has
been merged into the middle of another build command. This is why the
output from the tool never made sense and was impossible to investigate.
This can be worked around by not using parallel make but I think we can
do better than that!
2) Build flags are replicated.
This harms readability and could conceal other errors. I'm also not sure
if all the flags for all the tools always got passed in correctly
because of the rather eccentric way the runit build system is
constructed.
3) The debian build flag canaries were multiplied and inconsistent.
In the above example you can see two versions of the same ('CFLAGS')
canary in the same invocation; there were also different ones for the
contributed source files like shutdown.c. The build flags file got a
copy from a different dh build phase and the contrib'd builds from a
recursive make invocation that computer yet new ones.
4) Some of the feature test programs (tst*.c) had build errors with
recent compilers that were hidden and therefore resulted in the wrong
build choices being made silently. Some of these cases were handled in
#1075484.
I've set severity to 'normal' not 'minor' because there could be hidden
issues as a result of these, especially due to (4).
Thanks!
-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.12.6-amd64 (SMP w/24 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)
Versions of packages runit depends on:
ii libc6 2.40-5
ii runit-helper 2.16.4
ii sysuser-helper 1.5.0
Versions of packages runit recommends:
ii runit-run 2.1.2-60
Versions of packages runit suggests:
pn runit-services <none>
pn socklog <none>
pn ucspi-unix <none>
pn zsh <none>
-- Configuration Files:
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: runit
Source-Version: 2.2.0-1
Done: Lorenzo Puliti <[email protected]>
We believe that the bug you reported is fixed in the latest version of
runit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Lorenzo Puliti <[email protected]> (supplier of updated runit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 07 Mar 2025 18:39:40 +0100
Source: runit
Architecture: source
Version: 2.2.0-1
Distribution: unstable
Urgency: high
Maintainer: Lorenzo Puliti <[email protected]>
Changed-By: Lorenzo Puliti <[email protected]>
Closes: 1092623 1099717 1099752
Changes:
runit (2.2.0-1) unstable; urgency=medium
.
[ Lorenzo Puliti ]
* New upstream version 2.2.0
- see /usr/share/doc/runit/changelog.gz
* update upstream metadata
* d/copyright: update years
* d/patches (quilt):
- drop patches merged or rejected upstream
- squash and refresh patches for runsvdir-rescan-feature
- refresh, squash and rework forced rescan test
- refresh remaining patches
- sigpwr, sigalrm patches: reset sigint in stage 1 and 3
(Closes: #1099752)
* add missing conflicts: finit-sysv, daemontools-run
* salsa CI: disable missing breaks test, it fails with
diversions
* init-switch test: try to fix apt command line, mark as flaky
(Closes: #1099717)
* bump S-V to 4.7.2, no changes required
* runit-init: mask duplicate sysv scripts
* test for pkgblock files in stage 1 and run_sysv_scripts
* test for pkgblok files in default policy (override-sysv)
* run_sysv_scripts: test services links with -L
.
[ Andrew Bower ]
* stop build output interleaving leading to blhc false positives
(Closes: #1092623)
* pass all build flags through once.
* build contrib and write options from same dh target for stable canaries
Checksums-Sha1:
7c6c2d0029eb48460d5261321f663e4a36783aea 2190 runit_2.2.0-1.dsc
9864312f437f9d4d4b669c66c304a224e6f0979f 111395 runit_2.2.0.orig.tar.gz
9a8ae2704bc1f243e5b226ae9372f242215e2a02 69160 runit_2.2.0-1.debian.tar.xz
3b08e127e8265210ab3ddda7a917f97986549d2a 6602 runit_2.2.0-1_source.buildinfo
Checksums-Sha256:
dac6f68ac3809cb7bc75639d71aad7dae4cc6ac938d4fd291455e893ee5183a0 2190
runit_2.2.0-1.dsc
95ef4d2868b978c7179fe47901e5c578e11cf273d292bd6208bd3a7ccb029290 111395
runit_2.2.0.orig.tar.gz
1f08a42ef39f1e689610d968617b7ac338c67b86af81f77299eb8ba8fd3e9de6 69160
runit_2.2.0-1.debian.tar.xz
137893e409430070963b47f339c7c40372b623a21615fa3232a9fce0c4ab0360 6602
runit_2.2.0-1_source.buildinfo
Files:
00aa29ffdb7782783b3300390d4588d4 2190 admin optional runit_2.2.0-1.dsc
a3f8d44f0c2f3bb530f31fbb58f709ba 111395 admin optional runit_2.2.0.orig.tar.gz
f67b034ebc73861e7db5863bd134a8ab 69160 admin optional
runit_2.2.0-1.debian.tar.xz
49780dd4b7d9ac8d1c82a447cacdde93 6602 admin optional
runit_2.2.0-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmfLi+wACgkQKGv37813
JB6mFBAAmqGpaS4qEkWJ2QYc5dsL6TBueKGCmlh0RNIXHDxxuZbRi48IpdgzqV+c
y4lPZbjtgjZ5E1Ijr5Pav8U21No2G5SuExei5laL6qUndAn0yVTFV0dhhV+lO/15
tyGiz9m6rma8GoTlhJp7EXSHTBEl/Ie18jksgysnF6376wa2EPaVgb30RmAwLvZP
sp5Gu8WsbOVXrokQpousY6BnnA7sGvTtSiT4DxQZyykUkSsRxBV5BJlCdwyYBG6e
VHA8C9F6QfWYY8BPh8Be0b99VymmraOTKNLix6P1qzVY50q3nbP2QfLkJ/bt16ld
apPTkcdn1iOjeE8Q3pVJSu94h5QQp5xjkhjfK3iZeFrFN2rQw8dMn58DiT1wmWtq
hT/FxVrycGFUGAI7VSUaUE4vEtC2G2RvDne6qub8rgNzkBPq4T01Rbcww2VJi0u4
yI/40Qqt7KjRmKoE+Tv+LQNQtQpBdiHHurxUIqQ1pYUHQ5DWDcjE832XeGOsIiSf
Z8HZpkhmCCtMBtA1cTMGOGeZIot8am+kV9EE4ufdYYn0A7XYrJwnRKi5UHW79cbv
MXz8fX4QXrp5C7rSZqUvRhdcT/2bGp32JJy8ry3IuSMNtsMzfv+qDWFzUeX1vYrn
CfUuhJt5CjlFw8Ef8+fXYK9CXbWT344iRR+AUmXTnK8rFtBwjB8=
=vSEI
-----END PGP SIGNATURE-----
pgpVa2i5l2BlH.pgp
Description: PGP signature
--- End Message ---
