Your message dated Sat, 15 Mar 2025 21:48:50 +0000
with message-id <[email protected]>
and subject line Bug#1095954: fixed in shaderc 2025.1-1
has caused the Debian Bug report #1095954,
regarding shaderc: autopkgtest should not hard-code shaderc's dependencies
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1095954: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095954
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: shaderc
Version: 2024.4-1
Severity: normal
Tags: patch
The test in debian/tests/lib explicitly links the dummy binary to
libshaderc, but also to glslang and glslang's -lSPIRV:
> g++ -o $dummy_binary $dummy_source $(pkg-config --libs --cflags shaderc
> glslang spirv)
The intended design of pkg-config is that you only need to list packages
on the pkg-config command-line if you are explicitly calling functions
from those packages in your own source code. If an API user is only
calling functions from libshaderc, with the other packages being an
implementation detail of libshaderc (which seems to be true here),
then the API user shouldn't need to know about those libraries because
shaderc.pc should encapsulate all dependencies, via either Requires,
Libs/Cflags, or static linking.
So this would be a more thorough test if it was written like this:
#########
--- a/debian/tests/lib
+++ b/debian/tests/lib
@@ -26,6 +26,6 @@ int main() {
}
EOF
-g++ -o $dummy_binary $dummy_source $(pkg-config --libs --cflags shaderc
glslang spirv)
+g++ -o $dummy_binary $dummy_source $(pkg-config --libs --cflags shaderc)
test -x $dummy_binary
./$dummy_binary
#########
and in particular that would probably have been enough to detect #1029939
without needing to write extra test code.
If the more thorough version of the autopkgtest starts failing, then that
would indicate that either shaderc.pc is incomplete and needs more Requires,
Libs or Cflags to be added, or the shared library is "underlinked" similar
to #1029939.
Thanks,
smcv
--- End Message ---
--- Begin Message ---
Source: shaderc
Source-Version: 2025.1-1
Done: Philippe SWARTVAGHER <[email protected]>
We believe that the bug you reported is fixed in the latest version of
shaderc, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Philippe SWARTVAGHER <[email protected]> (supplier of updated shaderc package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 15 Mar 2025 21:40:53 +0100
Source: shaderc
Architecture: source
Version: 2025.1-1
Distribution: unstable
Urgency: medium
Maintainer: Philippe SWARTVAGHER <[email protected]>
Changed-By: Philippe SWARTVAGHER <[email protected]>
Closes: 1095954
Changes:
shaderc (2025.1-1) unstable; urgency=medium
.
* New upstream release
* Improve d/tests/lib. Thanks to Simon McVittie! Closes: #1095954
* Bump Standards-Version to 4.7.2: no change needed
Checksums-Sha1:
9d8accbd182234c08e6adc71a36ebecfa42b9d72 2102 shaderc_2025.1-1.dsc
86174cf0498e70a992ae90a1355773ea18204768 228284 shaderc_2025.1.orig.tar.gz
a8cc1eac0d162253521769356809f982f749fcb3 6488 shaderc_2025.1-1.debian.tar.xz
891b1f8cd3c52feb26d578bfcab25ebe414a401c 7779 shaderc_2025.1-1_source.buildinfo
Checksums-Sha256:
c37f12011b9e1b3e3c903897b2973c6aacc0d62e2cd5ec879f250577743d1f01 2102
shaderc_2025.1-1.dsc
358f9fa87b503bc7a3efe1575fbf581fca7f16dbc6d502ea2b02628d2d0d4014 228284
shaderc_2025.1.orig.tar.gz
05109e29378ac6c5fac1486cbef7bd0ce415b31dffdd32df192b8dd09b1eca47 6488
shaderc_2025.1-1.debian.tar.xz
a0dcc073abcfa83f83996d8f7a3bb86035ec684a781bec003fa23ad36d2f9c1f 7779
shaderc_2025.1-1_source.buildinfo
Files:
3a5ddd1efa4c63bcdb65de25ecbc087c 2102 libs optional shaderc_2025.1-1.dsc
bf8395076fccc60c891b719d878385f0 228284 libs optional
shaderc_2025.1.orig.tar.gz
b6ee91593211bfb29f194de9c9212194 6488 libs optional
shaderc_2025.1-1.debian.tar.xz
df2062065dc7729951628ac7ac9c054a 7779 libs optional
shaderc_2025.1-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEElCosF0VHmbVi40EnbsPBBpPAkMMFAmfV5t4SHHBoaWwuc3dh
cnRAZ214LmZyAAoJEG7DwQaTwJDDj2YP/1ztZ2/QQbn9K2/Ip+94B4GoH08wnDB1
Cb9qLWtuNJ1wV65CrRUZQG5B/atfcnn9HqNEkE9f//ZPKOOzes55KIEaD8kL6Q0W
Rc1+ALrjfr0BMABFNS5DsWCUceXaUWSN/BJz9JAh0Cg1GG244K50JWz0hyCW3xN8
8l5rkI3L+GPLd8NTQocmZb2faLMDJz06UxbDj42mYMbjkkXu8fW3v4pO/zMR1tAm
8MRoc1HUwDi8VyZ1/CYCN/4NweCgdMeu1hSKckrasJoQJFoS+KsRX8BswpEZCLWs
pIfyxLQ7urHWEawI9U2AYaty3d77RiitcMn8xvywFkC3GhWSUArZN5sL8D2UmFF1
QtT+cYuYQL0mSW8RnnHTitCbWmz9+dnnKjLe70a2KtHo7mi8l63OtO5AW+9w7Bw5
8lS5wEfSu+T9a3kQLXJllxHDf9D5lyXB0zOc/iNMAPyyJHH/pG4hiTEFq5EEW9VR
Y07ZpZ240rSTQNFtazr/liUu03XRN83lOsLT+FC4gk7eqL/ULAkTwR4UTgh3oqVC
C1evvnYVz3QSNTs9KJ3USdX1eaMdRYE1xWCZqgSVdgrR+9exaI4SWcQiQ7Ol0ACL
ZccJ3T9DUC3Tabs6ZNvQCo+HjIQdyl8SZchIOEk6oGNmUglVZuy4dswBaPIF4Ozf
pqGr8O+LEC13
=he62
-----END PGP SIGNATURE-----
pgp5iiYPcwD7H.pgp
Description: PGP signature
--- End Message ---
