Your message dated Mon, 31 Mar 2025 04:05:00 +0000
with message-id <[email protected]>
and subject line Bug#1101690: fixed in dgit 12.11
has caused the Debian Bug report #1101690,
regarding dgit: tests: tag2upload-oracled process leak, external lossage
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1101690: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101690
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: dgit
Version: 12.7
Severity: normal
I was doing some work which involved repeatedly running
tests/using-intree tests/tests/drs-push-masterupdate
This test case doesn't involve tag2upload oracled.
For Reasons I ended up removing tests/tmp.
I discovered that something was recreating
tests/tmp/tag2upload-oracled
That must have been a leftover process from a previous run of the
tag2upload-oracled test case.
Even removing tests/tmp was not sufficient. It got recreated.
I ran ps -Hfuian | grep tag2 and found only this and my emacs:
ian 25301 1 0 Mar22 pts/198 00:03:49 /usr/bin/perl
/home/ian/things/Dgit/dgit/infra/tag2upload-oracled -D
--adt-virt=/home/ian/things/Dgit/dgit/tests/autopkgtest-virt-null-for-test
--retain-tmp --builder=builder@t2u-b --noreply=test-dummy t2u service
<[email protected]> [email protected]
[email protected] --worker-restart-timeout=4
--ssh=/home/ian/things/Dgit/dgit/tests/ssh --manager=t2u-service-manager-host
--manager-socket=/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/o2m.s
test-dummy
/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/distro=test-dummy
/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/dd.gpg,a:/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/t2uokr.gpg,a:/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/dm.gpg,m/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/dm.txt
ian 17838 1 0 Mar21 pts/51 00:04:06 /usr/bin/perl
/home/ian/things/Dgit/dgit/infra/tag2upload-oracled -D
--adt-virt=/home/ian/things/Dgit/dgit/tests/autopkgtest-virt-null-for-test
--retain-tmp --builder=builder@t2u-b --noreply=test-dummy t2u service
<[email protected]> [email protected]
[email protected] --worker-restart-timeout=4
--ssh=/home/ian/things/Dgit/dgit/tests/ssh --manager=t2u-service-manager-host
--manager-socket=/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/o2m.s
test-dummy
/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/distro=test-dummy
/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/dd.gpg,a:/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/t2uokr.gpg,a:/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/dm.gpg,m/home/ian/things/Dgit/dgit/tests/tmp/tag2upload-oracled/dm.txt
I ran this ps more than once, and the pids didn't change.
But I sadly didn't get a whole process tree so I don't know which
other things might have been running. It seems likely that some shell
script from the test suite was also implicated.
Then I ran killall tag2upload-oracled. When I did that,
* My music player stopped
* My several web browsers disappeared
* Now I have an emacs which seems to be spinning on the CPU
I think there are at two problems here:
1. tag2upload-oracled ought not to use mkdir -p (creating parent
directories). It ought to crash instead, when its directory is
removed. It's possible that the mkdir -p isn't in oracled itself;
it might be in d-r-s or one of the stunt test scripts.
2. Something did a bunch of wild kills causing serious lossage to
my normal desktop session. I guess I'll have to reboot now since
I don't know what else might have been affected.
Note the date on those processes. They will be from an earlier
version of tag2upload-oracled. That will also be the case for running
shell scripts. But if they executed anything from the test suite, it
would be the *new* code. (Shell scripts can be afflicted by weird
behaviour if you modify the script under their feet.)
-- System Information:
Debian Release: trixie/sid
APT prefers testing-debug
APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 6.12.11-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled
--- End Message ---
--- Begin Message ---
Source: dgit
Source-Version: 12.11
Done: Sean Whitton <[email protected]>
We believe that the bug you reported is fixed in the latest version of
dgit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sean Whitton <[email protected]> (supplier of updated dgit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 31 Mar 2025 11:45:54 +0800
Source: dgit
Architecture: source
Version: 12.11
Distribution: unstable
Urgency: high
Maintainer: Ian Jackson <[email protected]>
Changed-By: Sean Whitton <[email protected]>
Closes: 1101690
Changes:
dgit (12.11) unstable; urgency=high
.
dgit, dgit-repos-server, Dgit.pm [Ian Jackson]:
* Install countermeasures for 'rm -r' failure (see #1101580).
* Replace File::Path::rmtree with a subroutine of our own.
.
tag2upload-oracled [Ian Jackson]:
* Fix worker PID tracking, and rigorously avoid sending wild signals.
Closes: #1101690.
* Do not ignore SIGCHLD.
* Quit if the link count of the workercwd becomes zero.
.
Test suite:
* autopkgtest-virt-null-for-test: Avoid 'mkdir -p'.
Don't recreate the whole test's $tmp directory from here. [Ian Jackson]
* autopkgtest-virt-null-for-test: Always set TMPDIR.
In particular, when autopkgtest is new enough not to require workarounds.
[Ian Jackson]
* tag-updates test: Fix $tagname variable.
Broken for a while, revealed by git 2.49.0 hitting sid.
Checksums-Sha1:
415c57ee5a9c9e361322df1b525796fb489fc099 2351 dgit_12.11.dsc
0c90a08ef74d8054d4b3e1306b2d29425b9177e7 755408 dgit_12.11.tar.gz
Checksums-Sha256:
34a869241f3098ede9d936fc902228d17e044522ccccc9a83975268f406847d8 2351
dgit_12.11.dsc
01860c00b7db3f63ef7ee0d4ea1c6962eef2440448e68deb85cb11753d0f83e2 755408
dgit_12.11.tar.gz
Files:
e4db64596ef1ae25ed411a2308ca7c66 2351 devel optional dgit_12.11.dsc
62f2a34845aa27ff8420920b11b56ea6 755408 devel optional dgit_12.11.tar.gz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmfqECcACgkQaVt65L8G
YkBNyRAAk+94D2rxik+oiQ3wmtgqwfMeJUUztTafGfMh5fYTYjhopgflxjGxMjhZ
0XRKic0xC348KhxaJp+TMXWwPoF4+VkpRc4AuQYtBn0pFbB4Tvv3I3J+PynPJamn
pcFqQJbOYwwppwm149nwyyzuY485BLrlMg1UqrL46lUmo/OyyEjSD6brNp321kko
9jEpaeVXI6piV8BidRMCiT2Xrc76KtiCs8XgZlWNBtuULTSiW2DpbAygQ5hgHMmi
Lachss1zt+7CVtASuuICORI5TWL0nJEK1io4dCXtgDQuQw1MTfcQi3Ah1FRFcIbH
dK5kiMdgsjgTQFvDLxA7yA4QmUlXrByT2IUp0KpaIrljVngibDBaL+36WgPR5uPn
a0U5TYc/y8H62sK7MoZ1RJsBufsHR4g0P33fgJJtLzE3VyVRBml2U4CgcbpU4vxz
QGglceFFcpiafzujZTpYYAmRi2CPCZj1keVyq1xLGQc8lY59tWSESOCvNTOZpfJ5
VV78G+pNDY8pONTj+XnI2VbOghINXRpw97CMPrsB26BWAdOEo5bfl1lAnEVjX6EX
VjiJIuSbGy8+hWT4uq7RL68wKI4qQYTD6KMLuQ74yJL2XoSm9h2kR1/vyUa05zR/
jg2WkSHNLZiJ7WmWbDusOaTBBN94LNWA7cHsgsZ8fJ/e45XUJr0=
=wYNO
-----END PGP SIGNATURE-----
pgpc31GGp3aiH.pgp
Description: PGP signature
--- End Message ---
