Your message dated Tue, 01 Apr 2025 20:42:24 +0000
with message-id <[email protected]>
and subject line Bug#1094790: fixed in tuned 2.25.1-1
has caused the Debian Bug report #1094790,
regarding tuned: kernel cmdline tunings are not applied when booting from grub 
submenus
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1094790: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094790
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tuned
Version: 2.20.0-1
Severity: normal
Tags: patch upstream
X-Debbugs-Cc: [email protected]

Dear Maintainer,

In grub, the system can be booted from the main menu (first screen we
see), or submenus "Advanced options for Debian GNU/Linux".

When tuned is active, grub.cfg looks like this (edited for clarity):
set tuned_params="skew_tick=1 isolcpus=managed_irq,domain, intel_pstate=disable 
nosoftlockup tsc=reliable"
[...]
menuentry 'Debian GNU/Linux' [...] {
  [...]
  linux  /vmlinuz-6.1.0-30-amd64 root=/dev/mapper/debian--vm--vg-root ro  quiet 
$tuned_params
submenu 'Advanced options for Debian GNU/Linux' [...] {
  menuentry 'Debian GNU/Linux, with Linux 6.1.0-30-amd64' [...] {
    [...]
    linux  /vmlinuz-6.1.0-30-amd64 root=/dev/mapper/debian--vm--vg-root ro  
quiet $tuned_params

$tuned_params is effectly extended when using the main menu "Debian GNU/Linux"
but not when using the submenu
"Advanced options for Debian GNU/Linux>Advanced options for Debian GNU/Linux"

This is because $tuned_params is not exported. See:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094201#10

I've sent a patch upstream (now merged):
https://github.com/redhat-performance/tuned/commit/e9f0f228b3a452d6575ab17f186fe44d1ad50282

If that's possible, I would very much appreciate having this patch on
stable. I guess most users boot from the main menu but I plan to use
submenus on a project.

Thanks!
-- System Information:
Debian Release: 12.9
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 
'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-30-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages tuned depends on:
ii  dbus                  1.14.10-1~deb12u1
ii  ethtool               1:6.1-1
ii  gawk                  1:5.2.1-2
ii  polkitd               122-3
ii  procps                2:4.0.2-3
ii  python3               3.11.2-1+b1
ii  python3-dbus          1.3.2-4+b1
ii  python3-gi            3.42.2-3+b1
ii  python3-linux-procfs  0.6.3-1.1+b2
ii  python3-pyudev        0.24.0-1
ii  virt-what             1.25-1

Versions of packages tuned recommends:
ii  dmidecode       3.4-1
ii  hdparm          9.65+ds-1
ii  iproute2        6.1.0-3
ii  kmod            30+20221128-1
ii  linux-cpupower  6.1.124-1

tuned suggests no packages.

-- Configuration Files:
/etc/tuned/active_profile changed:
realtime

/etc/tuned/bootcmdline changed:
TUNED_BOOT_CMDLINE="skew_tick=1 isolcpus=managed_irq,domain, 
intel_pstate=disable nosoftlockup tsc=reliable"
TUNED_BOOT_INITRD_ADD=""

/etc/tuned/profile_mode changed:
manual


-- no debconf information
>From e9f0f228b3a452d6575ab17f186fe44d1ad50282 Mon Sep 17 00:00:00 2001
From: Yoann Congal <[email protected]>
Date: Mon, 27 Jan 2025 11:56:50 +0100
Subject: [PATCH] bootloader: export Grub variables to make them available in
 submenus

Without exporting the grub variables, they are only available in the
main grub menu[0]. When descending in a submenu (like in default Debian for
example), tuned_* variable are expanded to the empty string and, so,
tuned kernel cmdline tuning is effectively disabled.

With the export, variables are available in submenus and tuned tuning is
applied as expected.

[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094201#10

Signed-off-by: Yoann Congal <[email protected]>
---
 00_tuned | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/00_tuned b/00_tuned
index 4a14be6..86938ce 100644
--- a/00_tuned
+++ b/00_tuned
@@ -26,4 +26,6 @@ tuned_bootcmdline_file=$tunedcfgdir/bootcmdline
 . $tuned_bootcmdline_file
 
 echo "set tuned_params=\"$TUNED_BOOT_CMDLINE\""
+echo "export tuned_params"
 echo "set tuned_initrd=\"$TUNED_BOOT_INITRD_ADD\""
+echo "export tuned_initrd"

--- End Message ---
--- Begin Message ---
Source: tuned
Source-Version: 2.25.1-1
Done: Evgeni Golov <[email protected]>

We believe that the bug you reported is fixed in the latest version of
tuned, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Evgeni Golov <[email protected]> (supplier of updated tuned package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 01 Apr 2025 21:43:33 +0200
Source: tuned
Architecture: source
Version: 2.25.1-1
Distribution: unstable
Urgency: medium
Maintainer: Evgeni Golov <[email protected]>
Changed-By: Evgeni Golov <[email protected]>
Closes: 1094790 1100608
Changes:
 tuned (2.25.1-1) unstable; urgency=medium
 .
   * New upstream release (Closes: #1094790)
   * Support the new UPower PPD namespace (Closes: #1100608)
   * Depend on python3-pyinotify
Checksums-Sha1:
 b2fe761923e1879360caea3852d2d72a8dab9189 2176 tuned_2.25.1-1.dsc
 2041e65c2e31cd76c60c401bdf538eb4253ea7b4 268726 tuned_2.25.1.orig.tar.gz
 577eb3b2f591a0be7bc6ac67aaf99280d4c299c6 8332 tuned_2.25.1-1.debian.tar.xz
 b4993f144a06e9d67d0a1b07371cc52f0d4a7c82 7559 tuned_2.25.1-1_source.buildinfo
Checksums-Sha256:
 36a939348e01825533c53d7b9e56f7a37a0a39398f0805c546dade2b975cd32e 2176 
tuned_2.25.1-1.dsc
 ffdd57d37fadcba78df1910b340b1a35ffa15245b84a3cabe86c4a0625928375 268726 
tuned_2.25.1.orig.tar.gz
 55aea86d50e5d92aa97a2c1ec06f90d79f4246ed6c5f3d6189973f0ee9cd2b51 8332 
tuned_2.25.1-1.debian.tar.xz
 aa088b50a243a0355b095940fafe3a474a6f7f479c7fb5f443669bba114e9fa2 7559 
tuned_2.25.1-1_source.buildinfo
Files:
 217928a5744737f475b8239e9f89e9c6 2176 admin optional tuned_2.25.1-1.dsc
 f635ac15a8bf8109017f30825c1821b8 268726 admin optional tuned_2.25.1.orig.tar.gz
 25338bdadec030ef997d40448a5b6662 8332 admin optional 
tuned_2.25.1-1.debian.tar.xz
 615c95d5078a018412c870d3b41d3ab4 7559 admin optional 
tuned_2.25.1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEExW57amdnGPa81AdGTrsFQAtaiq4FAmfsSxQACgkQTrsFQAta
iq7D2Q//fAdd/Wybk6AnQpqf02ZC+XdPVzZeVoiDt3c8oCgI4okJ1nlpYZiPitfI
z/D0n5yeMzeG3ZmTBc+wBKrO2i+nJARrcieQLB+HvHKEOmV1iWDViPditlTG/YbU
bAbvScgJvBQIXjvkn2bsA8knTDu6QMWewNRVc5mc8PgQCkCm1NPWrOMhpLhbbtB3
VslwY9pIAekozbmE6mbNsdrPl0OmUQE0iVteD7OA8HV3CFPR22j5k62WzG+CrcDy
MmkMhW8DtFGLv0xAeYfFqdekqqoLcHlEo78ofa2MvwRocxwWIFwV00azGvOCJx4J
RkhD178o7hFAeg5yaCIfkDGcftgVcfNPW61SRdVsNEpnZRPuXNc83rhXt+uFOL0B
wGMEYg57zcjKOcRncIrwXIrxQvKdLQGG8POaWfYRerOf24IBmxpKpE32LVEzHxnt
MSi1oJPuspQYDQPeYHUHLJ6nXgxQJJbg7MTtyNWHxyppIxgHyu5SlMM1ADl7CMI9
i8v9U5licn1o9DH8kiTUKxBN0FEOqbe5pBz5RSAF4pkVGhTuyujqSQcCmOD/ht22
ALw5xgKSYirf0HTc458tx7hsvuHfxto2XjgfToJFs35CVRIB9vmfSy5dlhtEAXkk
FpCGidaSXNtQv2GwH7a1tEvt0cYzDb6wKUE0li6go7FwIsHlXMI=
=NnJF
-----END PGP SIGNATURE-----

Attachment: pgpnMVGl4A042.pgp
Description: PGP signature


--- End Message ---

Reply via email to