Your message dated Thu, 03 Aug 2006 09:18:46 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#379979: fixed in dbconfig-common 1.8.18
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: dbconfig-common
Version: 1.8.17
Severity: wishlist
Tags: patch

Hello,

The generated include for file type PHP ends in '?>'. I kindly request
that that be removed.

The problem is that everything after that tag will be output to the
browser, and that can cause trouble if there's e.g. some stray
whitespace after it, which can mess up the sending of headers or the
integrity of binary files sent with PHP.

The closing tag is not needed and doesn't have a function: you switch
the context from code to literal and right after it terminate the file,
making the context irrelevant.

Please consider to apply this patch. Thanks.


Thijs

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-1-k7
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages dbconfig-common depends on:
ii  debconf [debconf-2.0]         1.5.2      Debian configuration management sy
ii  pwgen                         2.05-1     Automatic Password generation
ii  ucf                           2.0012     Update Configuration File: preserv

dbconfig-common recommends no packages.

-- debconf information excluded
diff -ur dbconfig-common-1.8.17.orig/dbconfig-generate-include 
dbconfig-common-1.8.17/dbconfig-generate-include
--- dbconfig-common-1.8.17.orig/dbconfig-generate-include       2006-04-23 
18:58:48.000000000 +0200
+++ dbconfig-common-1.8.17/dbconfig-generate-include    2006-07-26 
18:38:38.000000000 +0200
@@ -266,7 +266,6 @@
        [ "$use_dbport" ] && echo 
"${comment_dbport}\$$dbport_varname='$dbc_dbport';"
        [ "$use_dbtype" ] && echo 
"${comment_dbtype}\$$dbtype_varname='$dbc_dbtype';"
        cat << EOF 
-?>
 EOF
 ;;
 
diff -ur dbconfig-common-1.8.17.orig/dbconfig-load-include 
dbconfig-common-1.8.17/dbconfig-load-include
--- dbconfig-common-1.8.17.orig/dbconfig-load-include   2006-04-02 
17:26:06.000000000 +0200
+++ dbconfig-common-1.8.17/dbconfig-load-include        2006-07-26 
18:38:49.000000000 +0200
@@ -196,7 +196,6 @@
                echo "dbc_dbport='\$$dbport_varname';\n";
        if(!empty(\$use_dbtype) && isset(\$$dbtype_varname)) 
                echo "dbc_dbtype='\$$dbtype_varname';\n";
-?>
 EOF
 ;;
 

--- End Message ---
--- Begin Message ---
Source: dbconfig-common
Source-Version: 1.8.18

We believe that the bug you reported is fixed in the latest version of
dbconfig-common, which is due to be installed in the Debian FTP archive:

dbconfig-common_1.8.18.dsc
  to pool/main/d/dbconfig-common/dbconfig-common_1.8.18.dsc
dbconfig-common_1.8.18.tar.gz
  to pool/main/d/dbconfig-common/dbconfig-common_1.8.18.tar.gz
dbconfig-common_1.8.18_all.deb
  to pool/main/d/dbconfig-common/dbconfig-common_1.8.18_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
sean finney <[EMAIL PROTECTED]> (supplier of updated dbconfig-common package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 02 Aug 2006 17:08:29 -0700
Source: dbconfig-common
Binary: dbconfig-common
Architecture: source all
Version: 1.8.18
Distribution: unstable
Urgency: low
Maintainer: sean finney <[EMAIL PROTECTED]>
Changed-By: sean finney <[EMAIL PROTECTED]>
Description: 
 dbconfig-common - common framework for packaging database applications
Closes: 378769 379979 380353
Changes: 
 dbconfig-common (1.8.18) unstable; urgency=low
 .
   [ sean finney ]
   * no longer end php-style generated files with a ?>, as it's
     superfluous and can reportedly cause problems (closes: #379979).
     thanks to Thijs Kinkhorst for pointing this out.
   * other changes/fixes from Thijs Kinkhorst:
     - utf8 fix in changelog
     - update standards version to 3.7.2
     - lintian overrides for false-positives due to the example packages
     closes: #380353
   * updated danish debconf translations from Claus Hindsgaul, thanks.
     closes: #378769
   * fixed/improved pgsql authentication method autodetection.
   * new db-test-pgsql-migration-{1.9,2.0} packages to both show and
     test how to migrate from previous non-dbc packaging.
   * fix for sh-format include files from dbconfig-load-include.  thanks
     to Torsten Werner for finding this problem.
   * remove import-oldsettings template, i don't think the need
     merits having it.
   * packages that migrate to dbconfig-common no longer get the confusing
     installation question.
   * remove date from the d-g-i generated config files, to reduce
     any ucf noise.
 .
   [ Bart Cornelis (cobaco) ]
   * Updated Dutch translation
Files: 
 e32ebd8f630e43a4ce477cd031d0c1ac 549 admin optional dbconfig-common_1.8.18.dsc
 23083c9cfff2f6d3aee7bce4efe7a724 335064 admin optional 
dbconfig-common_1.8.18.tar.gz
 93b6b61362e2aff39afad0adcfd9cde8 400952 admin optional 
dbconfig-common_1.8.18_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFE0VBJynjLPm522B0RAroqAJ9O/jt3Ddm55fNS/KNsuv0zuR8MhwCfXyVR
6C7efV7r8u4zEOiY/SS2k+g=
=T+Hm
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to