Your message dated Thu, 24 Apr 2025 22:49:35 +0000
with message-id <[email protected]>
and subject line Bug#346447: fixed in gopher 3.0.18
has caused the Debian Bug report #346447,
regarding gopher: FTBFS on hurd-i386: Unconditional use of system limit macros
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
346447: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=346447
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gopher
Version: 3.0.11
Severity: important
Tags: patch
Hi,
your package failed to autobuild:
Automatic build of gopher_3.0.11 on beethoven by sbuild/hurd-i386 69
Build started at 20051207-1916
******************************************************************************
[...]
Checking correctness of source dependencies...
Toolchain package versions: libc0.3-dev_2.3.5-6 gcc-4.0_4.0.2-4 g++-4.0_4.0.2-4
binutils_2.16.1-2 libstdc++6-4.0-dev_4.0.2-4 libstdc++6_4.0.2-4
------------------------------------------------------------------------------
dpkg-source: extracting gopher in gopher-3.0.11
dpkg-source: unpacking gopher_3.0.11.tar.gz
dpkg-buildpackage: source package is gopher
dpkg-buildpackage: source version is 3.0.11
dpkg-buildpackage: host architecture hurd-i386
[...]
gcc -g -O2 -Wall -I.. -I.. -I../object -DNOBANNER -DCTRLCPROMPTS -DCONTROLX
-DGOPHERLIB=\"//etc/gopher\" -DGOPHERHELP=\"//etc/gopher/gopher.hlp\"
-DGLOBALRC=\"//etc/gopher/gopher.rc\"
-DREMOTERC=\"//etc/gopher/gopherremote.rc\" -c download.c
download.c: In function 'Download_file':
download.c:202: error: 'MAXPATHLEN' undeclared (first use in this function)
download.c:202: error: (Each undeclared identifier is reported only once
download.c:202: error: for each function it appears in.)
download.c:235: warning: null argument where non-null required (argument 2)
download.c:235: warning: null argument where non-null required (argument 2)
download.c:237: warning: null argument where non-null required (argument 2)
download.c:237: warning: null argument where non-null required (argument 2)
download.c: In function 'BuiltinDownload':
download.c:368: error: 'MAXPATHLEN' undeclared (first use in this function)
make[2]: *** [download.o] Error 1
make[2]: Leaving directory `/build/buildd/gopher-3.0.11/gopher'
make[1]: *** [gopher/gopher] Error 2
make[1]: Leaving directory `/build/buildd/gopher-3.0.11'
make: *** [build-stamp] Error 2
******************************************************************************
Build finished at 20051207-1919
FAILED [dpkg-buildpackage died]
MAXPATHLEN is not defined on the GNU system, as there is no maximum path
lenght. The attached patch by Ben Asselstine fixes this. As gopher is
a Debian native package, can I assume that you are upstream as well, so
no further notification is needed?
thanks,
Michael
diff -uNrd gopher-3.0.11.orig/gopher/download.c gopher-3.0.11/gopher/download.c
--- gopher-3.0.11.orig/gopher/download.c 2006-01-07 14:22:03.000000000
-0500
+++ gopher-3.0.11/gopher/download.c 2006-01-07 14:42:53.000000000 -0500
@@ -198,7 +198,7 @@
int start, end;
struct stat buf;
-#if defined(HAVE_GETCWD) || !defined(HAVE_GET_CURRENT_DIR_NAME)
+#if defined(HAVE_GETCWD) && !defined(HAVE_GET_CURRENT_DIR_NAME)
curcwd = (char *) malloc(MAXPATHLEN + 2);
if (!curcwd) {
CursesErrorMsg("Out of memory.");
@@ -255,15 +255,15 @@
}
}
-#ifdef HAVE_GETCWD
- getcwd(curcwd, MAXPATHLEN);
-#else
#ifdef HAVE_GET_CURRENT_DIR_NAME
curcwd = get_current_dir_name();
#else
+#ifdef HAVE_GETCWD
+ getcwd(curcwd, MAXPATHLEN);
+#else
getwd(curcwd);
-#endif /* HAVE_GETCWD */
-#endif
+#endif
+#endif /* HAVE_GET_CURRENT_DIR_NAME */
#ifdef VMS
if (chdir("SYS$SCRATCH")!=0) {
@@ -364,7 +364,7 @@
GopherObj *gs;
-#if defined(HAVE_GETCWD) || !defined(HAVE_GET_CURRENT_DIR_NAME)
+#if defined(HAVE_GETCWD) && !defined(HAVE_GET_CURRENT_DIR_NAME)
tmppath = (char*)malloc(MAXPATHLEN * 3 + 2);
if ( !tmppath ) {
CursesErrorMsg("Cannot allocate memory");
@@ -401,9 +401,6 @@
GSsetPath(gs, names[choice]);
-#ifdef HAVE_GETCWD
- getcwd(tmppath,MAXPATHLEN);
-#else
#ifdef HAVE_GET_CURRENT_DIR_NAME
tmppath = get_current_dir_name();
if ( sizeof(tmppath) <= (strlen(tmppath) + strlen(names[choice]) + 1) )
@@ -413,6 +410,9 @@
return;
}
#else
+#ifdef HAVE_GETCWD
+ getcwd(tmppath,MAXPATHLEN);
+#else
getwd(tmppath);
#endif
#endif
--- End Message ---
--- Begin Message ---
Source: gopher
Source-Version: 3.0.18
Done: John Goerzen <[email protected]>
We believe that the bug you reported is fixed in the latest version of
gopher, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
John Goerzen <[email protected]> (supplier of updated gopher package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 24 Apr 2025 17:32:53 -0500
Source: gopher
Architecture: source
Version: 3.0.18
Distribution: unstable
Urgency: medium
Maintainer: John Goerzen <[email protected]>
Changed-By: John Goerzen <[email protected]>
Closes: 346447
Changes:
gopher (3.0.18) unstable; urgency=medium
.
* Apply Hurd compatibility patch from João Pedro Malhado.
Closes: #346447.
* Added Vcs lines to debian/control.
* Updated homepage in debian/copyright.
Checksums-Sha1:
54b579264ba9b7f3887a7f02ab975d08afdc5161 1516 gopher_3.0.18.dsc
0d5a2449ed0d30fa186ca90ea0b476315f71c15f 241464 gopher_3.0.18.tar.xz
7cd59b6499b76bb6e6e3ed56827b041cd7e84186 6820 gopher_3.0.18_source.buildinfo
Checksums-Sha256:
14046b2ccbda78805fa21fcbbfc69075883a855556498667ce967aa9226385c1 1516
gopher_3.0.18.dsc
b1cc8e6da3dea9ae331e577531234c1aadfd330d29f7aa302ffbd76c0ddd8dfd 241464
gopher_3.0.18.tar.xz
b332e17656be3e50925b28667a794cba5bae33689f76705ca8f45e7cfb49a3af 6820
gopher_3.0.18_source.buildinfo
Files:
e2b32f7434dc6eb1a58746291f1c1ba3 1516 net optional gopher_3.0.18.dsc
8704ce38cc44af0b8ba9f0a226ac1082 241464 net optional gopher_3.0.18.tar.xz
9dbc92f38eb79e105922d208e63d3537 6820 net optional
gopher_3.0.18_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEJ217d7abdWx8toZp3Sn4hEKDntMFAmgKvTkACgkQ3Sn4hEKD
ntOrAQ//eWnm6c6uDwEeSiFKPLH61F/RuC30umVBVPkE6ORD7wvjFEGipN2/shBg
+lN11SQ7QrvcG2xDPee1GDku/xr2+uHVFpgwt945vAXyLBbrq1ep0z6RSxiOPxsV
mGmUKvVwzVuhwbzNGOJqc4J5b6nw9APz7qtj1XFRwhtpXrf2SyGzPnBgQ/yskdwO
ZS9WG3mJnphq1RBQgjisLTZUeyF60bdtRNwtqRaOUSf7qBW9Yf3+Yaam7ghgqc93
t9PQD9tppGYiGpTXOPe94yoFX5oOsNwQefIfj7SZ47hXtUVQtCW30OhOnIOWgs9O
fb+GHQKTJvxSCe2AngbWbp079SGSglkQ8yqgHyR3y+gmYBNCtPgbifVeBkQj5uDQ
831QqnL55qLYJfVlGE7n/4V0g4SQNGZoMXrXaUrecls7mSviQcn2ES5FPL99Ixwi
uA+GO2ECFucHEtkrMD+lKqAUmD9i2jnueBsKCY/E2RNdgqJn289xpmYdFxmnlYaG
BAjSRw6xAnea0lTcpf9J9icdaeaLUWffgKCs4ioAU0XzMsXVizX/vXi2iAUlW+VG
kU6UEJxutRuKuSUtznNsSKVXlV2/yIsdnVlqHuCJRdIPqoqszeSVgeQ0Q8MwEXmO
lIo16dT8ENWs1CdtRUeivmHL42l4NtO/4Iljk+VsbzAXhBw1il0=
=qDU5
-----END PGP SIGNATURE-----
pgp7rgKl3D6vc.pgp
Description: PGP signature
--- End Message ---