Your message dated Fri, 02 May 2025 15:40:12 +0000
with message-id <[email protected]>
and subject line Bug#1104553: fixed in sbuild 0.89.2
has caused the Debian Bug report #1104553,
regarding sbuild: support --no-enable-network on the schroot backend
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1104553: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1104553
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: sbuild
Tags: moreinfo patch
X-Debbugs-Cc: [email protected]
Hi,
I noticed that sbuild --mode=schroot does not support --no-enable
network. As it happens, unschroot[1] supports --isolate-network and all
that's missing here is passing that flag. Of course, that's not the
default schroot implementation and schroot may end up using a different
flag name. Still, I'm posting the patch that makes it work practically
for future reference.
Helmut
[1]
https://git.subdivi.de/~helmut/python-linuxnamespaces.git/tree/examples/unschroot.py
--- a/usr/share/perl5/Sbuild/ChrootSchroot.pm
+++ b/usr/share/perl5/Sbuild/ChrootSchroot.pm
@@ -107,12 +107,14 @@
my $self = shift;
my $dir = shift;
my $user = shift;
+ my $disable_network = shift // 0;
return ($self->get_conf('SCHROOT'),
'-d', $dir,
'-c', $self->get('Session ID'),
'--run-session',
@{$self->get_conf('SCHROOT_OPTIONS')},
+ $disable_network ? ('--isolate-network') : (),
'-u', "$user", '-p', '--');
}
@@ -134,7 +136,11 @@
my $disable_network = 0;
if (defined($options->{'ENABLE_NETWORK'}) && $options->{'ENABLE_NETWORK'} == 0) {
- print STDERR "Disabling the network for this command was requested but the schroot backend doesn't support this feature yet: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802849\n"; if $self->get_conf('DEBUG');
+ if ($self->get_conf('SCHROOT') =~ /unschroot/) {
+ $disable_network = 1;
+ } else {
+ print STDERR "Disabling the network for this command was requested but the schroot backend doesn't support this feature yet: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802849\n"; if $self->get_conf('DEBUG');
+ }
}
# Command to run. If I have a string, use it. Otherwise use the list-ref
@@ -156,7 +162,7 @@
$dir = '/';
}
- my @cmdline = $self->_get_exec_argv($dir, $user);
+ my @cmdline = $self->_get_exec_argv($dir, $user, $disable_network);
if (ref $command) {
push @cmdline, @$command;
--- End Message ---
--- Begin Message ---
Source: sbuild
Source-Version: 0.89.2
Done: Jochen Sprickerhof <[email protected]>
We believe that the bug you reported is fixed in the latest version of
sbuild, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jochen Sprickerhof <[email protected]> (supplier of updated sbuild package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 02 May 2025 17:03:10 +0200
Source: sbuild
Architecture: source
Version: 0.89.2
Distribution: unstable
Urgency: medium
Maintainer: sbuild maintainers <[email protected]>
Changed-By: Jochen Sprickerhof <[email protected]>
Closes: 1104553
Changes:
sbuild (0.89.2) unstable; urgency=medium
.
[ Jochen Sprickerhof ]
* Add hint for --no-clean-source.
Thanks to Andrew Lee
* Add NEWS entry for deprecating sbuild-debian-developer-setup
* rmdir the chroot dir in end_session
.
[ Carlos Nihelton ]
* chroot: Quote escape username to prevent unintended interpolation
.
[ Helmut Grohne ]
* support --no-enable-network on the schroot backend for backends matching
/unschroot/ (Closes: #1104553)
Checksums-Sha1:
074cc00ddc433ed1bd53c1f674970595342d4df2 2700 sbuild_0.89.2.dsc
ee64ab19ffc164a439b147eef2549f6a44aab63a 263628 sbuild_0.89.2.tar.xz
Checksums-Sha256:
2e333a6da238b8e71e2e958e9e2dcd814f039f32f08297b36207a9c6f0346e49 2700
sbuild_0.89.2.dsc
3b2541756e66ecb7770e09529bfb5c2a2371b5d5ba569617837aefb05576704b 263628
sbuild_0.89.2.tar.xz
Files:
02a44d39929973ee5bbeabe90a57df67 2700 devel optional sbuild_0.89.2.dsc
01c7d397fbee46fbb24db7a0d6a52fc9 263628 devel optional sbuild_0.89.2.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEc7KZy9TurdzAF+h6W//cwljmlDMFAmgU3xAACgkQW//cwljm
lDM9Dg//aPTfVZuyc3krDTsyI+8mYJng+YpYUmzyRaJ9GeyBn+qxR6QmDyoETQtD
7oRn4ANZAN+gm5oaWmYKBd4WeV3WoIItGBNt7/hstLL6zM7QGjkY2pMkypgYeKkG
jOrpfOnNl0YkbMTSjzpHY1+OkhJoFMPNaSdeNGVyeVqIUyorT6lJViJnAAWlqasL
HtACjT/i4jSW/PllZVq7tg7eaCEPzMPyEcWX9VZLCvMW2nihuoD9vlA1vJI5oJRY
nYYx0oZ0ag2sc5tcA81IlUAHBUwcKV17rpycpWfx5RDKl2onx3W/01D/TA5VMmSG
KthEOw1fZGv9MGGWyzk85jncQWaSixUJcMpnB08y4PMrpEjPoIo3qAx35KAhFY/C
6h0rS3lurf/Ml7BloUqdAS9I5YsgccqbDHvj3qKilsb+/bzooOIMqHLVj/PoS8Au
/wswQe5ixJRJFgcrja/8npvJhtx9l/GeLK45wdAZRdMGj2ToKUfwn1Sqn8KhQtw7
ppSl6/jCcqar2DnvnqPkEsLYc3DRqaKIt9D/QRFagsqVhCbxKR6DikzhtzElX3ba
QPykNYDu5LGKwr6KwkHWPDdtVCW6Ryi+MU/vOi2tJJO/pnYSpC2nGS4pdfS/hZ28
Bd0/yiwCS/gMqBDYXcdr2nklVRbJqJJrLP+V8vDxTxtL/U9hxMg=
=DH6S
-----END PGP SIGNATURE-----
pgpY7Ryz3iI6F.pgp
Description: PGP signature
--- End Message ---
