Your message dated Sun, 19 Oct 2025 15:05:58 +0000
with message-id <[email protected]>
and subject line Bug#1114540: fixed in devscripts 2.25.20
has caused the Debian Bug report #1114540,
regarding uscan: Git-Modules will always check out all submodules
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1114540: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1114540
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.25.19
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Dear maintainer,
the Git-Modules option is broken as it will always check out all
existing submodules, even if only a partial list is given.
The culprit is the following logic error:
diff --git a/lib/Devscripts/Uscan/WatchSource.pm
b/lib/Devscripts/Uscan/WatchSource.pm
index bd0ea7f9..20d4038f 100644
- --- a/lib/Devscripts/Uscan/WatchSource.pm
+++ b/lib/Devscripts/Uscan/WatchSource.pm
@@ -421,7 +421,7 @@ sub parse {
} elsif ($optName =~ /^git(export|mode)$/) {
$self->git->{$1} = $optVal;
} elsif ($optName eq 'gitmodules') {
- - if ($optVal eq 'all' or 'yes') {
+ if ($optVal eq 'all' or $optVal eq 'yes') {
$self->git->{modules} = ['.'];
} else {
$self->git->{modules} = [split /;/, $optVal];
Cheers
Timo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEmwPruYMA35fCsSO/zIxr3RQD9MoFAmi8cbQACgkQzIxr3RQD
9Mp2bBAAj+KMLcZMBRx2FPpaLw7SGxEcTPl2JkxhbINHxx7xI7+gIVHR31kcj+l5
Xt5Srbsv0Yz0upQ1iY8ZI2P/85FXv+G7FX5vh/1HIgIkpaFG3u41X1k596tmRssZ
sBFRdvUb0QxWpylSSZdELJ62+x5dq9twZ2P96XNYgjnBq9SbUJAkErSv+KdBZwVv
MLMqGYLyb3exKpcUlDsV3/UnI0+njF556gKWhwYlFqVVlvv3L6ZF73qPaML9coKQ
2051CZZk5jhxaG56zkXc5DcS8vrtYJo+Sqv5pDGbrkTh13VVlFcZYFxS1K3h7NRH
g9JJVk6hIYdqvX9ttraeWXxF4PLKiYNyfd3YhIJVpGZ87ahggYzdJymGXsuzWjzX
BLpk5m9GJNFWO4S1Q7x8uHKyh61hx7ggTkn9WEPXUG9S5qQeSS2lhgCArvZh7jDf
oNrTc10p2e6hYoIfJF5U0ibB3JqWq3jc8dqXZyO6QFHuXcvmtA36HLXRmYeixs4j
eU4KnNtyBtiNdlUAPc2+EdFmf2DAjRH7tZzz9nmgLddY915MG01wRIFzKQGfmXfu
R5EjXwTJfNErCaH30CJRWAejwTI5oWFecV/NOD4Jav6GR2VQnizX2th8O2sE6jNG
0zp92CsCZ/Hh62HK4pq2S0dTjA8OzuV9F7WnvrGtN21i7RTxki0=
=lMXy
-----END PGP SIGNATURE-----
--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.25.20
Done: Holger Levsen <[email protected]>
We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Holger Levsen <[email protected]> (supplier of updated devscripts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 19 Oct 2025 16:36:30 +0200
Source: devscripts
Architecture: source
Version: 2.25.20
Distribution: unstable
Urgency: medium
Maintainer: Devscripts Maintainers <[email protected]>
Changed-By: Holger Levsen <[email protected]>
Closes: 995857 1110411 1110911 1112065 1114540 1114750 1114902 1117931
Changes:
devscripts (2.25.20) unstable; urgency=medium
.
[ Yadd ]
* Update uscan doc.
* uscan: document --update-watchfile.
* Add "Version-Type" parameter in templates to be able to replace
ANY_VERSION by another macro.
* uscan: update missing-template message to suggest an upgrade.
* uscan: reject "version=5" in favor of "Version: 5" and report
corresponding error.
* Clean test files.
.
[ Ben Hutchings ]
* uscan:
- fix parsing of v4 watch file with @PACKAGE@ in URL. Closes: #1112065.
- add regression test for bug #1112065.
- add test cases for v4 watch files.
.
[ Jochen Sprickerhof ]
* debrebuild: workaround #806984 and #807168 when rebuilding
debian-installer(-netboot-images).
* uscan: add references to new watch man pages.
.
[ Xiyue Deng ]
* Use canonical field name in debian-watch manpage.
.
[ Hugh McMaster ]
* uscan:
- Call 'git fetch' with '--recurse-submodules' in submodules mode
- Pass @args to 'git fetch' when updating upstream repositories
- Fix regression preventing use of "safe.bareRepository = explicit"
Closes: #1114902
* uscan/Git.pm: Fix cloning from branches with 'heads/<branch>' syntax
Closes: #1114750
* uscan/Downloader.pm: Support git upstream repositories with submodules
* uscan/WatchSource.pm: Fix logic error when cloning selected git submodules
Closes: #1114540
* debian-watch.pod: Minor updates
* debian-watch-4.pod: Update Description and correct a grammatical error
* test/test_uscan_git:
- Separate writeDebianWatch() from makeDebianDir()
- Test git upstream repositories with submodules
- Stop 'git-daemon' if the process exists
- Simplify 'git submodule' tests
- Add second submodule to unit tests
- Test individual git submodules
- Separate git upstream submodules setup from initial test
- Add more git upstream submodule tests
- Rewrite writeDebianWatch() to use an associative array
- Set "Pgp-Mode: none" as a default in debian/watch
- Uniformity updates
- Unify use of 'pristine' and 'upstream' tarball variables
- Avoid use of perl in unit tests
- Add tests for 'Git-Pretty: describe' mode
* Fix several issues pointed out by Lintian:
- debian-watch.pod: Fix spelling issues
- debian/copyright: Add missing License field
- scripts/deb*.1: Print a straight quote instead of an acute accent
- scripts/*.pod: start manual page NAME section with one word
- README.md: Wrap script description lines at 80 characters
.
[ Alexandre Detiste ]
* Remove obsolete what-patch script.
.
[ Jeremy Bícha ]
* uscan: capitalize GitHub and GitLab correctly in manpages.
.
[ Simon Richter ]
* uscan: add support for recursive submodules.
.
[ Bastian Blank ]
* Use properly mangled version in vcs download again.
.
[ Serge Schneider ]
* uscan/Downloader.pm: Escape $pkg variable in $fname regex.
Closes: #995857, #1110911.
.
[ Jérémy Lal ]
* grep-excuses.1: fix --autopkgtests msgstr. Closes:#1117931.
.
[ Holger Levsen ]
* Update Portuguese translation. Thanks to Américo Monteiro.
Closes: #1110411.
* Update po4a.
Checksums-Sha1:
181d7de2624c50952ba013f97d9859d5357f3292 3468 devscripts_2.25.20.dsc
6a0982354e9c0e1c83345c49eaeab4775066eea1 1069876 devscripts_2.25.20.tar.xz
557e1ee2c80c32648b6f241ca06a23ed69c9bddb 19203
devscripts_2.25.20_source.buildinfo
Checksums-Sha256:
6e2458ec4295f3e2c10e7916225c3aaa7f0b94e453a26a58791a6778fefe7fbb 3468
devscripts_2.25.20.dsc
e514743a8e856a4d744da0c2e7af9281dff6b32a9a02b7f3624e3630e96f0d69 1069876
devscripts_2.25.20.tar.xz
560c24cf6d0c82cab6996703766a16d550a73750a00df05fac3399c378111796 19203
devscripts_2.25.20_source.buildinfo
Files:
7ea5d247a08369b6b061c6755181f9bd 3468 devel optional devscripts_2.25.20.dsc
9c7166ec32a64e05507340f1181cbd4c 1069876 devel optional
devscripts_2.25.20.tar.xz
0da7c72b21b796740f9489b8f0a62a89 19203 devel optional
devscripts_2.25.20_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEuL9UE3sJ01zwJv6dCRq4VgaaqhwFAmj0+v0ACgkQCRq4Vgaa
qhzrNw//XUXwaxSEhmNmO3ON/+SVpjckdVHxk7DSVj8c5b9gvbT5V7gLXQUfA5TQ
zazVaPOQxVCSNGJeTKWkAitBHzedpeLHqZJt2YX20d44at2RW90D07IIyucRvdJq
Sl1aSLApbJ9rl5QcWXgZG2vMCetj5F2qzB3vn97jNaxa/RR/DWl+7ayQ8dEmxLWn
G3+idL63fTpZxAre6KPLkDGpuPGQk6HIENlF/quG414M/YiCoZ3Z/2XnGvWiixb3
Je0KCwv19E8dMSQ+XJWimMrpcf5591ApRQIy2cGLtXSV3lUwloJO+OX635t6/fHi
sLzT3pwPODOJMK+8ua1Sq/Lii0Usng4J6PJgO628eWaGoX7bdo65FNw6zTSpldPQ
AgrHt71jR/le7p0hcNMp6tzJWoalSLUQiZK13ojVpaHDmEBQAGVpG1PqFQ9Zn0oL
iKtppqp/HzcUmWvTdNN1OWWaTYWWjP6Bxgq0OpSIAC7nEOHM1bPA2e7e7NISGvEk
5JmEpxRuyeTK25mTf/GqwugtQiygDhpHyfJsr6Cy/Z2B3THe8Za8PtTT51VOHADK
KUYiyUizDESxMQ7Faro+6jwLc9xnL9GZ+myZUBdkbW1sOhnhM81rLSjJsPG+GIK7
hCWfk3qydRKNLBvFMZqxSNN4xPcsXle9bvAcY48wHuWT7vagifQ=
=3Sm3
-----END PGP SIGNATURE-----
pgpiGh0QIVozM.pgp
Description: PGP signature
--- End Message ---
