Your message dated Wed, 29 Oct 2025 21:26:50 +0000
with message-id <[email protected]>
and subject line Bug#1119588: fixed in tgif 1:4.2.5-4
has caused the Debian Bug report #1119588,
regarding tgif: please build using the default build flags
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1119588: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119588
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: tgif
Version: 1:4.2.5-3
User: [email protected]
Usertags: hardening-buildflags
tgif is not currently using the default build flags set by dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.
Please make sure that tgif builds using the default build flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.
In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
tgif, the flags are either ignored or overridden.
The most common reasons for this are:
Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles
Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.
In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":
set(CMAKE_CXX_FLAGS "-O2")
If the intention is to append to CXXFLAGS, one should use the following
instead:
set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")
See #655870 for a similar autotools example.
Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags
Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).
Others attempt to append to the variables, but end up accidentally
overriding the defaults:
#!/usr/bin/make -f
export CFLAGS += -pipe -fPIC -Wall
%:
dh $@
Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).
For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)
--- End Message ---
--- Begin Message ---
Source: tgif
Source-Version: 1:4.2.5-4
Done: наб <[email protected]>
We believe that the bug you reported is fixed in the latest version of
tgif, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
наб <[email protected]> (supplier of updated tgif package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 29 Oct 2025 20:09:14 +0100
Source: tgif
Architecture: source
Version: 1:4.2.5-4
Distribution: unstable
Urgency: medium
Maintainer: Package Salvaging Team <[email protected]>
Changed-By: наб <[email protected]>
Closes: 1119588
Changes:
tgif (1:4.2.5-4) unstable; urgency=medium
.
* Team upload.
* Don't override CFLAGS (Closes: #1119588)
Checksums-Sha1:
503961bf154780822c159df629673722eb1f8383 2002 tgif_4.2.5-4.dsc
d25c8aaa7ddbeba4e720dc369d62f14b850065bc 3093619 tgif_4.2.5.orig.tar.gz
50bce00e3f8549ceb31647d0402db3a6e9102ae4 237688 tgif_4.2.5-4.debian.tar.xz
877bb5af8a8cbb1bc1fac65f73d64eb2e8ddbbb9 7847 tgif_4.2.5-4_source.buildinfo
Checksums-Sha256:
4dd2e02a21d06a85b30dd6257716676a2438faedb7a7c9b4b21259c0b2192212 2002
tgif_4.2.5-4.dsc
2f24e9fecafae6e671739bd80691a06c9d032bdd1973ca164823e72ab1c567ba 3093619
tgif_4.2.5.orig.tar.gz
448b9f25d602ecf08698f67fb8c18888406b9c54b01d4fd8ffabc78c631f2f53 237688
tgif_4.2.5-4.debian.tar.xz
d0b98c3635f2ec5a6ecaccd67322becbbd077cd929c91cb6ea2ea510226e72c5 7847
tgif_4.2.5-4_source.buildinfo
Files:
169e32149083883277efb8faf4a0101e 2002 graphics optional tgif_4.2.5-4.dsc
a622240ce2377f15b6d8261e4c49b8f6 3093619 graphics optional
tgif_4.2.5.orig.tar.gz
9599364bf3b0473bafb0f270666672ad 237688 graphics optional
tgif_4.2.5-4.debian.tar.xz
c5a033c6e5f1e74dc8c1dce976442773 7847 graphics optional
tgif_4.2.5-4_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJWBAEBCgBAFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmkCZusiHG5hYmlqYWN6
bGV3ZWxpQG5hYmlqYWN6bGV3ZWxpLnh5egAKCRC8/QsBjSZY8b8eEAC5bWCmwYRl
PtmIob4gg/ZmL/lVDxeVoaEvj4Csr5uA9f7q1E56THBIXpO+S8D620LGm90mWwZ7
3i5OAJwYzlnTBETvvfBhOwrNQt4iVZiPczG1X7cswktxjJf3yFjaV5fLfMoVJSO5
XLe9hSOHrtiJzq+Z/AXYPzqKtK2Ifk2vzYZ6PzEAFeDbSGqza5i2RW7Fnf+hxcr0
CcFQT9U0eG1oE1jfvDbUHLr14cJDHdGFtJZaE+2UFRLiuxbjFlOAykf48e7VDVUu
HfvCTW5rokOqhjMAiu2tcikXNTQhIgqX9n84A1wzUdwNvNn/TioEEQpLSj/X9f8Z
lt+rDj/7n22/6WR7iVZurTUFInDryE2cv+rQGCncgtkijICm2fb3519hx0KGOj/Q
Lhdz61KcDVya9PXUnQVKpbHOwFLmbSalBZKn4ukgZKSRhSRRCFnn2X0EeSzAoTdf
GTuUQ4kgsCxguvcubtgjWRHjgXJS0S16aM9BcChdIZ3HlUu3Kd6tXXTG8tS7TwfF
mChDvGFfNjUWJP4ZMw10Y1znXPa5Z5FiEn0CW+hixtrqNQre4MeiQfy4rhRY9/1y
c1qkvXqlz+N7dc712zuGiJtLd3DgouveCRx3fCE+fGEQRCOunIhjxqT3/fGv0ED4
Wc5Njh1RtGmnqjJ0XRKaLInXOEWwuEdx7A==
=LVkd
-----END PGP SIGNATURE-----
pgpOFqmxrUS6S.pgp
Description: PGP signature
--- End Message ---
