Your message dated Mon, 10 Nov 2025 06:17:35 +0700
with message-id <[email protected]>
and subject line Re: Fix email for external account creation: bug in 
debian/patches/mail-verification.patch
has caused the Debian Bug report #980547,
regarding Fix email for external account creation: bug in 
debian/patches/mail-verification.patch
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
980547: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980547
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-moinmoin
Version: 1.9.9-1+deb10u1
Severity: normal

Dear Moinmoin maintainer,
The mail-verification.patch adds the line:

mailok, msg = sendmail.sendmail(request, user.email, subject, text,
request.cfg.mail_from)

The second argument of sendmail.sendmail should be a list but user.email is
not a list!

This can be fixed by replacing the above line in the
mail-verification.patch with:

mailok, msg = sendmail.sendmail(request, [user.email], subject, text,
request.cfg.mail_from)

ie: the addition of [] around user.email

This bug stops external_account_creation_check.patch from working properly.

Please can you make this tiny fix!
If you need more info please let me know.

Many thanks
Alex Owen

PS: for sysadmin out there who want to monkey patch this you can do by
copying the action into your wiki instance as a custom action and fixing
there.
ie:

SUDO=sudo

$SUDO cp -p /usr/lib/python2.7/dist-packages/MoinMoin/action/newaccount.py \

            $WIKI/data/plugin/action/

$SUDO sed -i -e'/mailok, msg =
sendmail.sendmail/s/user.email/\[user.email\]/' \

            $WIKI/data/plugin/action/newaccount.py

--- End Message ---
--- Begin Message ---
Version: 1.9.9-1+deb9u1+rm

On Wed, Jan 20, 2021 at 12:32:33PM +0000, Alex Owen wrote:
> Package: python-moinmoin
> Version: 1.9.9-1+deb10u1
> Severity: normal
> 
> Dear Moinmoin maintainer,
> The mail-verification.patch adds the line:
> 
> mailok, msg = sendmail.sendmail(request, user.email, subject, text,
> request.cfg.mail_from)
> 
> The second argument of sendmail.sendmail should be a list but user.email is
> not a list!
> 
> This can be fixed by replacing the above line in the
> mail-verification.patch with:
> 
> mailok, msg = sendmail.sendmail(request, [user.email], subject, text,
> request.cfg.mail_from)
> 
> ie: the addition of [] around user.email
> 
> This bug stops external_account_creation_check.patch from working properly.
> 
> Please can you make this tiny fix!
> If you need more info please let me know.

python-moinmoin has been removed in #954949.

-- 
An old man doll... just what I always wanted! - Clara

--- End Message ---

Reply via email to