Your message dated Tue, 11 Nov 2025 22:26:21 +0000
with message-id <[email protected]>
and subject line Bug#1119530: fixed in plzip 1.12-4
has caused the Debian Bug report #1119530,
regarding plzip: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1119530: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119530
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: plzip
Version: 1.12-3
User: [email protected]
Usertags: hardening-buildflags

plzip is not currently using the default build flags set by dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that plzip builds using the default build flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
plzip, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
        dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message ---
Source: plzip
Source-Version: 1.12-4
Done: Daniel Baumann <[email protected]>

We believe that the bug you reported is fixed in the latest version of
plzip, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated plzip package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 11 Nov 2025 21:17:00 +0100
Source: plzip
Architecture: source
Version: 1.12-4
Distribution: sid
Urgency: medium
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Closes: 1119530
Changes:
 plzip (1.12-4) sid; urgency=medium
 .
   * Adding compression option to watch file.
   * Removing rules-requires-root, not needed anymore.
   * Building with hardening build-flags (Closes: #1119530).
Checksums-Sha1:
 2b35dbb6e4eedf117feb5c829b240a617ed6f7a0 1194 plzip_1.12-4.dsc
 925af76c15474bda9b41a02a531a1f180f02a514 6796 plzip_1.12-4.debian.tar.xz
 5f523747893c8ba214cbb6144d2e5e65f3c97f2d 5589 plzip_1.12-4_amd64.buildinfo
Checksums-Sha256:
 f961be1c9f9c1c6c8925e027162455ecf90cf9b58dfcf720117702aed2664710 1194 
plzip_1.12-4.dsc
 f4775891c19052f5ede99b1e180d82e95c670fe8f05ff344afb2e5fc5dd70dd4 6796 
plzip_1.12-4.debian.tar.xz
 1b980b9cbd6f31cf5300854283fcaa5bfbf987675cc68e7b02d347d8858c3bd2 5589 
plzip_1.12-4_amd64.buildinfo
Files:
 0c19fc792b23cf179cebf555ec644207 1194 utils optional plzip_1.12-4.dsc
 2053f5722ea09a57447c50e6514ef20b 6796 utils optional plzip_1.12-4.debian.tar.xz
 21b1c6c6136661927c8f58c933fb0eb1 5589 utils optional 
plzip_1.12-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQQmmGg4gLaoSj0ERgL7tPDoCoAiLwUCaROZ8gAKCRD7tPDoCoAi
L9E9AP4pRDFHCDIxrDgiEZoTfb2MdgRR3S8sgPzjC2CE8IasGgEA4zhuWpGarjRJ
g/vSn3w2MBOR5Ia3jatLJKmDCZCWhgA=
=Bw/R
-----END PGP SIGNATURE-----

Attachment: pgpZWaIEczJwm.pgp
Description: PGP signature


--- End Message ---

Reply via email to