Your message dated Sun, 23 Nov 2025 09:49:27 +0000
with message-id <[email protected]>
and subject line Bug#1119534: fixed in proftpd-mod-statsd 0.1-2
has caused the Debian Bug report #1119534,
regarding proftpd-mod-statsd: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1119534: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119534
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: proftpd-mod-statsd
Version: 0.1-1+b8
User: [email protected]
Usertags: hardening-buildflags

proftpd-mod-statsd is not currently using the default build flags set by 
dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that proftpd-mod-statsd builds using the default build flags. 
blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
proftpd-mod-statsd, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
        dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message ---
Source: proftpd-mod-statsd
Source-Version: 0.1-2
Done: Hilmar Preuße <[email protected]>

We believe that the bug you reported is fixed in the latest version of
proftpd-mod-statsd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hilmar Preuße <[email protected]> (supplier of updated proftpd-mod-statsd 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 23 Nov 2025 10:16:53 +0100
Source: proftpd-mod-statsd
Architecture: source
Version: 0.1-2
Distribution: unstable
Urgency: medium
Maintainer: ProFTPD Maintainance Team 
<[email protected]>
Changed-By: Hilmar Preuße <[email protected]>
Closes: 1119534
Changes:
 proftpd-mod-statsd (0.1-2) unstable; urgency=medium
 .
   * Remove override_dh_auto_build
     - dh $@ ... --max-parallel=1 (just a precaution).
   * d/rules: add "export DEB_BUILD_MAINT_OPTIONS = hardening=+all"
     ...does not seem to be effective.
   * Enable Reprotest on Salsa CI.
   * Build using the default build flags (Closes: #1119534);
     enable blhc test on Salsa CI.
   * Remove useless content from 01_built_outside_tree.
   * Move Make.rules from patches/01_built_outside_tree to subdir
     "debian/".
   * Remove libsodium-dev & libhiredis-dev from B-D.
   * Bump Standards version, no changes needed.
   * Lintian stuff.
Checksums-Sha1:
 9615874181b62c559a2095ddfa2de52fb3193be7 2266 proftpd-mod-statsd_0.1-2.dsc
 2d724bf147a60810315abcdbee01e39def660456 3956 
proftpd-mod-statsd_0.1-2.debian.tar.xz
 a556e97aaaeeff1ca43819fd5c787f192726ef2a 5570 
proftpd-mod-statsd_0.1-2_source.buildinfo
Checksums-Sha256:
 e61f91d99a7313816e5c506b5f75a466a70125f4d69721acdd447870ce9e8855 2266 
proftpd-mod-statsd_0.1-2.dsc
 a2d8a6a62274c000d1cc3325b4f0826eace48231b8f7ad531662d147674ad2a1 3956 
proftpd-mod-statsd_0.1-2.debian.tar.xz
 4cf22c58c636380d01bda80331dbcf45cb9f8894bb4b2f8a34b82c60ba39ba23 5570 
proftpd-mod-statsd_0.1-2_source.buildinfo
Files:
 b5e6eefb552834fa54ece4bc2241e40c 2266 net optional proftpd-mod-statsd_0.1-2.dsc
 c82d535b50a2cd21966bd020beb4fac1 3956 net optional 
proftpd-mod-statsd_0.1-2.debian.tar.xz
 b956efbc4e4ea796bcae34dfeb69381e 5570 net optional 
proftpd-mod-statsd_0.1-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEaXGmC/nkbIhxf16kxiZYRqvgLIsFAmki099fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDY5
NzFBNjBCRjlFNDZDODg3MTdGNUVBNEM2MjY1ODQ2QUJFMDJDOEIACgkQxiZYRqvg
LIvS7A/+MxvXTR6aVnucvKMCWOry6iTjiFk3wa30h8sSyas0pR7N6PWh6yXOrRLe
eBOZk4+kai4lNOnGGDhOeqx8A+aYvlKmY5AXLbUD0B5i8E5Xnm01RM9Z8dBv2C+D
jM/t0FxO6qhgBQ5awompaa7yTP7y7PKN+ffgzeCfvdweHaCn12eaYfWoFyX88Zrj
rPhyHCiMdS9QzZCSBLC61tBNm10DvEHk+sC82gEsgrEHjB8B0YvY04L1pcSlHF0E
7iaMXtENsKDK19ifJ19dqGyU0DvVh6jvDubT2/oSZMvhMbN9jM31emlRBCFFh8Ii
2Ep/wrDQjMfIBBug+Foz/1hlJuoudQ3AypyK3yTecZUeQQy+sI+YOpAguFLCYkf1
uHwfrJ/YGM/qnOvRI1+yETmSaREQn54KSAjwPzYwgUz248ciXh4jt+rJqQ0+oN8T
FTCu0SeiuQSgbuQxQV8lTPBV7qfkXEEAXWySahS8ebtbmGcMnyr8PrAfWM/fo/59
qJhSdxQLAGPFE/Yz2EQZyZnoYJSATnpN2JSqRBB7Db82e0wI2Sq3fPcNDNBpboOM
Zb9zFDLJ86c3Vg0dsrhPHN/spRa8y4l2p4L3O9+l1//ZAtqN5SDhF3AllxVx0pjb
KY7QSVxB3yeoJNNQ7bbcI8Dhm46XBicP23oEkRovERTh1GqlQnE=
=4KmF
-----END PGP SIGNATURE-----

Attachment: pgpi4xctFyxrO.pgp
Description: PGP signature


--- End Message ---

Reply via email to