Your message dated Sun, 23 Nov 2025 11:49:38 +0000
with message-id <[email protected]>
and subject line Bug#1119533: fixed in proftpd-mod-sftp-ldap 0.2-3
has caused the Debian Bug report #1119533,
regarding proftpd-mod-sftp-ldap: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1119533: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119533
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: proftpd-mod-sftp-ldap
Version: 0.2-2
User: [email protected]
Usertags: hardening-buildflags

proftpd-mod-sftp-ldap is not currently using the default build flags set by 
dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that proftpd-mod-sftp-ldap builds using the default build 
flags. blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
proftpd-mod-sftp-ldap, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
        dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message ---
Source: proftpd-mod-sftp-ldap
Source-Version: 0.2-3
Done: Hilmar Preuße <[email protected]>

We believe that the bug you reported is fixed in the latest version of
proftpd-mod-sftp-ldap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hilmar Preuße <[email protected]> (supplier of updated proftpd-mod-sftp-ldap 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 23 Nov 2025 12:30:45 +0100
Source: proftpd-mod-sftp-ldap
Architecture: source
Version: 0.2-3
Distribution: unstable
Urgency: medium
Maintainer: ProFTPD Maintainance Team 
<[email protected]>
Changed-By: Hilmar Preuße <[email protected]>
Closes: 1119533
Changes:
 proftpd-mod-sftp-ldap (0.2-3) unstable; urgency=medium
 .
   * Enable Reprotest on Salsa CI.
   * Build using the default build flags (Closes: #1119533);
     enable blhc test on Salsa CI.
   * Move Make.rules from patches/01_built_outside_tree to subdir
     "debian/".
   * Bump Standards version, no changes needed.
   * Lintian stuff.
Checksums-Sha1:
 ccf11b01c04f55a8fad6d39568b4633f5216ef99 2316 proftpd-mod-sftp-ldap_0.2-3.dsc
 e4348d543b7451d36acbd707b048986d9876aa2e 6184 
proftpd-mod-sftp-ldap_0.2-3.debian.tar.xz
 71a82a400bb8618716066fe7d57d02d02dcc3b61 5524 
proftpd-mod-sftp-ldap_0.2-3_source.buildinfo
Checksums-Sha256:
 82a1170cfad733fe08f3ff06febe54004203d9efe23b60cf41b0af23ab948405 2316 
proftpd-mod-sftp-ldap_0.2-3.dsc
 a7336ca7893fd8ef4983efb16b95b19cbf32177d2a48b16ab7704cf865476348 6184 
proftpd-mod-sftp-ldap_0.2-3.debian.tar.xz
 265795833dfc10dcd656593f91344d0077f674b93ca18b0c9ca75ee77b6cdc85 5524 
proftpd-mod-sftp-ldap_0.2-3_source.buildinfo
Files:
 5d718ed81883d1f1c67173d195f9f36c 2316 net optional 
proftpd-mod-sftp-ldap_0.2-3.dsc
 b74c46e0b7ce62339c64e1a77a10b443 6184 net optional 
proftpd-mod-sftp-ldap_0.2-3.debian.tar.xz
 b05f6299c1ca19059cb6d3f68109a9c6 5524 net optional 
proftpd-mod-sftp-ldap_0.2-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEaXGmC/nkbIhxf16kxiZYRqvgLIsFAmki8IRfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDY5
NzFBNjBCRjlFNDZDODg3MTdGNUVBNEM2MjY1ODQ2QUJFMDJDOEIACgkQxiZYRqvg
LIs9LBAAqj6aEjdithFFp+lAaxDgVPsryi1tt4QQIPQyf6/Imr0OftAuNAY4Hn69
u/yWYdNgcHJT8G0qEVI+8kDT1t7wuweq6O/Lfyp71+3o2ZixMoxJTgg6ZhUyIIZK
JTxwDVNUDQWntv4Ktq+gF1nnqkV9Y4aJnwN0eIpD6nvFxX0X7R6fQq/K54I1YCn0
SWFhgK3pLqWpaZXvGTm4K9FbFMOtt2ClR5Opj8URdpfsssHkE+eCjo+X1V8fsTON
eENwOtu4PMiovQl0XoRRqmGdGyr/otIjuCeOlbXNi50NsNCfLm2RfeWt89b6OT/P
TJDwedadgJDUSa6qXyvTduM2dTPF9sOm0U5D2GRLIHkFx5Piatw/99IrtgHEJ9a7
DQhUSHmUKqEgrj1eHnpQ/i6UOIh1td2UlXb8IwCMqwrC3XM/g9Jz05Lmjrr5j+Gx
ho+sTn28/ixuBq6oR1qD20j4q5U5AdPAv25XIM5Pzww/aEZHP78R2k6j9IvMhniH
WIFGwNiGQTg/54Hpyn0uUjY6L7QkYkExld0+zm3ZCrymP6fq9e+VBWNCvp61rUcw
fFYu7tpeEgNIpLjV8d/PTaQon3Bi9KVgM2Ji2vSbPRSRcxJ3r4Ix/mkVk/4uXNhO
kqR72r1S9Aeq+9qp2VhD+PuYp7We/Ng0qy67tkh/pND4KpdArO8=
=IfW2
-----END PGP SIGNATURE-----

Attachment: pgpiqSeQHhQc6.pgp
Description: PGP signature


--- End Message ---

Reply via email to