Your message dated Sun, 23 Nov 2025 14:42:40 +0000
with message-id <[email protected]>
and subject line Bug#1119532: fixed in proftpd-mod-kafka 0.1-2
has caused the Debian Bug report #1119532,
regarding proftpd-mod-kafka: please build using the default build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1119532: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1119532
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: proftpd-mod-kafka
Version: 0.1-1+b5
User: [email protected]
Usertags: hardening-buildflags

proftpd-mod-kafka is not currently using the default build flags set by 
dpkg-buildflags(1).
The default flags are chosen for multiple reasons including security,
performance, reproducibility, adherence to standards, and error handling.

Please make sure that proftpd-mod-kafka builds using the default build flags. 
blhc(1p)
and hardening-check(1) can be used to confirm that the issue is fixed.

In the general case, packages honoring CFLAGS, LDFLAGS, and other
similar environment variables get the default build flags for free
without the need for any work on the maintainer side. In the case of
proftpd-mod-kafka, the flags are either ignored or overridden.

The most common reasons for this are:

Hand-written Makefiles
----------------------
Some upstream Makefiles either override the values of variables such as
CFLAGS and similar or do not use them at all. See:
https://wiki.debian.org/HardeningWalkthrough#Handwritten_Makefiles

Misconfigured build systems
---------------------------
If the upstream code uses autotools, CMake, or other popular build
systems, it usually requires no further modifications. If might however
be that some variables are hardcoded in some way.

In this CMake snippet, the value of CXXFLAGS is overwritten with "-O2":

 set(CMAKE_CXX_FLAGS "-O2")

If the intention is to append to CXXFLAGS, one should use the following
instead:

 set(CMAKE_CXX_FLAGS "-O2 ${CMAKE_CXX_FLAGS}")

See #655870 for a similar autotools example. 

Very old debhelper usage
------------------------
Packages not using dh(1), or those using a debhelper compatibility level
less than 9, need to manually include /usr/share/dpkg/buildflags.mk in
order for the dpkg-buildflags variables to be set:
https://wiki.debian.org/Hardening#dpkg-buildflags

Flags hardcoded in debian/rules (either voluntarily or not)
-----------------------------------------------------------
Some packages voluntarily hardcode the values of CFLAGS and friends in
debian/rules, ignoring the defaults set by dpkg-buildflags(1).

Others attempt to append to the variables, but end up accidentally
overriding the defaults:

 #!/usr/bin/make -f
 export CFLAGS += -pipe -fPIC -Wall

 %:
        dh $@

Debhelper only sets CFLAGS if it is not set yet. In the example above,
when dh is invoked the value of CFLAGS is "-pipe -fPIC -Wall", hence the
hardened defaults are not used. The right way to append to CFLAGS is
using DEB_CFLAGS_MAINT_APPEND instead, as documented in
dpkg-buildflags(1).

For a detailed analysis of this issue, see:
https://people.debian.org/~ema/nocflags_paper.pdf (eprint: hal-05334704)

--- End Message ---
--- Begin Message ---
Source: proftpd-mod-kafka
Source-Version: 0.1-2
Done: Hilmar Preuße <[email protected]>

We believe that the bug you reported is fixed in the latest version of
proftpd-mod-kafka, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hilmar Preuße <[email protected]> (supplier of updated proftpd-mod-kafka 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 23 Nov 2025 15:00:15 +0100
Source: proftpd-mod-kafka
Architecture: source
Version: 0.1-2
Distribution: unstable
Urgency: medium
Maintainer: ProFTPD Maintainance Team 
<[email protected]>
Changed-By: Hilmar Preuße <[email protected]>
Closes: 1119532
Changes:
 proftpd-mod-kafka (0.1-2) unstable; urgency=medium
 .
   [ Debian Janitor ]
   * Remove constraints unnecessary since buster:
     + Build-Depends: Drop versioned constraint on proftpd-dev.
     + proftpd-mod-kafka: Drop versioned constraint on proftpd-basic in Breaks.
 .
   * Enable Reprotest on Salsa CI.
   * Build using the default build flags (Closes: #1119532);
     enable blhc test on Salsa CI.
   * Move Make.rules to debian/; clean up that file.
   * Remove libsodium-dev from B-D.
   * Bump Standards version, no changes needed.
Checksums-Sha1:
 99550d00e735d5e944ebbe52f13677a9385e9e32 2245 proftpd-mod-kafka_0.1-2.dsc
 93202a5bdbe32f9fd109c0ae5108fae442fe1711 3896 
proftpd-mod-kafka_0.1-2.debian.tar.xz
 5637e7f7d31a8755d8a91a75f1dcf7a5565c2948 5508 
proftpd-mod-kafka_0.1-2_source.buildinfo
Checksums-Sha256:
 143cab4f84902b7f3f700830ba3fe69548f0e4e282c18d632ed0d815184610cb 2245 
proftpd-mod-kafka_0.1-2.dsc
 92e2bac28d4524e2eca4d549713052bfda5578a06efe48028a40c634b06648cc 3896 
proftpd-mod-kafka_0.1-2.debian.tar.xz
 fcfb4ba971f2ccfd647c71c8c9c7459a0d4e2bd2afe004b1b5d4145dcda0a630 5508 
proftpd-mod-kafka_0.1-2_source.buildinfo
Files:
 c312fc31945eac96c43af84b24e7d9d5 2245 net optional proftpd-mod-kafka_0.1-2.dsc
 09efaab36ad144c5cf0102dda7759501 3896 net optional 
proftpd-mod-kafka_0.1-2.debian.tar.xz
 071fc4475f30f45946927dabaa01d8b6 5508 net optional 
proftpd-mod-kafka_0.1-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEaXGmC/nkbIhxf16kxiZYRqvgLIsFAmkjFApfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDY5
NzFBNjBCRjlFNDZDODg3MTdGNUVBNEM2MjY1ODQ2QUJFMDJDOEIACgkQxiZYRqvg
LIvHtg/+LbpT+FJM3ybYThiIcMk7pbuawC3nle/bYj1BNyfRUxguOtw39htgisCH
jb1jJ+uIWneA96lsOehpYcPEOV5AeP2iGZ09pmYEUwQg4gaBHbQOs2F4AJQZbEmc
0cPhW6vkA+99yJ1GSBSVXdraBRoGYh1KVPos373qP2w84BuclpsbbMaPp1DUWZC9
tRvf/+/yq/roiI/FIYsb3XGk6iWIzSeC5AmXlf37fhNX3phJa7fJgTgYTmwa9vW4
X2yWBJokjUwmdKH2Fc6li9PQL3UzQdJ5u1WR409UQPAEt/AElY6mxKdslHjcZJ6D
i5LMMZJ4hek4QwH9IH+HwjmqQ+XiDHIv+KbsUEB9asXDGSl3VIX55USTPaGVenMq
uztEmEhFwFyjykt8/qGfTenCc2S12thgy390rHOdZR3r3LfSyJSLJT7hQ1uKbWG2
015JtKF1aElKDrJzi5vgKEtPLq/XYr4xZTX6Ul4qnunSvjmhVOwKoSSj8rBBdk0W
U8Y7CLy9g6Y+WZ+BZgfHekbTeb0/4rGy11LEDEcXBxKedb6B0Tg6Zk+3wEf38m05
LZe2IrtdeFa7ItlPWlvWhu/++/0kWYHTMLPodu6hlvNbg5GE/pj9s6k/I/L5Wf52
/K27+zW5oic1caE1ntpcXABCbqhs7zmLmV4KjDyC+PMHW+iEUM4=
=2BjA
-----END PGP SIGNATURE-----

Attachment: pgpxK2eF62hut.pgp
Description: PGP signature


--- End Message ---

Reply via email to