Your message dated Wed, 26 Nov 2025 01:50:04 +0000
with message-id <[email protected]>
and subject line Bug#1031417: fixed in spamass-milter 0.4.0-3
has caused the Debian Bug report #1031417,
regarding spamass-milter tags all DKIM signed mails as DKIM_INVALID due to CRLF 
issue in headers (working patch available)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1031417: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031417
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: spamass-milter
Version: 0.4.0-2

Referring to the discussion at 
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7785, it is still unclear 
whether this bug will be fixed in Mail::DKIM or in spamassassin 4.0.

For the time being, I have tested the patch provided by Henrik Krohns 
(https://savannah.nongnu.org/bugs/download.php?file_id=48244) attached to bug 
report "#57626: Folded headers not keeping CRLF newlines” 
(https://savannah.nongnu.org/bugs/index.php?57626) to spamass-milter 0.4.0-2. 
It works and the milter reports DKIM status correctly.

Would be great if you could integrate the patch “header_crlf” to 
debian/patches/series.

header_crlf:

<snip>

Description: Spamass-milter doesn't properly maintain CRLF in folded header 
newlines.
Origin: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7785
Bug: #7785
Author: Henrik Krohns, Matthieu Schapranow 
<[email protected]<mailto:[email protected]>>
Forwarded: no
--- a/spamass-milter.cpp
+++ b/spamass-milter.cpp
@@ -1206,7 +1206,23 @@ mlfi_header(SMFICTX* ctx, char* headerf,
     assassin->set_subject(headerv);

   // assemble header to be written to SpamAssassin
-  string header = string(headerf) + ": " + headerv + "\r\n";
+  string header = headerv;
+
+  // Replace all LF with CRLF
+  // As milter documentation says:
+  //     headerv    Header field value.  The content of the header may
+  //       include folded white space, i.e., multiple lines with following
+  //       white space where lines are separated by LF (not CR/LF).  The
+  //       trailing line terminator (CR/LF) is removed.
+  // Need to make sure folded header line breaks are sent to SA as CRLF
+  string::size_type idx = header.size();
+  while ( (idx = header.rfind("\n", idx)) != string::npos )
+  {
+     header.replace(idx,1,"\r\n");
+  }
+
+  // final assembly
+  header = string(headerf) + ": " + header + "\r\n";

   try {
     // write to SpamAssassin client

</snip>

Thanks,

Matthieu Schapranow

--- End Message ---
--- Begin Message ---
Source: spamass-milter
Source-Version: 0.4.0-3
Done: Don Armstrong <[email protected]>

We believe that the bug you reported is fixed in the latest version of
spamass-milter, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Don Armstrong <[email protected]> (supplier of updated spamass-milter package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 25 Nov 2025 17:13:11 -0800
Source: spamass-milter
Architecture: source
Version: 0.4.0-3
Distribution: unstable
Urgency: low
Maintainer: Don Armstrong <[email protected]>
Changed-By: Don Armstrong <[email protected]>
Closes: 1031417 1039378
Changes:
 spamass-milter (0.4.0-3) unstable; urgency=low
 .
   * Use CRLF in folded headers instead of LF (closes: #1031417). Thanks to
     Matthieu Schapranow.
   * Distribute a systemd service in addition to an init file, thanks to
     [email protected] (closes: #1039378).
   * Wrap spamass-milter in order to correctly auto-detect postfix and
     set the socket options correctly.
Checksums-Sha1:
 1a648a63e3c018cc1386338eca5471fc7268e7e7 1922 spamass-milter_0.4.0-3.dsc
 52bac548098a9113edb8760a0dea6ab65f68122f 14492 
spamass-milter_0.4.0-3.debian.tar.xz
 b1ca97165d475b5836383b1a79c51144116e8f5f 6393 
spamass-milter_0.4.0-3_amd64.buildinfo
Checksums-Sha256:
 ea382aefad07b6121dd64ea51680fb150f627cc80a87b59043589cda68fd33ef 1922 
spamass-milter_0.4.0-3.dsc
 6a2197ab5b7b00e723b432c7b65a21f458e97ee81b521b23145122d7322981ae 14492 
spamass-milter_0.4.0-3.debian.tar.xz
 646bc2577474552d538b9e1153a0d3b7c4a0ae5940a07d7903008ef8a5b3d646 6393 
spamass-milter_0.4.0-3_amd64.buildinfo
Files:
 16898883647c3d261389a2e3e9c6e8a6 1922 mail optional spamass-milter_0.4.0-3.dsc
 6204aed3bc7c696cf1802bb73e554221 14492 mail optional 
spamass-milter_0.4.0-3.debian.tar.xz
 22e4566c61273362463524d20f2ef580 6393 mail optional 
spamass-milter_0.4.0-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE5LM+VK44JFjLfWEcOHr4psy3gqMFAmkmVZcACgkQOHr4psy3
gqN/sA//d2hweD2kw5aOGWBqAgzpOL+x8RrtRF72gOikzRPn3+Dgvsz1bmRgKLUg
q6IeKnIFHOi5IeABzq4EZTU6W0iaFb2ai0NVKAnsErJMyra2YOCZlJZYzYJ09gGA
EKus/A80uRPvo2/Y6iJzelwaZ+sVkMIu7n4Y16G5GZwzGCnNlsst+6vutfkGMmqz
HG/QV8PhnIF2fImQXlXoq7ytpJMhiWx4tkP4Jov3OyiYAS0Ghv5103JiDCXOogi0
kufGqpIPQvrC4ctPfi7IyF0vTjqcaMhFwQP8+TFOoAQnLgyi5q4QnK/kB4wnZ+w7
fSycNVHtrSded0zcIEq3TDu1A4TV+mSoFLvGu4ycOsYTjy1HvrBg60bTSBsaanEB
1TcWC1Adx7Zl7karfKbfKDeZT+K8F8hnDoCxWgHJFJMMQbrznJ6gVaZYB4sjxcLc
cf6ZGOAlHiJTrRACwuLrVptNCW6NRADSVoNymt1grMnSa8AZEp0dEbJSCaLovqf+
pDWk1g48199yPkURjdDuVfDJBJnrOtmJRfk2C2E6FidFTPoZqSzWHn2yw7av0V3B
gNl9hAAun1i/QKwUa+3xfRMZG5iSz44st3xi18j9rBmO0YY8NluGUh8WIFafuavf
HSrSLu+RdDr8JF/4XRz3hvV8US11CtsAD5/QJ9AXOvNfUNAt1wE=
=J+dv
-----END PGP SIGNATURE-----

Attachment: pgp0LVQXFNurB.pgp
Description: PGP signature


--- End Message ---

Reply via email to