Your message dated Tue, 05 May 2026 11:34:53 +0000
with message-id <[email protected]>
and subject line Bug#1131652: fixed in image-factory 1.0.2-1.2
has caused the Debian Bug report #1131652,
regarding image-factory: FTBFS: AssertionError: black found code that needs
reformatting
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1131652: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1131652
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:image-factory
Version: 1.0.2-1.1
Severity: serious
Tags: ftbfs forky sid
Dear maintainer:
During a rebuild of all packages in unstable, this package failed to build.
Below you will find the last part of the build log (probably the most
relevant part, but not necessarily). If required, the full build log
is available here:
https://people.debian.org/~sanvila/build-logs/202603/
About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.
If you cannot reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.
If this is really a bug in one of the build-depends, please use
reassign and add an affects on src:image-factory, so that this is still
visible in the BTS web page for this package.
Thanks.
--------------------------------------------------------------------------------
[...]
debian/rules clean
dh clean --with python3
dh_auto_clean
make -j2 clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
rm -f *.1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_clean
debian/rules binary
dh binary --with python3
dh_update_autotools_config
dh_autoreconf
dh_auto_configure
dh_auto_build
make -j2 INSTALL="install --strip-program=true"
make[1]: Entering directory '/<<PKGBUILDDIR>>'
pandoc -s -t man image-factory.1.md -o image-factory.1
pandoc -s -t man image-factory-sudo-helper.1.md -o image-factory-sudo-helper.1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test
make -j2 check
make[1]: Entering directory '/<<PKGBUILDDIR>>'
python3 -m unittest discover -v
test_black (tests.test_black.BlackTestCase.test_black)
Test: Run black code formatter on Python source code. ... Running following
command:
black --check --diff -l 99 image-factory tests
FAIL
test_empty_config (tests.test_cli.TestCLI.test_empty_config)
Test empty configuration file. ... ok
test_example_config (tests.test_cli.TestCLI.test_example_config)
Test exapmle image-factory.conf file. ... ok
test_override_cache_dir (tests.test_cli.TestCLI.test_override_cache_dir)
Test overriding the cache directory. ... ok
test_flake8 (tests.test_flake8.Flake8TestCase.test_flake8)
Test: Run flake8 on Python source code. ... Running following command:
/usr/bin/python3 -m flake8 --max-line-length=99 image-factory tests
ok
test_invalid (tests.test_helper.TestParseBytes.test_invalid)
Test parse_bytes("invalid") ... ok
test_parse_1_g (tests.test_helper.TestParseBytes.test_parse_1_g)
Test parse_bytes("1G") ... ok
test_parse_2_tb (tests.test_helper.TestParseBytes.test_parse_2_tb)
Test parse_bytes("2 TB") ... ok
test_parse_512_mib (tests.test_helper.TestParseBytes.test_parse_512_mib)
Test parse_bytes("512 MiB") ... ok
test_isort (tests.test_isort.IsortTestCase.test_isort)
Test: Run isort on Python source code. ... Running following command:
isort --check-only --diff -l 99 image-factory tests
ok
test_pylint (tests.test_pylint.PylintTestCase.test_pylint)
Test: Run pylint on Python source code. ... Running following command:
/usr/bin/python3 -m pylint --rcfile=/<<PKGBUILDDIR>>/tests/pylint.conf --
image-factory tests
ok
test_chmod_dnf_log (tests.test_sudo_helper.TestSudoHelper.test_chmod_dnf_log)
Test read access for dnf log file. ... ok
test_chmod_log_file (tests.test_sudo_helper.TestSudoHelper.test_chmod_log_file)
Test read access for mounted /var/log/... ... ok
test_chmod_recursive
(tests.test_sudo_helper.TestSudoHelper.test_chmod_recursive)
Test chmod recursively ... ok
test_chmod_remove_root
(tests.test_sudo_helper.TestSudoHelper.test_chmod_remove_root)
Test chmod remove mounted /root permission ... ok
test_chmod_root (tests.test_sudo_helper.TestSudoHelper.test_chmod_root)
Test chmod mounted /root ... ok
test_chmod_var_log (tests.test_sudo_helper.TestSudoHelper.test_chmod_var_log)
Test write access for mounted /var/log/... ... ok
test_mount (tests.test_sudo_helper.TestSudoHelper.test_mount)
Test mounting. ... ok
test_reject_escaping
(tests.test_sudo_helper.TestSudoHelper.test_reject_escaping)
Test rejecting ../../etc/shadow. ... ok
test_umount (tests.test_sudo_helper.TestSudoHelper.test_umount)
Test unmounting. ... ok
======================================================================
FAIL: test_black (tests.test_black.BlackTestCase.test_black)
Test: Run black code formatter on Python source code.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/<<PKGBUILDDIR>>/tests/test_black.py", line 43, in test_black
self.fail(f"black found code that needs reformatting:\n{output.strip()}")
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: black found code that needs reformatting:
--- image-factory 2026-03-23 09:51:01+00:00
+++ image-factory 2026-03-23 09:51:02.962264+00:00
@@ -123,11 +123,11 @@
shutil.copy(source, destination)
elif source.startswith("http:") or source.startswith("https:"):
logger.info("Downloading %s...", source)
http_client = httplib2.Http(cache_dir)
http_client.ignore_etag = True
- (response, content) = http_client.request(source)
+ response, content = http_client.request(source)
if response.fromcache:
logger.info("Copy cached download to %s...", destination)
else:
logger.info("Save download to %s...", destination)
with open(destination, "wb") as cached_file:
@@ -151,11 +151,11 @@
shutil.copyfile(source, destination)
elif source.startswith("http:") or source.startswith("https:"):
logger.info("Downloading %s...", source)
http_client = httplib2.Http(os.path.join(config[image]["cache_dir"],
image))
http_client.ignore_etag = True
- (response, content) = http_client.request(source)
+ response, content = http_client.request(source)
if response.fromcache:
logger.info("Copy cached download to %s...", destination)
else:
logger.info("Save download to %s...", destination)
with open(destination, "wb") as cached_file:
would reformat image-factory
Oh no! ð¥ ð ð¥
1 file would be reformatted.
----------------------------------------------------------------------
Ran 20 tests in 3.263s
FAILED (failures=1)
make[1]: *** [Makefile:13: check] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: error: make -j2 check returned exit code 2
make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess failed with exit
status 2
--------------------------------------------------------------------------------
--- End Message ---
--- Begin Message ---
Source: image-factory
Source-Version: 1.0.2-1.2
Done: Adrian Bunk <[email protected]>
We believe that the bug you reported is fixed in the latest version of
image-factory, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adrian Bunk <[email protected]> (supplier of updated image-factory package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 21 Apr 2026 13:27:49 +0300
Source: image-factory
Architecture: source
Version: 1.0.2-1.2
Distribution: unstable
Urgency: medium
Maintainer: Benjamin Drung <[email protected]>
Changed-By: Adrian Bunk <[email protected]>
Closes: 1131652
Changes:
image-factory (1.0.2-1.2) unstable; urgency=medium
.
* Non-maintainer upload.
* Fix FTBFS with recent black. (Closes: #1131652)
Checksums-Sha1:
0331acba11563489edd8571c43e8d35f8f82ad14 2320 image-factory_1.0.2-1.2.dsc
9eb49dfe0b4fcdf78029c6caa11906b251d8c5f1 9728
image-factory_1.0.2-1.2.debian.tar.xz
Checksums-Sha256:
951d4c6245d04fbde12fa17d1e63e081a58d98809f2aa15928412fec295b222f 2320
image-factory_1.0.2-1.2.dsc
2d35ffc88eb5636e0d56a358e38f18184c02088c483f8a42104d50ea3eab25c4 9728
image-factory_1.0.2-1.2.debian.tar.xz
Files:
b92fd85a6f708984258f42de32fb4abe 2320 admin optional
image-factory_1.0.2-1.2.dsc
bfe31381fc1cf66ae80b2e0f9a7d5769 9728 admin optional
image-factory_1.0.2-1.2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAmnnUasACgkQiNJCh6LY
mLGBvxAAsJWagjhjXJdAp5epDYhW4HbbqeHFQrIQq0BhAxi69/P2cMuyY/sPqU9N
B+p5DRLzx4AqSt45HnuMXcFje8PBrC3gZOkt3choYMsW1biB0sionICBi92P6F5h
/B/4eFZW861rnTaT7OJWmKCBehrwEHNDmd85akKzRQc4uvu0Oe60rYSJLr2yQOf0
HqG2f5eFmbG4tKpO3YwErcviyM09VNvdykPUzyQMWZnxLpZBe0IMnDYl4TfUugHO
huYviJQ5W+Qeh8gcg1D53/PenV4Hdmbt6VJQWBIojH36LmpdUfObNn/rPauH8yq2
rSTjOL3P8XUWyTe8mpGBFG8gMcoCmYSsOLX6SsUgTEzHZlH0SO0wNfDurV2kNOYZ
9lrP8272Duse4Ui1EyzQ/3+Za3RepFAGxH9COZNgne5qrWieDkL/OyJl+21PAsSj
Z4wyXICMUCJDQ/XrTw43kfYeNMA8aL6Onr/ok0ZC0/Qkdkvi7UbYCXalDgTl8Qj/
RiraM8wVhUmssBkgQLfmvbDc7jbr+1RGRsWtEmRQ378asnL6cTLHaQPiAf/UwQXf
1ySgtdC9pyUxeFh9sjXa7uDDMHezxoQ3Rd5PbUy58MQgOAkrgVrEmhYRXuPma/Dk
f1/pmLeG4XK/NGiotXpbigDLzK5alYGosuRkiv+xm3AUXyIfPLc=
=c23u
-----END PGP SIGNATURE-----
pgplZ_Sxvrdrs.pgp
Description: PGP signature
--- End Message ---
