Your message dated Fri, 01 Sep 2006 04:47:08 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#385260: fixed in yacpi 2.0.1.1-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: yacpi
Version: 2.0.1-1
Severity: normal
Tags: patch
If there is no battery info, yacpi crashes right after startup with NULL
pointer reference. See the attached patch
-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.17.11
Locale: LANG=hu_HU, LC_CTYPE=hu_HU (charmap=ISO-8859-2)
Versions of packages yacpi depends on:
ii libc6 2.3.5-6 GNU C Library: Shared
libraries an
ii libncurses5 5.4-4 Shared libraries for
terminal hand
-- no debconf information
--- yacpi-1.2.1/yacpi.c.orig 2005-03-30 21:35:39.000000000 +0200
+++ yacpi-1.2.1/yacpi.c 2006-08-30 08:03:29.000000000 +0200
@@ -227,7 +227,7 @@
if (COLS <= 87) {
for (i = 0; i < globals->battery_count; i++) {
binfo = &batteries[i];
- if (binfo->present) {
+ if (binfo && binfo->present) {
mvprintw (line, 0, "Battery %s on %2d%%", binfo->name,
binfo->percentage);
line = line + 2;
@@ -247,14 +247,16 @@
attroff(COLOR_PAIR(3));
}
line=line+2;
- if (binfo->charge_state == CHARGE)
- mvprintw (line, 0, "Battery Status: charging ");
- else if (binfo->charge_state == DISCHARGE)
- mvprintw (line, 0, "Battery Status: discharging");
- else if (binfo->charge_state == CHARGED)
- mvprintw (line, 0, "Battery Status: charged ");
- else if (binfo->charge_state == NOINFO)
- mvprintw (line, 0, "Battery Status: not supported");
+ if (binfo) {
+ if (binfo->charge_state == CHARGE)
+ mvprintw (line, 0, "Battery Status: charging ");
+ else if (binfo->charge_state == DISCHARGE)
+ mvprintw (line, 0, "Battery Status: discharging");
+ else if (binfo->charge_state == CHARGED)
+ mvprintw (line, 0, "Battery Status: charged ");
+ else if (binfo->charge_state == NOINFO)
+ mvprintw (line, 0, "Battery Status: not supported");
+ }
line = line + 2;
if (globals->rtime >= 0 && ap->power != AC) {
mvprintw (line, 0, "Remaining time: %02d:%02d h ",
@@ -262,7 +264,7 @@
line = line + 2;
}
- if (ap->power == AC && binfo->charge_time >= 0) {
+ if (ap->power == AC && binfo && binfo->charge_time >= 0) {
mvprintw (line, 0, "Remaining charge time: %02d:%02d h",
binfo->charge_time / 60, binfo->charge_time % 60);
line = line + 2;
@@ -280,7 +282,7 @@
else {
for (i = 0; i < globals->battery_count; i++) {
binfo = &batteries[i];
- if (binfo->present) {
+ if (binfo && binfo->present) {
mvprintw (line, 0, "%s Capacity [", binfo->name);
color_change (binfo->percentage, 0);
for (i = 0; i <= (binfo->percentage / 2); i++)
@@ -306,14 +308,16 @@
attroff(COLOR_PAIR(3));
}
line = line + 2;
- if (binfo->charge_state == CHARGE)
- mvprintw (line, 0, "Battery Status: charging ");
- else if (binfo->charge_state == DISCHARGE)
- mvprintw (line, 0, "Battery Status: discharging");
- else if (binfo->charge_state == CHARGED)
- mvprintw (line, 0, "Battery Status: charged ");
- else if (binfo->charge_state == NOINFO)
- mvprintw (line, 0, "Battery Status: not supported");
+ if (binfo) {
+ if (binfo->charge_state == CHARGE)
+ mvprintw (line, 0, "Battery Status: charging ");
+ else if (binfo->charge_state == DISCHARGE)
+ mvprintw (line, 0, "Battery Status: discharging");
+ else if (binfo->charge_state == CHARGED)
+ mvprintw (line, 0, "Battery Status: charged ");
+ else if (binfo->charge_state == NOINFO)
+ mvprintw (line, 0, "Battery Status: not supported");
+ }
line = line + 2;
if (globals->rtime >= 0 && ap->power != AC) {
@@ -321,7 +325,7 @@
globals->rtime / 60, globals->rtime % 60);
line = line + 2;
}
- if (ap->power == AC && binfo->charge_time >= 0) {
+ if (ap->power == AC && binfo && binfo->charge_time >= 0) {
mvprintw (line, 0, "Remaining charge time: %02d:%02d h",
binfo->charge_time / 60, binfo->charge_time % 60);
line = line + 2;
--- End Message ---
--- Begin Message ---
Source: yacpi
Source-Version: 2.0.1.1-1
We believe that the bug you reported is fixed in the latest version of
yacpi, which is due to be installed in the Debian FTP archive:
yacpi_2.0.1.1-1.diff.gz
to pool/main/y/yacpi/yacpi_2.0.1.1-1.diff.gz
yacpi_2.0.1.1-1.dsc
to pool/main/y/yacpi/yacpi_2.0.1.1-1.dsc
yacpi_2.0.1.1-1_i386.deb
to pool/main/y/yacpi/yacpi_2.0.1.1-1_i386.deb
yacpi_2.0.1.1.orig.tar.gz
to pool/main/y/yacpi/yacpi_2.0.1.1.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Nico Golde <[EMAIL PROTECTED]> (supplier of updated yacpi package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 31 Aug 2006 14:33:37 +0200
Source: yacpi
Binary: yacpi
Architecture: source i386
Version: 2.0.1.1-1
Distribution: unstable
Urgency: low
Maintainer: Nico Golde <[EMAIL PROTECTED]>
Changed-By: Nico Golde <[EMAIL PROTECTED]>
Description:
yacpi - ncurses based acpi monitor for text mode
Closes: 385260
Changes:
yacpi (2.0.1.1-1) unstable; urgency=low
.
* New upstream release (Closes: #385260).
* Removed dh_installexamples from rules, its not needed.
Files:
dbbb3bc2a67768e8809cf43dedf6fbcf 628 utils optional yacpi_2.0.1.1-1.dsc
599c97065e93a103780a1ee8e0fa8607 20544 utils optional yacpi_2.0.1.1.orig.tar.gz
6ebf7604532825514e18f8ec93f05ea8 2189 utils optional yacpi_2.0.1.1-1.diff.gz
f9f7c72974ebb4fd35b9a77466fd2265 16118 utils optional yacpi_2.0.1.1-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Comment: Fingerprint: 1710 7DB1 9A28 42FF B699 7654 ED1A 3933 B2CF CDD8
iEYEARECAAYFAkT4GgEACgkQ7Ro5M7LPzdiJZwCfaPirPmb+7dvRZwlc9vo8DXjQ
T/kAoItK6gJTaggna+t7V+gdyiY1mwRS
=rDdd
-----END PGP SIGNATURE-----
--- End Message ---
