Your message dated Sun, 03 Sep 2006 19:32:10 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#370180: fixed in cryptsetup 2:1.0.4~rc2-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: cryptsetup
Version: 2:1.0.3-1
Severity: normal
Tags: patch


On a system with a simple cryptoroot setup, the cryptroot initramfs
hook script fails to generate a proper initramfs if no options are
specified in /etc/crypttab for the root block device.

For example, consider the following valid crypttab:

# <target device> <source device> <key file> <options>
cryptroot /dev/whereever
otherfs   /wherever/else /etc/otherkeyfile cipher=aes-cbc-plain


This suggests that cryptroot should be mounted with a password from
stdin (or getcryptpw, or whatever), with the standard options.

man 5 crypttab indicates that [key file] and [options] are not
mandatory columns for rows in this table.

But the hook script assumes no cryptroot if the fourth column is
empty.

Attached is a patch which should resolve the issue (though i haven't
tested it yet!  i've just fleshed out my /etc/crypttab on the affected
system.  When i get around to testing it, i'll post a followup to this
bug).

Feel free to make the patch leaner than i've written it: i have a
harder time writing the test/conditional shell-isms than this script
seems to prefer, so i've written it with explicit if/then shell
constructs.  i hope that doesn't introduce any bashisms, but please
let me know if it does.

Thanks for maintaining this crucial bit of infrastructure!

        --dkg


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (700, 'testing'), (700, 'stable'), (600, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages cryptsetup depends on:
ii  dmsetup       2:1.02.05-2                The Linux Kernel Device Mapper use
ii  libc6         2.3.6-7                    GNU C Library: Shared libraries
ii  libdevmapper1 2:1.02.05-2                The Linux Kernel Device Mapper use
ii  libgcrypt11   1.2.2-1                    LGPL Crypto library - runtime libr
ii  libgpg-error0 1.2-1                      library for common error values an
ii  libpopt0      1.7-5                      lib for parsing cmdline parameters
ii  libuuid1      1.38+1.39-WIP-2006.04.09-2 universally unique id library

cryptsetup recommends no packages.

-- no debconf information
--- cryptsetup-1.0.3.pristine/debian/initramfs-cryptroot-hook   2006-06-03 
16:38:32.000000000 -0400
+++ cryptsetup-1.0.3/debian/initramfs-cryptroot-hook    2006-06-03 
16:46:43.000000000 -0400
@@ -62,8 +62,14 @@
        source=$( echo $opt | cut -d " " -f2 )
        rootopts=$( echo $opt | cut -d " " -f4- )
 
-       [ ! -z "$opt" -a ! -z "$source" -a ! -z "$rootopts" ] || return 1
-       [ ! -z "$extraopts" ] && rootopts="${extraopts},${rootopts}"
+       [ ! -z "$opt" -a ! -z "$source" ] || return 1
+       if [ ! -z "$extraopts" ] ; then
+           if [ -z "$rootopts" ] ; then
+               rootopts="${extraopts},${rootopts}"
+           else
+               rootopts="${extraopts}"
+           fi
+       fi
 
        # We have all the basic options, let's go trough them
        echo -n "target=$target,source=$source"

--- End Message ---
--- Begin Message ---
Source: cryptsetup
Source-Version: 2:1.0.4~rc2-1

We believe that the bug you reported is fixed in the latest version of
cryptsetup, which is due to be installed in the Debian FTP archive:

cryptsetup-udeb_1.0.4~rc2-1_amd64.udeb
  to pool/main/c/cryptsetup/cryptsetup-udeb_1.0.4~rc2-1_amd64.udeb
cryptsetup_1.0.4~rc2-1.diff.gz
  to pool/main/c/cryptsetup/cryptsetup_1.0.4~rc2-1.diff.gz
cryptsetup_1.0.4~rc2-1.dsc
  to pool/main/c/cryptsetup/cryptsetup_1.0.4~rc2-1.dsc
cryptsetup_1.0.4~rc2-1_amd64.deb
  to pool/main/c/cryptsetup/cryptsetup_1.0.4~rc2-1_amd64.deb
cryptsetup_1.0.4~rc2.orig.tar.gz
  to pool/main/c/cryptsetup/cryptsetup_1.0.4~rc2.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Meurer <[EMAIL PROTECTED]> (supplier of updated cryptsetup package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon,  4 Sep 2006 03:55:35 +0200
Source: cryptsetup
Binary: cryptsetup cryptsetup-udeb
Architecture: source amd64
Version: 2:1.0.4~rc2-1
Distribution: unstable
Urgency: low
Maintainer: Jonas Meurer <[EMAIL PROTECTED]>
Changed-By: Jonas Meurer <[EMAIL PROTECTED]>
Description: 
 cryptsetup - configures encrypted block devices
 cryptsetup-udeb - configures encrypted block devices (udeb)
Closes: 370180 370302 375913 376941 378422 379084 379719 379723 379726 379737 
379771
Changes: 
 cryptsetup (2:1.0.4~rc2-1) unstable; urgency=low
 .
   [ Jonas Meurer ]
   * Add some more german translations to de.po.
   * Add a note to NEWS.Debian where the fix for #376393 is explained. thanks
     to Robert Bihlmeyer for the report. (closes: #379719)
   * Allow swap filesystems to be overwritten when the swap flag is set. thanks
     to Raphaël Quinet for the report. (closes: #379771)
   * Update to upstream 1.0.4-rc2. (closes: #378422, #379726, closes: #379723)
   * removed patches 03-05, merged upstream.
   * [01_terminal_output.dpatch] updated for new upstream.
   * [02_docs_tries.dpatch] updated for new upstream, to fix luksDelKey
     documentation and to give more information about the keysize.
     (closes: #379084)
 .
   [ David Härdeman ]
   * Make sure that README.initramfs is included in the package (closes
     #380048)
   * Replace panic calls in cryptsetup script with exit 1 to match the
     behaviour of other scripts. The regular initramfs script will panic
     later when root isn't detected anyway
   * Make all four fields in crypttab mandatory (closes: #370180,
     #376941)
   * Add UTF8 keyboard input support to initramfs image (closes: #379737)
   * Add a keyscript option (closes: #370302, #375913)
   * [03_fix_build_error.dpatch] patch po/Makefile with more recent
     gettext implementation.
Files: 
 cfeaca3ee2a1e19e73a005d05ebceafc 825 admin optional cryptsetup_1.0.4~rc2-1.dsc
 b31e0e44b5fae931765bb97507a7dd58 424259 admin optional 
cryptsetup_1.0.4~rc2.orig.tar.gz
 733c3b86cc0870a3a727eb7cd8a9d1a1 38337 admin optional 
cryptsetup_1.0.4~rc2-1.diff.gz
 03cefc02c1f23dc71668e530492425c6 254700 admin optional 
cryptsetup_1.0.4~rc2-1_amd64.deb
 bbcb0327cd56cc332f420339cb9ea08c 183354 debian-installer optional 
cryptsetup-udeb_1.0.4~rc2-1_amd64.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFE+4lwd6lUs+JfIQIRAjaQAJ9HtmN1jlyLWNaywGCUDIJ2uuqiyACglFbn
ZesO+JpshwSrquu8N9r4vC8=
=cfyS
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to