Your message dated Thu, 21 Sep 2006 10:02:06 -0700 with message-id <[EMAIL PROTECTED]> and subject line Bug#388463: fixed in debpartial-mirror 0.2.94 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Subject: debpartial-mirror: InvalidSection exception not caught in the case of invalid 'resolve_deps_using' option Package: debpartial-mirror Version: 0.2.93 Severity: normal Tags: patch Every time a Config instance is created, debpartial-mirror catches InvalidSection exceptions, that's ok. But when the configuration file lists an invalid backend in 'resolve_deps_using', debpartial-mirror crashes like this: [EMAIL PROTECTED]:~/hacking/src/debpartial-mirror/debpartial-mirror-0.2.93$ ./debpartial-mirror -c mirror.conf all Traceback (most recent call last): File "./debpartial-mirror", line 246, in ? main() File "./debpartial-mirror", line 208, in main (cnf_mirrors, cnf_merges) = cnf.get_backends() File "/home/terceiro/hacking/src/debpartial-mirror/debpartial-mirror-0.2.93/debpartial_mirror/Config.py", line 342, in get_backends self.check_dependencies(backend) File "/home/terceiro/hacking/src/debpartial-mirror/debpartial-mirror-0.2.93/debpartial_mirror/Config.py", line 336, in check_dependencies raise InvalidSection(section) NameError: global name 'section' is not defined The solution I found is to check dependency section straight in the constructor, instead doing that when get_backends is called. The attached patch fixes the problem. -- System Information: Debian Release: testing/unstable APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.16-2-em64t-p4-smp Locale: LANG=pt_BR.utf8, LC_CTYPE=pt_BR.utf8 (charmap=UTF-8) -- Antonio S. de A. Terceiro <[EMAIL PROTECTED]> http://people.softwarelivre.org/~terceiro/ GnuPG ID: E6F73C30Index: debpartial_mirror/Config.py =================================================================== --- debpartial_mirror/Config.py (revisão 740) +++ debpartial_mirror/Config.py (cópia de trabalho) @@ -297,6 +297,10 @@ if not isinstance(section, ConfigGlobal): self.backends[section.section] = section + # Check backend dependencies + for backend in self.backends.keys(): + self.check_dependencies(backend) + def __get_section_type(self, section): # detect which config type this is if section == 'GLOBAL': @@ -337,10 +341,6 @@ def get_backends(self): - # Check backend dependencies - for backend in self.backends.keys(): - self.check_dependencies(backend) - # Sort backends unsorted = self.backends.values() sorted = []
--- End Message ---
--- Begin Message ---Source: debpartial-mirror Source-Version: 0.2.94 We believe that the bug you reported is fixed in the latest version of debpartial-mirror, which is due to be installed in the Debian FTP archive: debpartial-mirror_0.2.94.dsc to pool/main/d/debpartial-mirror/debpartial-mirror_0.2.94.dsc debpartial-mirror_0.2.94.tar.gz to pool/main/d/debpartial-mirror/debpartial-mirror_0.2.94.tar.gz debpartial-mirror_0.2.94_all.deb to pool/main/d/debpartial-mirror/debpartial-mirror_0.2.94_all.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Otavio Salvador <[EMAIL PROTECTED]> (supplier of updated debpartial-mirror package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Thu, 21 Sep 2006 13:46:36 -0300 Source: debpartial-mirror Binary: debpartial-mirror Architecture: source all Version: 0.2.94 Distribution: unstable Urgency: low Maintainer: Otavio Salvador <[EMAIL PROTECTED]> Changed-By: Otavio Salvador <[EMAIL PROTECTED]> Description: debpartial-mirror - tools to create partial Debian mirrors Closes: 388463 388465 Changes: debpartial-mirror (0.2.94) unstable; urgency=low . [ Otavio Salvador ] * Applied patch from "Antonio S. de A. Terceiro" <[EMAIL PROTECTED]> to fix a wrong variable name. Closes: #388465 * Applied patch from "Antonio S. de A. Terceiro" <[EMAIL PROTECTED]> to fix the dependency checking of backends. Closes: #388463 . [ Tiago Bortoletto Vaz ] * More changes in Pool.py, that didn't use full paths to compare unneeded files then removing needed ones. * Cleaning Pool.py code. Files: 7d25c3e5f91558db3c7afc204ff4e2d9 631 net extra debpartial-mirror_0.2.94.dsc c49092b96359e7b17202b78833ec2c6e 89588 net extra debpartial-mirror_0.2.94.tar.gz cb8107a9fe9933c4743407b2475722d5 24008 net extra debpartial-mirror_0.2.94_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFFEsIWLqiZQEml+FURAuQIAJ9I0+Iq5HdD3EdGuoPcwCH4VZk39wCffqJf AlC/8ieNSiKPRj+Ii9kdqQ0= =9pEC -----END PGP SIGNATURE-----
--- End Message ---
