Your message dated Sat, 28 Oct 2006 14:19:35 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#395014: fixed in oprofile 0.9.2-2
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: oprofile-common
Version: 0.9.2-1
Severity: important
Tags: patch


The /bin/sh script /usr/bin/opcontrol lacks some $ signs in $(( ))
expressions.  Furthermore, I tend to believe that the construct does
not work in plain Bourne shells, meaning that the #!/bin/sh line
should be replaced with #!/bin/bash.  However, I am unsure of that.

Here is the patch:

--- /usr/bin/opcontrol  2006-09-22 07:08:59.000000000 +0300
+++ opcontrol   2006-10-24 15:27:22.425303088 +0300
@@ -316,7 +316,7 @@ do_save_setup()
        >$SETUP_FILE
 
        if test "$NR_CHOSEN" != "0"; then
-               for f in `seq 0 $((NR_CHOSEN - 1))`; do
+               for f in `seq 0 $(($NR_CHOSEN - 1))`; do
                        get_event $f
                        echo "CHOSEN_EVENTS_${f}=$GOTEVENT" >>$SETUP_FILE
                done
@@ -537,7 +537,7 @@ verify_counters()
        OPHELP_ARGS=
 
        if test "$NR_CHOSEN" != 0; then
-               for f in `seq 0 $((NR_CHOSEN - 1))`; do
+               for f in `seq 0 $(($NR_CHOSEN - 1))`; do
                        get_event $f
                        if test "$GOTEVENT" != ""; then
                                OPHELP_ARGS="$OPHELP_ARGS $GOTEVENT"
@@ -559,7 +559,7 @@ normalise_events()
                return
        fi
 
-       for f in `seq 0 $((NR_CHOSEN - 1))`; do
+       for f in `seq 0 $(($NR_CHOSEN - 1))`; do
                get_event $f
                if test "$GOTEVENT" != ""; then
                        EVENT=`echo $GOTEVENT | awk -F: '{print $1}'`
@@ -1106,7 +1106,7 @@ do_param_setup()
        verify_counters
 
        OPROFILED_EVENTS=
-       for f in `seq 0 $((NR_CHOSEN - 1))`; do
+       for f in `seq 0 $(($NR_CHOSEN - 1))`; do
                get_event $f
                if test "$GOTEVENT" != ""; then
                        EVENT=`echo $GOTEVENT | awk -F: '{print $1}'`
@@ -1238,7 +1238,7 @@ do_status()
        fi
 
        if test "$NR_CHOSEN" != "0"; then
-               for f in `seq 0 $((NR_CHOSEN - 1))`; do
+               for f in `seq 0 $(($NR_CHOSEN - 1))`; do
                        get_event $f
                        echo "Event $f: $GOTEVENT"
                done

Best regards,

        Marko
-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18
Locale: LANG=fi_FI, LC_CTYPE=fi_FI.utf8 (charmap=UTF-8)

Versions of packages oprofile-common depends on:
ii  binutils                     2.17-3      The GNU assembler, linker and bina
ii  debconf [debconf-2.0]        1.5.6       Debian configuration management sy
ii  libc6                        2.3.6.ds1-7 GNU C Library: Shared libraries
ii  libgcc1                      1:4.1.1-17  GCC support library
ii  libpopt0                     1.10-3      lib for parsing cmdline parameters
ii  libstdc++6                   4.1.1-17    The GNU Standard C++ Library v3

oprofile-common recommends no packages.

-- no debconf information


--- End Message ---
--- Begin Message ---
Source: oprofile
Source-Version: 0.9.2-2

We believe that the bug you reported is fixed in the latest version of
oprofile, which is due to be installed in the Debian FTP archive:

oprofile-common_0.9.2-2_i386.deb
  to pool/main/o/oprofile/oprofile-common_0.9.2-2_i386.deb
oprofile-gui_0.9.2-2_i386.deb
  to pool/main/o/oprofile/oprofile-gui_0.9.2-2_i386.deb
oprofile_0.9.2-2.diff.gz
  to pool/main/o/oprofile/oprofile_0.9.2-2.diff.gz
oprofile_0.9.2-2.dsc
  to pool/main/o/oprofile/oprofile_0.9.2-2.dsc
oprofile_0.9.2-2_i386.deb
  to pool/main/o/oprofile/oprofile_0.9.2-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Al Stone <[EMAIL PROTECTED]> (supplier of updated oprofile package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 28 Oct 2006 11:41:45 -0600
Source: oprofile
Binary: oprofile-common oprofile oprofile-gui
Architecture: source i386
Version: 0.9.2-2
Distribution: unstable
Urgency: low
Maintainer: Al Stone <[EMAIL PROTECTED]>
Changed-By: Al Stone <[EMAIL PROTECTED]>
Description: 
 oprofile   - system-wide profiler for Linux systems
 oprofile-common - system-wide profiler for Linux systems (command line 
components)
 oprofile-gui - system-wide profiler for Linux systems (GUI components)
Closes: 392836 394017 395014
Changes: 
 oprofile (0.9.2-2) unstable; urgency=low
 .
   * Deprecating use of oprofile-source; this is only needed for 2.4
     kernels, and is no longer actively maintained.  The functionality
     provided is now included in Linux 2.6 kernels by default.
   * Closes: bug#394017 -- oprofile-source: Obsolete - please remove
   * Closes: bug#392836 -- oprofile-source: fails to build
   * Closes: bug#395014 -- [PATCH] Make opcontrol work with bash (used
     the patch directly)
Files: 
 aed40d94d557ef404c023869427e4685 769 devel optional oprofile_0.9.2-2.dsc
 fdd607f897003b9d00f5d3c73a1a177c 42163 devel optional oprofile_0.9.2-2.diff.gz
 e90bbef0f19dc416087030589bbe80c4 189336 devel optional 
oprofile_0.9.2-2_i386.deb
 176846d1c105286fe13f74067b31d551 4052208 devel optional 
oprofile-common_0.9.2-2_i386.deb
 0de2fa102587d0e771a619084f502cf2 93778 devel optional 
oprofile-gui_0.9.2-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFQ7IRso6+T7qY4V0RAkt+AJ0U4lCA4fKrNgIHaC+P1SZuP7mRwgCgiqS+
UYkR3mPNr0juKVVpEeweMwc=
=gPsl
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to