Your message dated Wed, 01 Nov 2006 15:51:31 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#395176: fixed in nagios-plugins 1.4.4-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: nagios-plugins
Version: 1.4.3.0cvs.20060707-3
Tags: patch

Specifying more than one -e (expect reponse string) argument to
check_tcp leads to SEGV.


Simplified examples:

"check_tcp -H server -p port -s test -e foo"        works

"check_tcp -H server -p port -s test -e foo -e bar" segfaults.

Real-life example (server name hidden):

roessner(gorkon)~$ /usr/lib/nagios/plugins/check_tcp -H <hidden>  -p 143 -s '0 
foo' -e test -e test2 -v
Using service TCP
Port: 143
flags: 0x2
Send string: 0 foo
server_expect_count: 2
        0: (null)
        1: test2
received 64 bytes from host
#-raw-recv-------#
* OK magellan Cyrus IMAP4 v2.2.13-Debian-2.2.13-3 server ready

#-raw-recv-------#
looking for [(null)] anywhere in [* OK magellan Cyrus IMAP4 
v2.2.13-Debian-2.2.13-3 server ready]
Segmentation fault
roessner(gorkon)~$


You will notice the "0: (null)" entry in the list of expected strings.
This is due to bad argument parsing in check_tcp.c . The first argument
string is explicitly overwritten with a NULL, which is a Bad Thing and
serves no useful purpose.


Patch to resolve this:

*** nagios-plugins-1.4.3.0cvs.20060707/plugins/check_tcp.c.orig 2006-09-28 
18:56:19.000000000 +0200
--- nagios-plugins-1.4.3.0cvs.20060707/plugins/check_tcp.c      2006-09-28 
19:05:11.000000000 +0200
***************
*** 500,506 ****
                                asprintf(&server_send, "%s", optarg);
                        break;
                case 'e': /* expect string (may be repeated) */
-                       EXPECT = NULL;
                        flags &= ~FLAG_EXACT_MATCH;
                        if (server_expect_count == 0)
                                server_expect = malloc (sizeof (char *) * 
(++server_expect_count));
--- 500,505 ----


This bug was reported to upstream already as part of sourceforge project
nagiosplug / bug id 1475899. I have recently added some details there in
the hope that this will be fixed some time soon (that report dates from
april 24th).

Regards,
   Ralph Rößner


--- End Message ---
--- Begin Message ---
Source: nagios-plugins
Source-Version: 1.4.4-1

We believe that the bug you reported is fixed in the latest version of
nagios-plugins, which is due to be installed in the Debian FTP archive:

nagios-plugins-basic_1.4.4-1_amd64.deb
  to pool/main/n/nagios-plugins/nagios-plugins-basic_1.4.4-1_amd64.deb
nagios-plugins-standard_1.4.4-1_amd64.deb
  to pool/main/n/nagios-plugins/nagios-plugins-standard_1.4.4-1_amd64.deb
nagios-plugins_1.4.4-1.diff.gz
  to pool/main/n/nagios-plugins/nagios-plugins_1.4.4-1.diff.gz
nagios-plugins_1.4.4-1.dsc
  to pool/main/n/nagios-plugins/nagios-plugins_1.4.4-1.dsc
nagios-plugins_1.4.4-1_amd64.deb
  to pool/main/n/nagios-plugins/nagios-plugins_1.4.4-1_amd64.deb
nagios-plugins_1.4.4.orig.tar.gz
  to pool/main/n/nagios-plugins/nagios-plugins_1.4.4.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
sean finney <[EMAIL PROTECTED]> (supplier of updated nagios-plugins package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 01 Nov 2006 22:57:16 +0100
Source: nagios-plugins
Binary: nagios-plugins nagios-plugins-basic nagios-plugins-standard
Architecture: source amd64
Version: 1.4.4-1
Distribution: unstable
Urgency: low
Maintainer: Debian Nagios Maintainer Group <[EMAIL PROTECTED]>
Changed-By: sean finney <[EMAIL PROTECTED]>
Description: 
 nagios-plugins - Plugins for the nagios network monitoring and management 
system
 nagios-plugins-basic - Plugins for the nagios network monitoring and 
management system
 nagios-plugins-standard - Plugins for the nagios network monitoring and 
management system
Closes: 339971 351847 395176
Changes: 
 nagios-plugins (1.4.4-1) unstable; urgency=low
 .
   [sean finney]
   * new upstream release.  actually, we've been basing previous versions
     on cvs snapshots so the changes aren't that big.
   * upstream includes fix for warn/crit handling in check_tcp based plugins
     such as check_simap (closes: #351847).
   * dpkg's conffile handling can't deal with migrating config files
     from nagios-plugins to nagios-plugins-foo, so we're now managing
     all the config files via ucf (closes: #339971).
   * remove some unneeded build-deps, and bump Standards-Version
   * fix for multiple expect strings in check_tcp.c.  thanks to Ralph Rößner
     for finding this (closes: #395176).
Files: 
 55d68da8b8dc4ce40e28f7f984f62a3f 1023 net extra nagios-plugins_1.4.4-1.dsc
 e27849f268ab04014bfbbd19d9af1333 1296190 net extra 
nagios-plugins_1.4.4.orig.tar.gz
 14f94d73d4af8f587dd48e83c3ff1596 19428 net extra nagios-plugins_1.4.4-1.diff.gz
 7eb7dfff10090b1fcfaf768148c63601 79186 net extra 
nagios-plugins_1.4.4-1_amd64.deb
 490d91decc95967aeb884a1670314c40 514190 net extra 
nagios-plugins-basic_1.4.4-1_amd64.deb
 67569137abf0ca2bfc5fa5c085220918 237618 net extra 
nagios-plugins-standard_1.4.4-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFSRnIynjLPm522B0RAsf6AJ0X73OeE7295qibjzZrJpg3pQfIoQCfRgV8
MSmAgROYGFGMoGgCzZoEjig=
=PqyD
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to